build tests failing

[davehorton]

Describe the bug

any reason why the tests fail when compiling? This is a pretty basic install on debian 12 using the latest code with this command

  cmake .. -DBUILD_TESTING=OFF -DBUILD_ONLY="s3;core;s3-crt;lexv2-runtime;transcribestreaming;bedrock-runtime;bedrock" -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_SHARED_LIBS=ON -DCMAKE_CXX_FLAGS="-Wno-unused-parameter -Wno-error=nonnull -Wno-error=deprecated-declarations -Wno-error=uninitialized -Wno-error=maybe-uninitialized -Wno-error=array-bounds"

with the result being

p.o
[ 85%] Linking CXX executable s3-gen-tests
/usr/local/src/aws-sdk-cpp/generated/tests/s3-gen-tests/S3EndpointProviderTests.cpp:3115: Failure
Expected equality of these values:
  outcome.GetResult().GetURL()
    Which is: "https://mybucket--abcd-ab1--x-s3.s3express-abcd-ab1.cn-north-1.amazonaws.com"
  expect.endpoint.url
    Which is: "https://mybucket--abcd-ab1--x-s3.s3express-abcd-ab1.cn-north-1.amazonaws.com.cn"
Google Test trace:
/usr/local/src/aws-sdk-cpp/generated/tests/s3-gen-tests/S3EndpointProviderTests.cpp:3181:
--gtest_filter=EndpointTestsFromModel/S3EndpointProviderTests.EndpointProviderTest/275
/usr/local/src/aws-sdk-cpp/generated/tests/s3-gen-tests/S3EndpointProviderTests.cpp:3180:
TEST CASE # 275: Data Plane with short zone name china region
[  FAILED  ] EndpointTestsFromModel/S3EndpointProviderTests.EndpointProviderTest/275, where GetParam() = 275 (1 ms)
/usr/local/src/aws-sdk-cpp/generated/tests/s3-gen-tests/S3EndpointProviderTests.cpp:3115: Failure
Expected equality of these values:
  outcome.GetResult().GetURL()
    Which is: "https://myaccesspoint--abcd-ab1--xa-s3.s3.us-east-1.amazonaws.com"
  expect.endpoint.url
    Which is: "https://myaccesspoint--abcd-ab1--xa-s3.s3express-abcd-ab1.us-east-1.amazonaws.com"
Google Test trace:

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

I expected build tests to pass

Current Behavior

build tests fail

Reproduction Steps

build the latest with the cmake command abovve

Possible Solution

No response

Additional Information/Context

No response

AWS CPP SDK version used

1.11.570

Compiler and Version used

gcc (Debian 12.2.0-14) 12.2.0

Operating System and version

Debian 12.2.0-14

[SergeyRyabinin]

Hi Dave!
Thank you for submitting this issue!
This test is not expected to fail.

Could you please check that:

• CRT submodule is up to date (updated/checked out to the one set on the SDK repo);
• there is no environment variable AWS_S3_DISABLE_S3_EXPRESS_AUTH or AWS shared config file with a "default" profile with a property s3_disable_s3_express_auth.

These are two possible things I would imagine to produce the issue you observe.

Best regards,
Sergey

[davehorton]

Hmm, I am just using the CRT that is in the repo I think...isn't it bundled? And there is no AWS_S3_DISABLE_S3_EXPRESS_AUTH or other env set

[sbiscigl]

Tried replicating in a clean environment in docker, and im seeing it working as expected

FROM public.ecr.aws/debian/debian:12.2
RUN  apt-get update &&\
     apt install -y build-essential git libcurl4-openssl-dev zlib1g-dev libssl-dev cmake

RUN git clone --depth 1 --recurse-submodules https://github.com/aws/aws-sdk-cpp && \
    cd aws-sdk-cpp && \
    mkdir build && \
    cd build && \
    cmake .. -DBUILD_TESTING=OFF \
      -DBUILD_ONLY="s3;core;s3-crt;lexv2-runtime;transcribestreaming;bedrock-runtime;bedrock" \
      -DCMAKE_BUILD_TYPE=RelWithDebInfo \
      -DBUILD_SHARED_LIBS=ON \
      -DCMAKE_CXX_FLAGS="-Wno-unused-parameter -Wno-error=nonnull -Wno-error=deprecated-declarations -Wno-error=uninitialized -Wno-error=maybe-uninitialized -Wno-error=array-bounds" &&\
    cmake --build . && \
    cmake --install .

would suggest starting by looking for differences between your env and a clean one

[DmitriyMusatkin]

its resolving cn-north-1.amazonaws.com dns host instead of cn-north-1.amazonaws.com.cn.
Since express didnt support CN until recently my guess is ruleset might be outdated.
Updating submodules and rebuilding everything will probably fix it

[github-actions]

Greetings! It looks like this issue hasn’t been active in longer than a week. We encourage you to check if this is still an issue in the latest release. Because it has been longer than a week since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or add an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.