Cannot compile

[QWERTIOX]

Describe the bug

Build fails on WSL Debian (didn't test other platforms)

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

Not fail

Current Behavior

[348/653] Building C object crt/aws-crt-cpp/crt/aws-c-io/CMakeFiles/aws-c-io.dir/source/s2n/s2n_tls_channel_handler.c.o
/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-io/source/s2n/s2n_tls_channel_handler.c:1345:20: warning: default initialization of an object of type 'const char[4][128]' leaves the object uninitialized [-Wdefault-const-init-var-unsafe]
 1345 |         const char protocols_cpy[4][128];
      |                    ^
/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-io/source/s2n/s2n_tls_channel_handler.c:1722:20: warning: default initialization of an object of type 'const char[4][128]' leaves the object uninitialized [-Wdefault-const-init-var-unsafe]
 1722 |         const char protocols_cpy[4][128];
      |                    ^
2 warnings generated.
[510/653] Building CXX object src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/source/Globals.cpp.o
FAILED: src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/source/Globals.cpp.o 
/usr/bin/c++ -DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_CRT_CPP_USE_IMPORT_EXPORT -DAWS_ENABLE_EPOLL -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_HAS_ALIGNED_ALLOC -DAWS_HTTP_USE_IMPORT_EXPORT -DAWS_IO_USE_IMPORT_EXPORT -DAWS_MQTT_USE_IMPORT_EXPORT -DAWS_S3_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11 -DAWS_SDK_VERSION_PATCH=577 -DAWS_TEST_REGION=US_EAST_1 -DCURL_HAS_H2 -DCURL_HAS_TLS_PROXY -DENABLED_REQUEST_COMPRESSION -DENABLED_ZLIB_REQUEST_COMPRESSION -DENABLE_CURL_CLIENT -DENABLE_CURL_LOGGING -DENFORCE_TLS_V1_2 -DHAS_PATHCONF -DHAS_UMASK -DPLATFORM_LINUX -DSMITHY_EXPORTS=1 -DUSE_IMPORT_EXPORT=1 -Daws_cpp_sdk_core_EXPORTS -I/home/qwertiox/dev/aws-sdk-cpp/src/aws-cpp-sdk-core/include/aws/core/platform/refs -I/home/qwertiox/dev/aws-sdk-cpp/src/aws-cpp-sdk-core/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/include -I/home/qwertiox/dev/aws-sdk-cpp/build/crt/aws-crt-cpp/generated/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-http/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-io/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/api -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-common/include -I/home/qwertiox/dev/aws-sdk-cpp/build/crt/aws-crt-cpp/crt/aws-c-common/generated/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-cal/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-compression/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-mqtt/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-auth/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-sdkutils/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-checksums/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-event-stream/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-s3/include -g -fPIC -fno-exceptions -std=c++11 -Wall -pedantic -Wextra -Werror -fPIC -MD -MT src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/source/Globals.cpp.o -MF src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/source/Globals.cpp.o.d -o src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/source/Globals.cpp.o -c /home/qwertiox/dev/aws-sdk-cpp/src/aws-cpp-sdk-core/source/Globals.cpp
In file included from /home/qwertiox/dev/aws-sdk-cpp/src/aws-cpp-sdk-core/source/Globals.cpp:6:
In file included from /home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/include/aws/crt/Api.h:9:
/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/include/aws/crt/mqtt/Mqtt5Client.h:436:25: error: virtual method '~Mqtt5Client' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
  436 |                 virtual ~Mqtt5Client();
      |                         ^
/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/include/aws/crt/mqtt/Mqtt5Client.h:699:25: error: virtual method '~Mqtt5ClientOptions' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
  699 |                 virtual ~Mqtt5ClientOptions();
      |                         ^
2 errors generated.
[526/653] Building CXX object src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/ub_core.cpp.o
FAILED: src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/ub_core.cpp.o 
/usr/bin/c++ -DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_CRT_CPP_USE_IMPORT_EXPORT -DAWS_ENABLE_EPOLL -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_HAS_ALIGNED_ALLOC -DAWS_HTTP_USE_IMPORT_EXPORT -DAWS_IO_USE_IMPORT_EXPORT -DAWS_MQTT_USE_IMPORT_EXPORT -DAWS_S3_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11 -DAWS_SDK_VERSION_PATCH=577 -DAWS_TEST_REGION=US_EAST_1 -DCURL_HAS_H2 -DCURL_HAS_TLS_PROXY -DENABLED_REQUEST_COMPRESSION -DENABLED_ZLIB_REQUEST_COMPRESSION -DENABLE_CURL_CLIENT -DENABLE_CURL_LOGGING -DENFORCE_TLS_V1_2 -DHAS_PATHCONF -DHAS_UMASK -DPLATFORM_LINUX -DSMITHY_EXPORTS=1 -DUSE_IMPORT_EXPORT=1 -Daws_cpp_sdk_core_EXPORTS -I/home/qwertiox/dev/aws-sdk-cpp/src/aws-cpp-sdk-core/include/aws/core/platform/refs -I/home/qwertiox/dev/aws-sdk-cpp/src/aws-cpp-sdk-core/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/include -I/home/qwertiox/dev/aws-sdk-cpp/build/crt/aws-crt-cpp/generated/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-http/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-io/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/s2n/api -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-common/include -I/home/qwertiox/dev/aws-sdk-cpp/build/crt/aws-crt-cpp/crt/aws-c-common/generated/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-cal/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-compression/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-mqtt/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-auth/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-sdkutils/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-checksums/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-event-stream/include -I/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-s3/include -g -fPIC -fno-exceptions -std=c++11 -Wall -pedantic -Wextra -Werror -fPIC -MD -MT src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/ub_core.cpp.o -MF src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/ub_core.cpp.o.d -o src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/ub_core.cpp.o -c /home/qwertiox/dev/aws-sdk-cpp/build/src/aws-cpp-sdk-core/ub_core.cpp
In file included from /home/qwertiox/dev/aws-sdk-cpp/build/src/aws-cpp-sdk-core/ub_core.cpp:4:
In file included from /home/qwertiox/dev/aws-sdk-cpp/src/aws-cpp-sdk-core/source/auth/GeneralHTTPCredentialsProvider.cpp:9:
In file included from /home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/include/aws/crt/Api.h:9:
/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/include/aws/crt/mqtt/Mqtt5Client.h:436:25: error: virtual method '~Mqtt5Client' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
  436 |                 virtual ~Mqtt5Client();
      |                         ^
/home/qwertiox/dev/aws-sdk-cpp/crt/aws-crt-cpp/include/aws/crt/mqtt/Mqtt5Client.h:699:25: error: virtual method '~Mqtt5ClientOptions' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
  699 |                 virtual ~Mqtt5ClientOptions();
      |                         ^
2 errors generated.
[527/653] Building CXX object generated/src/aws-cpp-sdk-s3/CMakeFiles/aws-cpp-sdk-s3.dir/ub_S3.cpp.o
ninja: build stopped: subcommand failed.

Reproduction Steps

From history:

git clone --recurse-submodules https://github.com/aws/aws-sdk-cpp
cd aws-sdk-cpp/
mkdir build
cd build/
cmake .. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/usr/local/ -DBUILD_ONLY="s3" -GNinja
cmake --build . --config=Debug

Possible Solution

Provide precompiled libraries

Additional Information/Context

cmake version 3.25.1

AWS CPP SDK version used

1.11.577

Compiler and Version used

Debian clang version 21.0.0 (++20250528112455+6c86b7d7d8bc-1exp120250528112510.1477) Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm-21/bin

Operating System and version

Windows WSL Debian 12.11

[QWERTIOX]

Also fails for clang-19

Debian clang version 19.1.4 (1~deb12u1)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm-19/bin

[sfod]

The unnecessary-virtual-specifier warnings are from aws-crt-cpp project. I'll create an internal ticket to track this issue.

[sbiscigl]

Created a PR to bump the CRT version to fix that error, looks like after that we hit another error

211.6 [ 87%] Building CXX object tests/testing-resources/CMakeFiles/testing-resources.dir/source/AwsCppSdkGTestSuite.cpp.o
211.9 In file included from /aws-sdk-cpp/tests/testing-resources/source/AwsCppSdkGTestSuite.cpp:6:
211.9 In file included from /aws-sdk-cpp/tests/testing-resources/include/aws/testing/AwsCppSdkGTestSuite.h:8:
211.9 In file included from /aws-sdk-cpp/tests/testing-resources/include/aws/external/gtest/gtest.h:60:
211.9 In file included from /aws-sdk-cpp/tests/testing-resources/include/aws/external/gtest/gtest-death-test.h:43:
211.9 In file included from /aws-sdk-cpp/tests/testing-resources/include/aws/external/gtest/internal/gtest-death-test-internal.h:46:
211.9 In file included from /aws-sdk-cpp/tests/testing-resources/include/aws/external/gtest/gtest-matchers.h:48:
211.9 /aws-sdk-cpp/tests/testing-resources/include/aws/external/gtest/gtest-printers.h:473:35: error: implicit conversion from 'char16_t' to 'char32_t' may change the meaning of the represented code unit [-Werror,-Wcharacter-conversion]
211.9   473 |   PrintTo(ImplicitCast_<char32_t>(c), os);
211.9       |           ~~~~~~~~~~~~~           ^
212.4 1 error generated.
212.4 gmake[2]: *** [tests/testing-resources/CMakeFiles/testing-resources.dir/build.make:77: tests/testing-resources/CMakeFiles/testing-resources.dir/source/AwsCppSdkGTestSuite.cpp.o] Error 1
212.4 gmake[1]: *** [CMakeFiles/Makefile2:825: tests/testing-resources/CMakeFiles/testing-resources.dir/all] Error 2
212.4 gmake: *** [Makefile:136: all] Error 2

which sounds like i need to update our vended gtest, working on that

[sbiscigl]

alright merged that change, your build should be working now, give a shout if you see anything else!

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.