Skip to content

Commit 2cc8c5c

Browse files
committed
* remove unneeded warnings
* add defrecord
1 parent 3e630af commit 2cc8c5c

File tree

1 file changed

+21
-11
lines changed

1 file changed

+21
-11
lines changed

src/test/clojure/cljs/analyzer/spec_tests.clj

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -60,30 +60,40 @@
6060
(let [node (no-warn (analyze ns-env '(def x)))]
6161
(is (= :def (:op node)))
6262
(is (s/valid? ::a/node node)))
63-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(def x 1)))))
64-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(def x (fn []))))))
65-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(def x (fn [y] y)))))))
63+
(is (s/valid? ::a/node (analyze ns-env '(def x 1))))
64+
(is (s/valid? ::a/node (analyze ns-env '(def x (fn [])))))
65+
(is (s/valid? ::a/node (analyze ns-env '(def x (fn [y] y))))))
6666

6767
(deftest test-fn
6868
(let [node (no-warn (analyze ns-env '(fn [])))]
6969
(is (= :fn (:op node)))
7070
(is (s/valid? ::a/node node)))
71-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(fn [] 1)))))
72-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(fn [x])))))
73-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(fn [x] 1))))))
71+
(is (s/valid? ::a/node (analyze ns-env '(fn [] 1))))
72+
(is (s/valid? ::a/node (analyze ns-env '(fn [x]))))
73+
(is (s/valid? ::a/node (analyze ns-env '(fn [x] 1)))))
7474

7575
(deftest test-defn
76-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(defn x [])))))
77-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(defn x [] 1)))))
78-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(defn x [y] y))))))
76+
(is (s/valid? ::a/node (analyze ns-env '(defn x []))))
77+
(is (s/valid? ::a/node (analyze ns-env '(defn x [] 1))))
78+
(is (s/valid? ::a/node (analyze ns-env '(defn x [y] y)))))
7979

8080
(deftest test-new
8181
(let [node (no-warn (analyze ns-env '(new String)))]
8282
(is (= :new (:op node)))
8383
(is (s/valid? ::a/node node)))
84-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(new js/String)))))
84+
(is (s/valid? ::a/node (analyze ns-env '(new js/String))))
8585
(is (s/valid? ::a/node (no-warn (analyze ns-env '(String.)))))
86-
(is (s/valid? ::a/node (no-warn (analyze ns-env '(js/String.))))))
86+
(is (s/valid? ::a/node (analyze ns-env '(js/String.)))))
87+
88+
(deftest test-defrecord
89+
(let [node (no-warn (analyze ns-env '(defrecord A [])))
90+
body (:body node)]
91+
(is (= :defrecord (->> body :statements first :ret :op)))
92+
(is (s/valid? ::a/node node))))
93+
94+
; TODO: #js
95+
;(deftest test-js-object
96+
; )
8797

8898
(comment
8999

0 commit comments

Comments
 (0)