Skip to content

Commit 7a55674

Browse files
authored
chore(setup): add dependency to crashtracker_exe (#13724)
We add the dependency on the crashtracker executable to the crashtracker CMake extension to allow incremental builds to use it to decide when to recompile the extension. This also ensures that the executable is cached in our CI jobs and resored as appropriate. ## Checklist - [ ] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
1 parent 027f277 commit 7a55674

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

setup.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -808,7 +808,10 @@ def get_exts_for(name):
808808
"ddtrace.internal.datadog.profiling.crashtracker._crashtracker",
809809
source_dir=CRASHTRACKER_DIR,
810810
optional=False,
811-
dependencies=[CRASHTRACKER_DIR.parent / "libdd_wrapper"],
811+
dependencies=[
812+
CRASHTRACKER_DIR / "crashtracker_exe",
813+
CRASHTRACKER_DIR.parent / "libdd_wrapper",
814+
],
812815
)
813816
)
814817

0 commit comments

Comments
 (0)