parse Bybit specific CrossSequence in Trades stream (#737)

Author: vslee

src/ExchangeSharp/API/Exchanges/Bybit/ExchangeBybitAPI.cs

@@ -274,12 +274,12 @@ protected override async Task<IWebSocket> OnGetTradesWebSocketAsync(Func<KeyValu
 			{
 				foreach (var dataRow in token)
 				{
-					ExchangeTrade trade = dataRow.ParseTrade(
+					var trade = dataRow.ParseTradeBybit(
 						amountKey: "size", 
 						priceKey: "price",
 						typeKey: "side", 
-						timestampKey: "timestamp",
-						timestampType: TimestampType.Iso8601UTC, 
+						timestampKey: "trade_time_ms",
+						timestampType: TimestampType.UnixMilliseconds, 
 						idKey: "trade_id");
 					await callback(new KeyValuePair<string, ExchangeTrade>(dataRow["symbol"].ToStringInvariant(), trade));
 				}

src/ExchangeSharp/API/Exchanges/Bybit/Models/BybitTrade.cs

@@ -0,0 +1,19 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace ExchangeSharp.Bybit
+{
+	public class BybitTrade : ExchangeTrade
+	{
+		/// <summary>
+		/// Cross sequence (internal value)
+		/// </summary>
+		public long CrossSequence { get; set; }
+		public override string ToString()
+		{
+			return string.Format("{0},{1}", base.ToString(), CrossSequence);
+		}
+
+	}
+}

src/ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs

@@ -24,6 +24,7 @@ The above copyright notice and this permission notice shall be included in all c
 using Newtonsoft.Json.Linq;
 using ExchangeSharp.NDAX;
 using ExchangeSharp.API.Exchanges.FTX.Models;
+using ExchangeSharp.Bybit;
 
 namespace ExchangeSharp
 {
@@ -540,6 +541,15 @@ internal static ExchangeTrade ParseTradeBinance(this JToken token, object amount
 			return trade;
 		}
 
+		internal static ExchangeTrade ParseTradeBybit(this JToken token, object amountKey, object priceKey, object typeKey,
+			object timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = "buy")
+		{
+			var trade = ParseTradeComponents<BybitTrade>(token, amountKey, priceKey, typeKey,
+				timestampKey, timestampType, idKey, typeKeyIsBuyValue);
+			trade.CrossSequence = token["cross_seq"].ConvertInvariant<long>();
+			return trade;
+		}
+
 		internal static ExchangeTrade ParseTradeBinanceDEX(this JToken token, object amountKey, object priceKey, object typeKey,
 			object timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = "buy")
 		{