Skip to content

Commit e97934d

Browse files
authored
core: remove unnecessary references to legacy gatherer (#15236)
1 parent c2ab38a commit e97934d

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

core/gather/base-gatherer.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ import * as LH from '../../types/lh.js';
99
/* eslint-disable no-unused-vars */
1010

1111
/**
12-
* Base class for all gatherers supporting both Fraggle Rock and the legacy flow.
13-
* Most extending classes should implement the Fraggle Rock API and let this class handle translation.
14-
* See core/gather/gatherers/gatherer.js for legacy method explanations.
12+
* Base class for all gatherers.
1513
*
1614
* @implements {LH.Gatherer.GathererInstance}
1715
* @implements {LH.Gatherer.FRGathererInstance}

core/test/config/config-helpers-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import {
2121
mergeConfigFragmentArrayByKey,
2222
} from '../../config/config-helpers.js';
2323
import {Runner} from '../../runner.js';
24-
import {Gatherer} from '../../gather/gatherers/gatherer.js';
24+
import Gatherer from '../../gather/base-gatherer.js';
2525
import ImageElementsGatherer from '../../gather/gatherers/image-elements.js';
2626
import UserTimingsAudit from '../../audits/user-timings.js';
2727
import {LH_ROOT} from '../../../root.js';

core/test/fixtures/valid-custom-gatherer.cjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
55
*/
66

7-
module.exports = import('../../gather/gatherers/gatherer.js').then(({Gatherer}) => {
7+
module.exports = import('../../gather/base-gatherer.js').then(({default: Gatherer}) => {
88
return class CustomGatherer extends Gatherer {};
99
});

core/test/fixtures/valid-custom-gatherer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
55
*/
66

7-
import {Gatherer} from '../../gather/gatherers/gatherer.js';
7+
import Gatherer from '../../gather/base-gatherer.js';
88

99
class CustomGatherer extends Gatherer {}
1010

0 commit comments

Comments
 (0)