Skip to content

Commit 3ba54bc

Browse files
committed
refactor: await-in-loop vuejs#1
1 parent f077f71 commit 3ba54bc

File tree

1 file changed

+20
-6
lines changed

1 file changed

+20
-6
lines changed

packages/@vuepress/core/lib/node/plugin-api/override/ClientDynamicModulesOption.js

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,31 @@ const AsyncOption = require('../abstract/AsyncOption')
1313
module.exports = class ClientDynamicModulesOption extends AsyncOption {
1414
async apply (ctx) {
1515
await super.asyncApply()
16+
// DR-ASYNC REFACTOR AWAIT-IN-LOOP
17+
// console.log("*** EXECUTING @vuepress/core/lib/node/plugin-api/override/ClientDynamicModulesOption.js:17:27");
18+
// for (const { value, name: pluginName } of this.appliedItems) {
19+
// const { name, content, dirname = 'dynamic' } = value
20+
// await ctx.writeTemp(
21+
// `${dirname}/${name}`,
22+
// `
23+
// /**
24+
// * Generated by "${pluginName}"
25+
// */
26+
// ${content}\n\n
27+
// `.trim())
28+
// }
1629

17-
for (const { value, name: pluginName } of this.appliedItems) {
30+
await Promise.all(this.appliedItems.map(({ value, name: pluginName }) => {
1831
const { name, content, dirname = 'dynamic' } = value
19-
await ctx.writeTemp(
32+
ctx.writeTemp(
2033
`${dirname}/${name}`,
2134
`
2235
/**
23-
* Generated by "${pluginName}"
24-
*/
36+
* Generated by "${pluginName}"
37+
*/
2538
${content}\n\n
26-
`.trim())
27-
}
39+
`.trim())
40+
})
41+
)
2842
}
2943
}

0 commit comments

Comments
 (0)