Skip to content

Commit 8b4b818

Browse files
committed
[java] Using Selenium Manager for Java tests
1 parent b1300a6 commit 8b4b818

File tree

2 files changed

+9
-15
lines changed

2 files changed

+9
-15
lines changed

common/BUILD.bazel

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ alias(
5555
config_setting(
5656
name = "use_local_chromedriver",
5757
flag_values = {
58-
"@local_drivers//:use_chromedriver": "true",
58+
"@local_drivers//:use_chromedriver": "false",
5959
":pin_browsers": "false",
6060
},
6161
)
@@ -68,7 +68,7 @@ alias(
6868
config_setting(
6969
name = "use_local_geckodriver",
7070
flag_values = {
71-
"@local_drivers//:use_geckodriver": "true",
71+
"@local_drivers//:use_geckodriver": "false",
7272
":pin_browsers": "false",
7373
},
7474
)
@@ -81,7 +81,7 @@ alias(
8181
config_setting(
8282
name = "use_local_msedgedriver",
8383
flag_values = {
84-
"@local_drivers//:use_msedgedriver": "true",
84+
"@local_drivers//:use_msedgedriver": "false",
8585
":pin_browsers": "false",
8686
},
8787
)

java/browsers.bzl

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@ chrome_jvm_flags = select({
77
"-Dwebdriver.chrome.driver=$(location @mac_chromedriver//:chromedriver)",
88
"-Dwebdriver.chrome.binary=$(location @mac_chrome//:Chromium.app)/Contents/MacOS/Chromium",
99
],
10-
"@selenium//common:use_local_chromedriver": [
11-
"-Dwebdriver.chrome.driver=$(location @selenium//common:chromedriver)",
12-
],
10+
"@selenium//common:use_local_chromedriver": [],
1311
"//conditions:default": [
14-
"-Dselenium.skiptest=true",
12+
"-Dselenium.skiptest=false",
1513
],
1614
}) + select({
1715
"@selenium//common:use_headless_browser": [
@@ -25,11 +23,9 @@ edge_jvm_flags = select({
2523
"-Dwebdriver.edge.driver=$(location @mac_edgedriver//:msedgedriver)",
2624
"-Dwebdriver.edge.binary=\"$(location @mac_edge//:Edge.app)/Contents/MacOS/Microsoft Edge\"",
2725
],
28-
"@selenium//common:use_local_msedgedriver": [
29-
"-Dwebdriver.edge.driver=$(location @selenium//common:msedgedriver)",
30-
],
26+
"@selenium//common:use_local_msedgedriver": [],
3127
"//conditions:default": [
32-
"-Dselenium.skiptest=true",
28+
"-Dselenium.skiptest=false",
3329
],
3430
}) + select({
3531
"@selenium//common:use_headless_browser": [
@@ -47,11 +43,9 @@ firefox_jvm_flags = select({
4743
"-Dwebdriver.gecko.driver=$(location @mac_geckodriver//:geckodriver)",
4844
"-Dwebdriver.firefox.bin=$(location @mac_firefox//:Firefox.app)/Contents/MacOS/firefox",
4945
],
50-
"@selenium//common:use_local_geckodriver": [
51-
"-Dwebdriver.gecko.driver=$(location @selenium//common:geckodriver)",
52-
],
46+
"@selenium//common:use_local_geckodriver": [],
5347
"//conditions:default": [
54-
"-Dselenium.skiptest=true",
48+
"-Dselenium.skiptest=false",
5549
],
5650
}) + select({
5751
"@selenium//common:use_headless_browser": [

0 commit comments

Comments
 (0)