Skip to content

Commit 3a54b2a

Browse files
ValentinHValentinH
authored
fix(typescript): change how we import React (#523)
* fix(typescript): change how we import React * update auto
1 parent e53635e commit 3a54b2a

File tree

3 files changed

+62
-63
lines changed

3 files changed

+62
-63
lines changed

‎package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@
5151
"tslib": "2.0.1"
5252
},
5353
"devDependencies": {
54-
"@auto-it/all-contributors": "^10.42.0",
55-
"@auto-it/first-time-contributor": "^10.42.0",
56-
"@auto-it/released": "^10.42.0",
54+
"@auto-it/all-contributors": "11.1.2",
55+
"@auto-it/first-time-contributor": "11.1.2",
56+
"@auto-it/released": "11.1.2",
5757
"@percy/cli": "^1.0.0-beta.71",
5858
"@percy/cypress": "^3.1.1",
5959
"@types/jest": "^29.4.0",
@@ -63,7 +63,7 @@
6363
"@typescript-eslint/eslint-plugin": "^5.51.0",
6464
"@typescript-eslint/parser": "^5.51.0",
6565
"all-contributors-cli": "^6.4.0",
66-
"auto": "^10.42.0",
66+
"auto": "11.1.2",
6767
"bili": "^5.0.5",
6868
"cypress": "^5.2.0",
6969
"eslint": "^8.34.0",

‎src/Cropper.tsx

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react'
1+
import * as React from 'react'
22
import normalizeWheel from 'normalize-wheel'
33
import { Area, MediaSize, Point, Size, VideoSrc } from './types'
44
import {
@@ -122,7 +122,7 @@ class Cropper extends React.Component<CropperProps, State> {
122122
state: State = {
123123
cropSize: null,
124124
hasWheelJustStarted: false,
125-
mediaObjectFit: undefined
125+
mediaObjectFit: undefined,
126126
}
127127

128128
componentDidMount() {
@@ -145,7 +145,7 @@ class Cropper extends React.Component<CropperProps, State> {
145145
this.containerRef.addEventListener('gesturestart', this.onGestureStart as EventListener)
146146
}
147147

148-
this.currentDoc.addEventListener('scroll', this.onScroll);
148+
this.currentDoc.addEventListener('scroll', this.onScroll)
149149

150150
if (!this.props.disableAutomaticStylesInjection) {
151151
this.styleRef = this.currentDoc.createElement('style')
@@ -170,7 +170,6 @@ class Cropper extends React.Component<CropperProps, State> {
170170
if (this.props.setVideoRef) {
171171
this.props.setVideoRef(this.videoRef)
172172
}
173-
174173
}
175174

176175
componentWillUnmount() {
@@ -221,9 +220,9 @@ class Cropper extends React.Component<CropperProps, State> {
221220
this.videoRef.current?.load()
222221
}
223222

224-
const objectFit = this.getObjectFit();
223+
const objectFit = this.getObjectFit()
225224
if (objectFit !== this.state.mediaObjectFit) {
226-
this.setState({mediaObjectFit: objectFit}, this.computeSizes)
225+
this.setState({ mediaObjectFit: objectFit }, this.computeSizes)
227226
}
228227
}
229228

@@ -253,7 +252,7 @@ class Cropper extends React.Component<CropperProps, State> {
253252
this.currentDoc.removeEventListener('touchend', this.onDragStopped)
254253
this.currentDoc.removeEventListener('gesturemove', this.onGestureMove as EventListener)
255254
this.currentDoc.removeEventListener('gestureend', this.onGestureEnd as EventListener)
256-
this.currentDoc.removeEventListener('scroll', this.onScroll);
255+
this.currentDoc.removeEventListener('scroll', this.onScroll)
257256
}
258257

259258
clearScrollEvent = () => {
@@ -472,7 +471,7 @@ class Cropper extends React.Component<CropperProps, State> {
472471

473472
this.currentDoc.addEventListener('touchmove', this.onTouchMove, { passive: false }) // iOS 11 now defaults to passive: true
474473
this.currentDoc.addEventListener('touchend', this.onDragStopped)
475-
474+
476475
this.saveContainerPosition()
477476

478477
if (e.touches.length === 2) {
@@ -743,7 +742,7 @@ class Cropper extends React.Component<CropperProps, State> {
743742
classes: { containerClassName, cropAreaClassName, mediaClassName },
744743
} = this.props
745744

746-
const objectFit = this.state.mediaObjectFit;
745+
const objectFit = this.state.mediaObjectFit
747746

748747
return (
749748
<div

‎yarn.lock

Lines changed: 50 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
"@jridgewell/gen-mapping" "^0.1.0"
1111
"@jridgewell/trace-mapping" "^0.3.9"
1212

13-
"@auto-it/all-contributors@^10.42.0":
14-
version "10.42.0"
15-
resolved "https://registry.yarnpkg.com/@auto-it/all-contributors/-/all-contributors-10.42.0.tgz#8c40b0a64fd066522987d97b2a7643152ef86083"
16-
integrity sha512-NJnnps/WHcppRdsumsUUO0mBeJroCdqs7AQhhpC330ujpusakS5uXhQthh5bqgDcqa2LjdMgWdVqrZHCSbtF+w==
13+
"@auto-it/all-contributors@11.1.2":
14+
version "11.1.2"
15+
resolved "https://registry.yarnpkg.com/@auto-it/all-contributors/-/all-contributors-11.1.2.tgz#18004d6867a6780abb6e245aa42cca7bcc4ba8ec"
16+
integrity sha512-YMCtQaEEUU7YSTPtENoxnY21egocRr4wDyUrnroP1TWm19jO/c1CjGFCIv3qQtNQs1WJ608JfJnuE6h4BuXToQ==
1717
dependencies:
18-
"@auto-it/bot-list" "10.42.0"
19-
"@auto-it/core" "10.42.0"
18+
"@auto-it/bot-list" "11.1.2"
19+
"@auto-it/core" "11.1.2"
2020
"@octokit/rest" "^18.12.0"
2121
all-contributors-cli "6.19.0"
2222
anymatch "^3.1.1"
@@ -28,17 +28,17 @@
2828
io-ts "^2.1.2"
2929
tslib "2.1.0"
3030

31-
"@auto-it/bot-list@10.42.0":
32-
version "10.42.0"
33-
resolved "https://registry.yarnpkg.com/@auto-it/bot-list/-/bot-list-10.42.0.tgz#d3947036bf475d9bfd437829d4350e6c23cdd98f"
34-
integrity sha512-MYGrTJsix5r2RaYbfS6uIDTJrrhDCAK1NxmI2aFqq5DqD3Zn2vhIzsOk3qpl29rxUs986opqCUaPIUxHjsIV0g==
31+
"@auto-it/bot-list@11.1.2":
32+
version "11.1.2"
33+
resolved "https://registry.yarnpkg.com/@auto-it/bot-list/-/bot-list-11.1.2.tgz#8b0bdfbb4dc9cc4f7f6d99087d3b23e49f0bdf2c"
34+
integrity sha512-3OxS04InYbMT67JH+zZ9STgPgWNyyE5gfm14z/aKJIKjpSRCmtM+nNimsNgEUvaZsN8MOPNU7QJC5ixOfxwsSA==
3535

36-
"@auto-it/core@10.42.0":
37-
version "10.42.0"
38-
resolved "https://registry.yarnpkg.com/@auto-it/core/-/core-10.42.0.tgz#3e2be4cea818c9824377898c4e7e455f8c3a20fb"
39-
integrity sha512-sxuqRjtoW51PVegCEK+1Jyd2yTbrqfZO97PUN8XhuzkFP65H5YaskS0+9qDJDDRGG0AH/Hk906xzG1bv6/rcgg==
36+
"@auto-it/core@11.1.2":
37+
version "11.1.2"
38+
resolved "https://registry.yarnpkg.com/@auto-it/core/-/core-11.1.2.tgz#a6c1e8b2b1dcb248277e2aed0acb23d50ef50fbf"
39+
integrity sha512-Hg1/aQo11MPDBNeB6HGVO/Sp/RsDAJU5XoSIbimwiX65/3Nz5jam3HbgNSwmjZspgnspdQ9XfUITC5xTxOnY6w==
4040
dependencies:
41-
"@auto-it/bot-list" "10.42.0"
41+
"@auto-it/bot-list" "11.1.2"
4242
"@endemolshinegroup/cosmiconfig-typescript-loader" "^3.0.2"
4343
"@octokit/core" "^3.5.1"
4444
"@octokit/plugin-enterprise-compatibility" "1.3.0"
@@ -79,25 +79,25 @@
7979
typescript-memoize "^1.0.0-alpha.3"
8080
url-join "^4.0.0"
8181

82-
"@auto-it/first-time-contributor@^10.42.0":
83-
version "10.42.0"
84-
resolved "https://registry.yarnpkg.com/@auto-it/first-time-contributor/-/first-time-contributor-10.42.0.tgz#641d2bd94b3c0d07baf198dbcff3be2282242a80"
85-
integrity sha512-/X0cCNe7l5FOfZZx3oRDtD4fhvnhoAHhiEcT+D1Q0v/b4acr3lS6vRAU3LURG/TBawbrV9KpWufbu/tNIqrIbw==
82+
"@auto-it/first-time-contributor@11.1.2":
83+
version "11.1.2"
84+
resolved "https://registry.yarnpkg.com/@auto-it/first-time-contributor/-/first-time-contributor-11.1.2.tgz#d40f2e5103d21beb6720eaa86318053214bb3d63"
85+
integrity sha512-66f90XhOcYxKOXnaGRMVhLt+P7oot3N2sGCzsAoXd18M3u2n3ERmOFruX2mmJ/yIzueAXHN+D/+pFiuA6ev7Ug==
8686
dependencies:
87-
"@auto-it/bot-list" "10.42.0"
88-
"@auto-it/core" "10.42.0"
87+
"@auto-it/bot-list" "11.1.2"
88+
"@auto-it/core" "11.1.2"
8989
array.prototype.flatmap "^1.2.2"
9090
endent "^2.1.0"
9191
tslib "2.1.0"
9292
url-join "^4.0.0"
9393

94-
"@auto-it/npm@10.42.0":
95-
version "10.42.0"
96-
resolved "https://registry.yarnpkg.com/@auto-it/npm/-/npm-10.42.0.tgz#1531cbcc913ee9bca74a1ae60a1b8d252069f22a"
97-
integrity sha512-53Pfs41hhjKKduq9GsTkYJdzM1CvAAiwuF7vj9Q4BtZA28qK/rFDxdISkWKXLDTIDO+ughQd9f2MpO+qBRbe/w==
94+
"@auto-it/npm@11.1.2":
95+
version "11.1.2"
96+
resolved "https://registry.yarnpkg.com/@auto-it/npm/-/npm-11.1.2.tgz#99647dbfa99e81ebb8961dda024d399c8994aa3b"
97+
integrity sha512-s0itO3ZgkQ+0G6eMuOlYw4C5tpBJ21egOYktcK2e2OfPLENiGnLU0PlX74u9m2+rNBiykNR/UJpzgwLCFPBD5g==
9898
dependencies:
99-
"@auto-it/core" "10.42.0"
100-
"@auto-it/package-json-utils" "10.42.0"
99+
"@auto-it/core" "11.1.2"
100+
"@auto-it/package-json-utils" "11.1.2"
101101
await-to-js "^3.0.0"
102102
endent "^2.1.0"
103103
env-ci "^5.0.1"
@@ -111,32 +111,32 @@
111111
url-join "^4.0.0"
112112
user-home "^2.0.0"
113113

114-
"@auto-it/package-json-utils@10.42.0":
115-
version "10.42.0"
116-
resolved "https://registry.yarnpkg.com/@auto-it/package-json-utils/-/package-json-utils-10.42.0.tgz#d8123ab4d3ad79ae7da494dbb4238a57fda09adc"
117-
integrity sha512-Kcnn1wTYJ9o0bweczaeIvgNyBERPyiG70SsGy7311acdnMr2b75WbhNOw4LM9RsD9CqA3HDzeWBQvIUvuJfJVA==
114+
"@auto-it/package-json-utils@11.1.2":
115+
version "11.1.2"
116+
resolved "https://registry.yarnpkg.com/@auto-it/package-json-utils/-/package-json-utils-11.1.2.tgz#e05aba2f8e242f626242e12a085a728be2977afd"
117+
integrity sha512-R9YE/7jEBZzWkC/hc6Ju77iRGg9VnqYfIdj7oGkQq8jvbfvLxTm8g/BheBOvvVJuaY/C272Orvcw+3Pu+xtc+Q==
118118
dependencies:
119119
parse-author "^2.0.0"
120120
parse-github-url "1.0.2"
121121

122-
"@auto-it/released@10.42.0", "@auto-it/released@^10.42.0":
123-
version "10.42.0"
124-
resolved "https://registry.yarnpkg.com/@auto-it/released/-/released-10.42.0.tgz#58087068536ad5c495e93b1427028bf5525bf0cd"
125-
integrity sha512-iBxXtLfaqXlcHKxl6z2Vi6TfW50qyPetSXvZHyrSw7p+hkQ+4fSIPiNR+bWE/51kD3UbpzIpt22k5xqdi8jzBg==
122+
"@auto-it/released@11.1.2":
123+
version "11.1.2"
124+
resolved "https://registry.yarnpkg.com/@auto-it/released/-/released-11.1.2.tgz#a66c3351306c556b0a2d140111b7bfb07681ac2a"
125+
integrity sha512-jhNznq+eNwzTitGwWeF6RQkR9yQRy6mKWFjZOK5jNnsiNaXYX1PJiJ/WCWMvXRromJOvcQQK8OoAzQN5s97+zw==
126126
dependencies:
127-
"@auto-it/bot-list" "10.42.0"
128-
"@auto-it/core" "10.42.0"
127+
"@auto-it/bot-list" "11.1.2"
128+
"@auto-it/core" "11.1.2"
129129
deepmerge "^4.0.0"
130130
fp-ts "^2.5.3"
131131
io-ts "^2.1.2"
132132
tslib "2.1.0"
133133

134-
"@auto-it/version-file@10.42.0":
135-
version "10.42.0"
136-
resolved "https://registry.yarnpkg.com/@auto-it/version-file/-/version-file-10.42.0.tgz#ba38b5794a619c41bc3e125b0a2b5c625d2afca0"
137-
integrity sha512-1kBs2XqgpvFK+b09DGbw29zb8XVTGKOB6cN4jVYivALXSC5x2FkHx1l6syWHozVaOQw5tVEqLD++C+bO6Pi0+w==
134+
"@auto-it/version-file@11.1.2":
135+
version "11.1.2"
136+
resolved "https://registry.yarnpkg.com/@auto-it/version-file/-/version-file-11.1.2.tgz#28175d39563c2a272a99f7c267d3cdd8318f3e08"
137+
integrity sha512-ZZnq1Svodd3SrNznYJqZ4SeMxxYoD14OFeH8yyGLFaDFwmIrDkoEOQWVbTSNU05rOQNJfi+OobSM89XV44MSCQ==
138138
dependencies:
139-
"@auto-it/core" "10.42.0"
139+
"@auto-it/core" "11.1.2"
140140
fp-ts "^2.5.3"
141141
io-ts "^2.1.2"
142142
semver "^7.0.0"
@@ -2858,15 +2858,15 @@ author-regex@^1.0.0:
28582858
resolved "https://registry.yarnpkg.com/author-regex/-/author-regex-1.0.0.tgz#d08885be6b9bbf9439fe087c76287245f0a81450"
28592859
integrity sha512-KbWgR8wOYRAPekEmMXrYYdc7BRyhn2Ftk7KWfMUnQ43hFdojWEFRxhhRUm3/OFEdPa1r0KAvTTg9YQK57xTe0g==
28602860

2861-
auto@^10.42.0:
2862-
version "10.42.0"
2863-
resolved "https://registry.yarnpkg.com/auto/-/auto-10.42.0.tgz#ff157dafe9366bba6e4f44b9c7451b0e890c4fb0"
2864-
integrity sha512-Yekf1zKXCMI8IuI/uTrHyeGjDUbsby5r9Z2IjAWr02zA6WpkZFz+pxsf+nuOdlg6OM1O7Yy+rFoOF+x0xRkAxA==
2861+
auto@11.1.2:
2862+
version "11.1.2"
2863+
resolved "https://registry.yarnpkg.com/auto/-/auto-11.1.2.tgz#21f6a3f348657369ca559fd2feafc3873bfaca4e"
2864+
integrity sha512-cE1Tt0dPPH1YhoOLoYlZscwFUl1xYOEgdICw5VLX9EUZZfWUpjWCBukKV+dYN5bJr353XOFr/GFR/kaL+j25sQ==
28652865
dependencies:
2866-
"@auto-it/core" "10.42.0"
2867-
"@auto-it/npm" "10.42.0"
2868-
"@auto-it/released" "10.42.0"
2869-
"@auto-it/version-file" "10.42.0"
2866+
"@auto-it/core" "11.1.2"
2867+
"@auto-it/npm" "11.1.2"
2868+
"@auto-it/released" "11.1.2"
2869+
"@auto-it/version-file" "11.1.2"
28702870
await-to-js "^3.0.0"
28712871
chalk "^4.0.0"
28722872
command-line-application "^0.10.1"

0 commit comments

Comments
 (0)