Skip to content

Commit e789acd

Browse files
ppkarwaszvy
andcommitted
Comment on jpms-multi-release
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
1 parent c249697 commit e789acd

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1026,6 +1026,13 @@ import org.apache.commons.codec.digest.*;
10261026
# Allow each project to override the `Multi-Release` header:
10271027
Multi-Release: $[bnd-multi-release]
10281028
1029+
# Skipping to set `-jpms-multi-release` to `bnd-multi-release`.
1030+
# This would generate descriptors in `META-INF/versions/<version>` directories needed for MRJs.
1031+
# Though we decided to skip it due to following reasons:
1032+
# 1. It is only needed by a handful of files in `-java9`-suffixed modules of `logging-log4j2`.
1033+
# Hence, it is effectively insignificant.
1034+
# 2. `dependency:unpack` and `bnd:bnd-process` executions must be aligned correctly.
1035+
# See this issue for details: https://github.com/apache/logging-parent/issues/93
10291036
# Adds certain `Implementation-*` and `Specification-*` entries to the generated `MANIFEST.MF`.
10301037
# Using these properties is known to be a bad practice: https://github.com/apache/logging-log4j2/issues/1923#issuecomment-1786818254
10311038
# Users should use `META-INF/maven/<groupId>/<artifactId>/pom.properties` instead.

0 commit comments

Comments
 (0)