Feat: Consolidate device caching by merging live and app live data fetching into a single function

Author: ruturaj-browserstack

src/lib/device-cache.ts

@@ -0,0 +1,58 @@
+import fs from "fs";
+import os from "os";
+import path from "path";
+
+const CACHE_DIR = path.join(os.homedir(), ".browserstack", "combined_cache");
+const CACHE_FILE = path.join(CACHE_DIR, "data.json");
+const TTL_MS = 24 * 60 * 60 * 1000; // 1 day
+
+const URLS = {
+  live: "https://www.browserstack.com/list-of-browsers-and-platforms/live.json",
+  app_live:
+    "https://www.browserstack.com/list-of-browsers-and-platforms/app_live.json",
+};
+
+/**
+ * Fetches and caches both BrowserStack datasets (live + app_live) with a shared TTL.
+ */
+export async function getBrowserStackData(
+  type: "live" | "app_live",
+): Promise<any> {
+  if (!fs.existsSync(CACHE_DIR)) {
+    fs.mkdirSync(CACHE_DIR, { recursive: true });
+  }
+
+  let cache: any = {};
+  let shouldRefresh = true;
+
+  if (fs.existsSync(CACHE_FILE)) {
+    const stats = fs.statSync(CACHE_FILE);
+    if (Date.now() - stats.mtimeMs < TTL_MS) {
+      cache = JSON.parse(fs.readFileSync(CACHE_FILE, "utf8"));
+      shouldRefresh = false;
+    }
+  }
+
+  if (shouldRefresh) {
+    const [liveRes, appLiveRes] = await Promise.all([
+      fetch(URLS.live),
+      fetch(URLS.app_live),
+    ]);
+
+    if (!liveRes.ok || !appLiveRes.ok) {
+      throw new Error(
+        `Failed to fetch data: live=${liveRes.statusText}, app_live=${appLiveRes.statusText}`,
+      );
+    }
+
+    const [liveData, appLiveData] = await Promise.all([
+      liveRes.json(),
+      appLiveRes.json(),
+    ]);
+
+    cache = { live: liveData, app_live: appLiveData };
+    fs.writeFileSync(CACHE_FILE, JSON.stringify(cache), "utf8");
+  }
+
+  return cache[type];
+}

src/tools/applive-utils/device-cache.ts

@@ -1,6 +1,6 @@
 import childProcess from "child_process";
 import logger from "../../logger";
-import { getAppLiveData } from "./device-cache";
+import { getBrowserStackData } from "../../lib/device-cache";
 import { fuzzySearchDevices } from "./fuzzy-search";
 import { sanitizeUrlParam } from "../../lib/utils";
 import { uploadApp } from "./upload-app";
@@ -30,7 +30,8 @@ export async function startSession(args: StartSessionArgs): Promise<string> {
   const { appPath, desiredPlatform, desiredPhone } = args;
   let { desiredPlatformVersion } = args;
 
-  const data = await getAppLiveData();
+  const data = await getBrowserStackData("app_live");
+
   const allDevices: DeviceEntry[] = data.mobile.flatMap((group: any) =>
     group.devices.map((dev: any) => ({ ...dev, os: group.os })),
   );

src/tools/applive-utils/start-session.ts

@@ -1,10 +1,10 @@
-import { getLiveData } from "./device-cache";
+import { getBrowserStackData } from "../../lib/device-cache";
 import { resolveVersion } from "./version-resolver";
 import { customFuzzySearch } from "../../lib/fuzzy";
 import { DesktopArgs, DesktopEntry } from "./types";
 
 export async function filterDesktop(args: DesktopArgs): Promise<DesktopEntry> {
-  const data = await getLiveData();
+  const data = await getBrowserStackData("live");
   const allEntries = getAllDesktopEntries(data);
 
   // Filter OS

src/tools/live-utils/desktop-filter.ts

@@ -1,4 +1,4 @@
-import { getLiveData } from "./device-cache";
+import { getBrowserStackData } from "../../lib/device-cache";
 import { resolveVersion } from "./version-resolver";
 import { customFuzzySearch } from "../../lib/fuzzy";
 import { MobileArgs, MobileEntry } from "./types";
@@ -80,7 +80,7 @@ function createVersionNote(
 }
 
 export async function filterMobile(args: MobileArgs): Promise<MobileEntry> {
-  const data = await getLiveData();
+  const data = await getBrowserStackData("live");
   const allEntries = getAllMobileEntries(data);
 
   const osCandidates = filterByOS(allEntries, args.os);