Skip to content

Commit 12dcbce

Browse files
committed
chore: add typecheck to ci
cann't use with lint-staged lint-staged/lint-staged#468 check all files try fixed microsoft/TypeScript#27379 microsoft/TypeScript#49817 as an alternative https://github.com/gustavopch/tsc-files
1 parent 18abe76 commit 12dcbce

File tree

7 files changed

+15
-16
lines changed

7 files changed

+15
-16
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ jobs:
4242

4343
- run: pnpm install
4444

45+
- name: Run typecheck
46+
run: npm run typecheck
47+
4548
- name: Run unit tests
4649
run: npm run test -- --package-name '*'
4750

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
"update": "ddc update",
1919
"test": "ddc test",
2020
"add": "ddc add",
21-
"release": "ddc release"
21+
"release": "ddc release",
22+
"typecheck": "tsc --noEmit --skipLibCheck"
2223
},
2324
"scripts-info": {
2425
"init": "首次安装",

packages/dom/src/once.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,12 @@ export const once = (
1010
) => {
1111
if (IS_SERVER) return () => {};
1212

13-
const off: AnyFunction;
1413
const handler$ = function (this: any, ...args: any[]) {
1514
handler && handler.apply(this, args);
1615
off();
1716
};
1817

19-
off = on(el, event, handler$, options);
18+
const off = on(el, event, handler$, options);
2019

2120
return off;
2221
};

packages/fp/src/pipeline/add.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ type Add = (arg1: number, arg2: number) => number;
44
export const add: Add = curry((arg1, arg2) => {
55
let r1: number;
66
let r2: number;
7-
const m: number;
8-
const c: number;
97
try {
108
r1 = arg1.toString().split('.')[1].length;
119
} catch (e) {
@@ -16,8 +14,8 @@ export const add: Add = curry((arg1, arg2) => {
1614
} catch (e) {
1715
r2 = 0;
1816
}
19-
c = Math.abs(r1 - r2);
20-
m = 10 ** Math.max(r1, r2);
17+
const c = Math.abs(r1 - r2);
18+
const m = 10 ** Math.max(r1, r2);
2119
if (c > 0) {
2220
const cm = 10 ** c;
2321
if (r1 > r2) {

packages/fp/src/pipeline/divide.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,14 @@ type Divide = (arg1: number, arg2: number) => number;
44
export const divide: Divide = curry((arg1: number, arg2: number) => {
55
let t1 = 0;
66
let t2 = 0;
7-
const r1: number;
8-
const r2: number;
97
try {
108
t1 = arg1.toString().split('.')[1].length;
119
} catch (e) { /* empty */ }
1210
try {
1311
t2 = arg2.toString().split('.')[1].length;
1412
} catch (e) { /* empty */ }
1513

16-
r1 = Number(arg1.toString().replace('.', ''));
17-
r2 = Number(arg2.toString().replace('.', ''));
14+
const r1 = Number(arg1.toString().replace('.', ''));
15+
const r2 = Number(arg2.toString().replace('.', ''));
1816
return (r1 / r2) * (10 ** (t2 - t1));
1917
});

packages/fp/src/pipeline/subtract.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ type Subtract = (arg1: number, arg2: number) => number;
44
export const subtract: Subtract = curry((arg1, arg2) => {
55
let r1: number;
66
let r2: number;
7-
const m: number;
8-
const n: number;
97

108
try {
119
r1 = arg1.toString().split('.')[1].length;
@@ -17,7 +15,7 @@ export const subtract: Subtract = curry((arg1, arg2) => {
1715
} catch (e) {
1816
r2 = 0;
1917
}
20-
m = 10 ** Math.max(r1, r2);
21-
n = (r1 >= r2) ? r1 : r2;
18+
const m = 10 ** Math.max(r1, r2);
19+
const n = (r1 >= r2) ? r1 : r2;
2220
return +((arg1 * m - arg2 * m) / m).toFixed(n);
2321
});

packages/wheel/src/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,10 @@ export class Wheel {
313313
* @param options ~
314314
*/
315315
private emitScroll(e: Event, options: ScrollOptions): void {
316-
const { x: pixelX, y: pixelY, angle } = options;
316+
const { x, y, angle } = options;
317317

318+
let pixelX = x;
319+
let pixelY = y;
318320
if (!this.options.freedom) {
319321
angle < 30 && (pixelY = 0);
320322
angle > 60 && (pixelX = 0);

0 commit comments

Comments
 (0)