Fix float parse with extra chars

Author: davegaeddert

internal/github/main.go

@@ -8,6 +8,7 @@ import (
 	"net/http"
 	"os"
 
+	"github.com/dropseed/commitstat/internal/parse"
 	commitstatStatus "github.com/dropseed/commitstat/internal/status"
 )
 
@@ -42,7 +43,7 @@ func FetchRefStat(repo, ref, statName, apiToken string) (string, error) {
 
 	for _, status := range refStatus.Statuses {
 		if status.Context == context {
-			return commitstatStatus.ParseStatFromDescription(status.Description), nil
+			return parse.ParseStatFromDescription(status.Description), nil
 		}
 	}
 

internal/parse/main.go

@@ -4,6 +4,7 @@ import (
 	"errors"
 	"fmt"
 	"regexp"
+	"strconv"
 )
 
 func ParseStatFromString(s, regex string) (string, error) {
@@ -18,3 +19,23 @@ func ParseStatFromString(s, regex string) (string, error) {
 
 	return matches[1], nil
 }
+
+func ParseStatNumber(s string) (float64, error) {
+	re := regexp.MustCompile(`^[\d\.]+`)
+	matches := re.FindAllString(s, 1)
+	if num, err := strconv.ParseFloat(matches[0], 32); err == nil {
+		return num, nil
+	} else {
+		return 0.0, err
+	}
+}
+
+// ParseStatFromDescription expects the stat to be the first part of the string and could have a %, mb, or something directly after it
+func ParseStatFromDescription(text string) string {
+	re := regexp.MustCompile(`^[\d\.]+\S*`)
+	matches := re.FindAllString(text, 1)
+	if len(matches) == 1 {
+		return matches[0]
+	}
+	return ""
+}

internal/status/main.go

@@ -3,8 +3,8 @@ package status
 import (
 	"errors"
 	"fmt"
-	"regexp"
-	"strconv"
+
+	"github.com/dropseed/commitstat/internal/parse"
 )
 
 type state string
@@ -44,12 +44,12 @@ func compareStats(stat, comparisonStat, goal string) (state, string, error) {
 		return stateSuccess, fmt.Sprintf("%s is the first value seen", stat), nil
 	}
 
-	statNum, err := parseStatNumber(stat)
+	statNum, err := parse.ParseStatNumber(stat)
 	if err != nil {
 		return stateError, "unable to parse stat", err
 	}
 
-	prevStatNum, err := parseStatNumber(comparisonStat)
+	prevStatNum, err := parse.ParseStatNumber(comparisonStat)
 	if err != nil {
 		return stateError, "unable to parse comparison stat", err
 	}
@@ -74,21 +74,3 @@ func compareStats(stat, comparisonStat, goal string) (state, string, error) {
 		return stateError, "unknown goal", errors.New("unknown goal")
 	}
 }
-
-func parseStatNumber(s string) (float64, error) {
-	if num, err := strconv.ParseFloat(s, 32); err == nil {
-		return num, nil
-	} else {
-		return 0.0, err
-	}
-}
-
-// ParseStatFromDescription expects the stat to be the first part of the string and could have a %, mb, or something directly after it
-func ParseStatFromDescription(text string) string {
-	re := regexp.MustCompile("^[\\d\\.]+\\S*")
-	matches := re.FindAllString(text, 1)
-	if len(matches) == 1 {
-		return matches[0]
-	}
-	return ""
-}