Skip to content

Commit dbd7643

Browse files
committed
Avoid duplicate work when BlockCode changes
https://phabricator.endlessm.com/T35541
1 parent d4103f1 commit dbd7643

File tree

1 file changed

+17
-10
lines changed

1 file changed

+17
-10
lines changed

addons/block_code/block_code_plugin.gd

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ func _on_editor_inspector_edited_object_changed():
136136

137137

138138
func select_block_code_node(block_code: BlockCode):
139+
if block_code == _selected_block_code:
140+
return
141+
139142
if not is_block_code_editable(block_code):
140143
block_code = null
141144

@@ -153,9 +156,23 @@ func select_block_code_node(block_code: BlockCode):
153156
_selected_block_code.property_list_changed.connect(_on_selected_block_code_changed)
154157
editor_inspector.property_edited.connect(_on_editor_inspector_property_edited)
155158

159+
_refresh_block_code_node()
160+
161+
162+
func _refresh_block_code_node():
156163
main_panel.switch_block_code_node(_selected_block_code)
157164

158165

166+
func _on_selected_block_code_changed():
167+
if _selected_block_code:
168+
_refresh_block_code_node()
169+
170+
171+
func _on_editor_inspector_property_edited(property: String):
172+
if _selected_block_code:
173+
_refresh_block_code_node()
174+
175+
159176
static func is_block_code_editable(block_code: BlockCode) -> bool:
160177
if not block_code:
161178
return false
@@ -183,16 +200,6 @@ static func list_block_code_nodes_for_node(node: Node, recursive: bool = false)
183200
return result
184201

185202

186-
func _on_selected_block_code_changed():
187-
if _selected_block_code:
188-
_on_editor_inspector_edited_object_changed()
189-
190-
191-
func _on_editor_inspector_property_edited(property: String):
192-
if _selected_block_code:
193-
_on_editor_inspector_edited_object_changed()
194-
195-
196203
func _get_plugin_name():
197204
return "Block Code"
198205

0 commit comments

Comments
 (0)