Fix: Fixed crash when trying to create bitmap from null IconData in SidebarPinnedModel.cs (#12333)

hecksmosis · web-flow · commit bea5c279771e · 2023-05-11T12:40:29.000-04:00
diff --git a/src/Files.App/Data/Models/SidebarPinnedModel.cs b/src/Files.App/Data/Models/SidebarPinnedModel.cs
@@ -107,7 +107,9 @@ public async Task<LocationItem> CreateLocationItemFromPathAsync(string path)
 				{
 					var iconData = await FileThumbnailHelper.LoadIconFromStorageItemAsync(res.Result, 96u, ThumbnailMode.ListView);
 					locationItem.IconData = iconData;
-					locationItem.Icon = await App.Window.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync());
+
+					if (locationItem.IconData is not null)
+						locationItem.Icon = await App.Window.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync());
 				}
 
 				if (locationItem.IconData is null)

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,9 @@ public async Task<LocationItem> CreateLocationItemFromPathAsync(string path)`
`107`	`107`	`{`
`108`	`108`	`var iconData = await FileThumbnailHelper.LoadIconFromStorageItemAsync(res.Result, 96u, ThumbnailMode.ListView);`
`109`	`109`	`locationItem.IconData = iconData;`
`110`		`- locationItem.Icon = await App.Window.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync());`
	`110`	`+`
	`111`	`+ if (locationItem.IconData is not null)`
	`112`	`+ locationItem.Icon = await App.Window.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync());`
`111`	`113`	`}`
`112`	`114`
`113`	`115`	`if (locationItem.IconData is null)`