Merge branch 'main' into SaveSessionWhenException

Author: yaira2

README.md

@@ -27,7 +27,7 @@ Files also offers advanced features such as file tagging for easy organization,
     - MSVC v143 - VS 2022 C++ x64/x86 or ARM64 build tools (latest)
     - C++ ATL for latest v143 build tools (x86 & x64 or ARM64)
     - Git for Windows
-- [Windows App SDK 1.2](https://learn.microsoft.com/windows/apps/windows-app-sdk/downloads#current-releases)
+- [Windows App SDK 1.3](https://learn.microsoft.com/windows/apps/windows-app-sdk/downloads#current-releases)
 
 ### 2. Clone the repository
 

specs/RichCommand/CommandList.md

@@ -10,7 +10,7 @@
          xmlns:uap4="http://schemas.microsoft.com/appx/manifest/uap/windows10/4"
          xmlns:uap5="http://schemas.microsoft.com/appx/manifest/uap/windows10/5"
          IgnorableNamespaces="uap uap5 mp rescap desktop6 desktop4 desktop">
-    <Identity Name="FilesDev" Publisher="CN=Files" Version="2.4.61.0" />
+    <Identity Name="FilesDev" Publisher="CN=Files" Version="2.4.62.0" />
     <Properties>
         <DisplayName>Files - Dev</DisplayName>
         <PublisherDisplayName>Yair A</PublisherDisplayName>

src/Files.App (Package)/Package.appxmanifest

@@ -0,0 +1,22 @@
+using CommunityToolkit.Mvvm.ComponentModel;
+using Files.App.Helpers;
+using System.ComponentModel;
+
+namespace Files.App.Actions
+{
+	internal abstract class BaseUIAction : ObservableObject
+	{
+		public virtual bool IsExecutable => UIHelpers.CanShowDialog;
+
+		public BaseUIAction()
+		{
+			UIHelpers.PropertyChanged += UIHelpers_PropertyChanged;
+		}
+
+		private void UIHelpers_PropertyChanged(object? sender, PropertyChangedEventArgs e)
+		{
+			if (e.PropertyName is nameof(UIHelpers.CanShowDialog))
+				OnPropertyChanged(nameof(IsExecutable));
+		}
+	}
+}

src/Files.App/Actions/BaseUIAction.cs

@@ -1,25 +1,27 @@
-using CommunityToolkit.Mvvm.ComponentModel;
-using CommunityToolkit.Mvvm.DependencyInjection;
+using CommunityToolkit.Mvvm.DependencyInjection;
 using Files.App.Contexts;
 using Files.App.Dialogs;
 using Files.App.Extensions;
 using Files.App.Filesystem.Archive;
 using Files.App.Helpers;
+using Microsoft.UI.Xaml.Controls;
 using System.ComponentModel;
 using System.Threading.Tasks;
 
 namespace Files.App.Actions
 {
-	internal class CompressIntoArchiveAction : ObservableObject, IAction
+	internal class CompressIntoArchiveAction : BaseUIAction, IAction
 	{
 		private readonly IContentPageContext context = Ioc.Default.GetRequiredService<IContentPageContext>();
 
 		public string Label => "CreateArchive".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "CompressIntoArchiveDescription".GetLocalizedResource();
 
-		public bool IsExecutable => IsContextPageTypeAdaptedToCommand()
-									&& ArchiveHelpers.CanCompress(context.SelectedItems);
+		public override bool IsExecutable => 
+			IsContextPageTypeAdaptedToCommand() &&
+			ArchiveHelpers.CanCompress(context.SelectedItems) &&
+			UIHelpers.CanShowDialog;
 
 		public CompressIntoArchiveAction()
 		{
@@ -34,9 +36,9 @@ public async Task ExecuteAsync()
 			{
 				FileName = fileName,
 			};
-			await dialog.ShowAsync();
+			var result = await dialog.TryShowAsync();
 
-			if (!dialog.CanCreate)
+			if (!dialog.CanCreate || result != ContentDialogResult.Primary)
 				return;
 
 			IArchiveCreator creator = new ArchiveCreator

src/Files.App/Actions/Content/Archives/CompressIntoArchiveAction.cs

@@ -15,7 +15,7 @@ internal class CompressIntoSevenZipAction : ObservableObject, IAction
 
 		public string Label => string.Format("CreateNamedArchive".GetLocalizedResource(), $"{ArchiveHelpers.DetermineArchiveNameFromSelection(context.SelectedItems)}.7z");
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "CompressIntoSevenZipDescription".GetLocalizedResource();
 
 		public bool IsExecutable => IsContextPageTypeAdaptedToCommand()
 									&& ArchiveHelpers.CanCompress(context.SelectedItems);

src/Files.App/Actions/Content/Archives/CompressIntoSevenZipAction.cs

@@ -15,7 +15,7 @@ internal class CompressIntoZipAction : ObservableObject, IAction
 
 		public string Label => string.Format("CreateNamedArchive".GetLocalizedResource(), $"{ArchiveHelpers.DetermineArchiveNameFromSelection(context.SelectedItems)}.zip");
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "CompressIntoZipDescription".GetLocalizedResource();
 
 		public bool IsExecutable => IsContextPageTypeAdaptedToCommand()
 									&& ArchiveHelpers.CanCompress(context.SelectedItems);

src/Files.App/Actions/Content/Archives/CompressIntoZipAction.cs

@@ -1,5 +1,4 @@
-using CommunityToolkit.Mvvm.ComponentModel;
-using CommunityToolkit.Mvvm.DependencyInjection;
+using CommunityToolkit.Mvvm.DependencyInjection;
 using Files.App.Commands;
 using Files.App.Contexts;
 using Files.App.Extensions;
@@ -9,18 +8,20 @@
 
 namespace Files.App.Actions
 {
-	internal class DecompressArchive : ObservableObject, IAction
+	internal class DecompressArchive : BaseUIAction, IAction
 	{
 		private readonly IContentPageContext context = Ioc.Default.GetRequiredService<IContentPageContext>();
 
 		public string Label => "ExtractFiles".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "DecompressArchiveDescription".GetLocalizedResource();
 
 		public HotKey HotKey { get; } = new(Keys.E, KeyModifiers.Ctrl);
 
-		public bool IsExecutable => IsContextPageTypeAdaptedToCommand()
-										&& ArchiveHelpers.CanDecompress(context.SelectedItems);
+		public override bool IsExecutable => 
+			IsContextPageTypeAdaptedToCommand() &&
+			ArchiveHelpers.CanDecompress(context.SelectedItems) &&
+			UIHelpers.CanShowDialog;
 
 		public DecompressArchive()
 		{

src/Files.App/Actions/Content/Archives/DecompressArchive.cs

@@ -1,5 +1,4 @@
-using CommunityToolkit.Mvvm.ComponentModel;
-using CommunityToolkit.Mvvm.DependencyInjection;
+using CommunityToolkit.Mvvm.DependencyInjection;
 using Files.App.Contexts;
 using Files.App.Extensions;
 using Files.App.Helpers;
@@ -8,16 +7,18 @@
 
 namespace Files.App.Actions
 {
-	internal class DecompressArchiveHere : ObservableObject, IAction
+	internal class DecompressArchiveHere : BaseUIAction, IAction
 	{
 		private readonly IContentPageContext context = Ioc.Default.GetRequiredService<IContentPageContext>();
 
 		public string Label => "ExtractHere".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "DecompressArchiveHereDescription".GetLocalizedResource();
 
-		public bool IsExecutable => IsContextPageTypeAdaptedToCommand()
-									&& ArchiveHelpers.CanDecompress(context.SelectedItems);
+		public override bool IsExecutable =>
+			IsContextPageTypeAdaptedToCommand() &&
+			ArchiveHelpers.CanDecompress(context.SelectedItems) &&
+			UIHelpers.CanShowDialog;
 
 		public DecompressArchiveHere()
 		{

src/Files.App/Actions/Content/Archives/DecompressArchiveHere.cs

@@ -1,5 +1,4 @@
-using CommunityToolkit.Mvvm.ComponentModel;
-using CommunityToolkit.Mvvm.DependencyInjection;
+using CommunityToolkit.Mvvm.DependencyInjection;
 using Files.App.Contexts;
 using Files.App.Extensions;
 using Files.App.Helpers;
@@ -10,16 +9,18 @@
 
 namespace Files.App.Actions
 {
-	internal class DecompressArchiveToChildFolderAction : ObservableObject, IAction
+	internal class DecompressArchiveToChildFolderAction : BaseUIAction, IAction
 	{
 		private readonly IContentPageContext context = Ioc.Default.GetRequiredService<IContentPageContext>();
 
 		public string Label => ComputeLabel();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "DecompressArchiveToChildFolderDescription".GetLocalizedResource();
 
-		public bool IsExecutable => IsContextPageTypeAdaptedToCommand()
-									&& ArchiveHelpers.CanDecompress(context.SelectedItems);
+		public override bool IsExecutable =>
+			IsContextPageTypeAdaptedToCommand() &&
+			ArchiveHelpers.CanDecompress(context.SelectedItems) &&
+			UIHelpers.CanShowDialog;
 
 		public DecompressArchiveToChildFolderAction()
 		{

src/Files.App/Actions/Content/Archives/DecompressArchiveToChildFolderAction.cs

@@ -10,7 +10,7 @@ internal class SetAsLockscreenBackgroundAction : BaseSetAsAction
 	{
 		public override string Label { get; } = "SetAsLockscreen".GetLocalizedResource();
 
-		public override string Description => "TODO: Need to be described.";
+		public override string Description => "SetAsLockscreenBackgroundDescription".GetLocalizedResource();
 
 		public override RichGlyph Glyph { get; } = new("\uEE3F");
 

src/Files.App/Actions/Content/Background/SetAsLockscreenBackgroundAction.cs

@@ -10,7 +10,7 @@ internal class SetAsSlideshowBackgroundAction : BaseSetAsAction
 	{
 		public override string Label { get; } = "SetAsSlideshow".GetLocalizedResource();
 
-		public override string Description => "TODO: Need to be described.";
+		public override string Description => "SetAsSlideshowBackgroundDescription".GetLocalizedResource();
 
 		public override RichGlyph Glyph { get; } = new("\uE91B");
 

src/Files.App/Actions/Content/Background/SetAsSlideshowBackgroundAction.cs

@@ -10,7 +10,7 @@ internal class SetAsWallpaperBackgroundAction : BaseSetAsAction
 	{
 		public override string Label { get; } = "SetAsBackground".GetLocalizedResource();
 
-		public override string Description => "TODO: Need to be described.";
+		public override string Description => "SetAsWallpaperBackgroundDescription".GetLocalizedResource();
 
 		public override RichGlyph Glyph { get; } = new("\uE91B");
 

src/Files.App/Actions/Content/Background/SetAsWallpaperBackgroundAction.cs

@@ -8,7 +8,7 @@ internal class RotateLeftAction : BaseRotateAction
 	{
 		public override string Label { get; } = "RotateLeft".GetLocalizedResource();
 
-		public override string Description => "TODO: Need to be described.";
+		public override string Description => "RotateLeftDescription".GetLocalizedResource();
 
 		public override RichGlyph Glyph { get; } = new RichGlyph(opacityStyle: "ColorIconRotateLeft");
 

src/Files.App/Actions/Content/ImageManipulation/RotateLeftAction.cs

@@ -8,7 +8,7 @@ internal class RotateRightAction : BaseRotateAction
 	{
 		public override string Label { get; } = "RotateRight".GetLocalizedResource();
 
-		public override string Description => "TODO: Need to be described.";
+		public override string Description => "RotateRightDescription".GetLocalizedResource();
 
 		public override RichGlyph Glyph { get; } = new RichGlyph(opacityStyle: "ColorIconRotateRight");
 

src/Files.App/Actions/Content/ImageManipulation/RotateRightAction.cs

@@ -16,7 +16,7 @@ internal class InstallFontAction : ObservableObject, IAction
 
 		public string Label => "Install".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "InstallFontDescription".GetLocalizedResource();
 
 		public bool IsExecutable => context.SelectedItems.Any() &&
 			context.SelectedItems.All(x => FileExtensionHelpers.IsFontFile(x.FileExtension)) &&

src/Files.App/Actions/Content/Install/InstallFontAction.cs

@@ -16,7 +16,7 @@ internal class InstallInfDriverAction : ObservableObject, IAction
 
 		public string Label => "Install".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "InstallInfDriverDescription".GetLocalizedResource();
 
 		public RichGlyph Glyph { get; } = new("\uE9F5");
 

src/Files.App/Actions/Content/Install/InstallInfDriverAction.cs

@@ -20,7 +20,7 @@ internal class LaunchQuickLookAction : ObservableObject, IAction
 
 		public string Label => "LaunchQuickLook".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "LaunchQuickLookDescription".GetLocalizedResource();
 
 		public LaunchQuickLookAction()
 		{

src/Files.App/Actions/Content/QuickLook/LaunchQuickLookAction.cs

@@ -13,7 +13,7 @@ internal class RefreshItemsAction : ObservableObject, IAction
 		private readonly IContentPageContext context = Ioc.Default.GetRequiredService<IContentPageContext>();
 
 		public string Label { get; } = "Refresh".GetLocalizedResource();
-		public string Description { get; } = "TODO";
+		public string Description { get; } = "RefreshItemsDescription".GetLocalizedResource();
 
 		public RichGlyph Glyph { get; } = new("\uE72C");
 

src/Files.App/Actions/Content/RefreshItemsAction.cs

@@ -15,7 +15,7 @@ internal class RunAsAdminAction : ObservableObject, IAction
 		public bool IsExecutable => context.SelectedItem is not null &&
 			FileExtensionHelpers.IsExecutableFile(context.SelectedItem.FileExtension);
 		public string Label => "RunAsAdministrator".GetLocalizedResource();
-		public string Description => "TODO: Need to be described.";
+		public string Description => "RunAsAdminDescription".GetLocalizedResource();
 		public RichGlyph Glyph => new("\uE7EF");
 
 		public RunAsAdminAction()

src/Files.App/Actions/Content/Run/RunAsAdminAction.cs

@@ -15,7 +15,7 @@ internal class RunAsAnotherUserAction : ObservableObject, IAction
 		public bool IsExecutable => context.SelectedItem is not null &&
 			FileExtensionHelpers.IsExecutableFile(context.SelectedItem.FileExtension);
 		public string Label => "BaseLayoutContextFlyoutRunAsAnotherUser/Text".GetLocalizedResource();
-		public string Description => "TODO: Need to be described.";
+		public string Description => "RunAsAnotherUserDescription".GetLocalizedResource();
 		public RichGlyph Glyph => new("\uE7EE");
 
 		public RunAsAnotherUserAction()

src/Files.App/Actions/Content/Run/RunAsAnotherUserAction.cs

@@ -19,7 +19,7 @@ internal class RunWithPowershellAction : ObservableObject, IAction
 
 		public string Label => "RunWithPowerShell".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "RunWithPowershellDescription".GetLocalizedResource();
 
 		public RichGlyph Glyph => new("\uE756");
 

src/Files.App/Actions/Content/Run/RunWithPowershellAction.cs

@@ -12,7 +12,7 @@ internal class ClearSelectionAction : IAction
 
 		public string Label { get; } = "ClearSelection".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "ClearSelectionDescription".GetLocalizedResource();
 
 		public RichGlyph Glyph { get; } = new("\uE8E6");
 

src/Files.App/Actions/Content/Selection/ClearSelectionAction.cs

@@ -12,7 +12,7 @@ internal class InvertSelectionAction : IAction
 
 		public string Label { get; } = "InvertSelection".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "InvertSelectionDescription".GetLocalizedResource();
 
 		public RichGlyph Glyph { get; } = new("\uE746");
 

src/Files.App/Actions/Content/Selection/InvertSelectionAction.cs

@@ -12,7 +12,7 @@ internal class SelectAllAction : IAction
 
 		public string Label { get; } = "SelectAll".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "SelectAllDescription".GetLocalizedResource();
 
 		public RichGlyph Glyph { get; } = new("\uE8B3");
 

src/Files.App/Actions/Content/Selection/SelectAllAction.cs

@@ -9,7 +9,7 @@ namespace Files.App.Actions
 	internal class ToggleSelectAction : IAction
 	{
 		public string Label { get; } = "ToggleSelect".GetLocalizedResource();
-		public string Description => "TODO: Need to be described.";
+		public string Description => "ToggleSelectDescription".GetLocalizedResource();
 
 		public HotKey HotKey { get; } = new(Keys.Space, KeyModifiers.Ctrl);
 

src/Files.App/Actions/Content/Selection/ToggleSelectAction.cs

@@ -16,7 +16,7 @@ internal class ShareItemAction : ObservableObject, IAction
 
 		public string Label => "Share".GetLocalizedResource();
 
-		public string Description => "TODO: Need to be described.";
+		public string Description => "ShareItemDescription".GetLocalizedResource();
 
 		public RichGlyph Glyph { get; } = new RichGlyph(opacityStyle: "ColorIconShare");