From 93c955b6b21a5074c1a08ce3c90c173a9260c93a Mon Sep 17 00:00:00 2001
From: U+5BFA <onein528@outlook.com>
Date: Sun, 12 Mar 2023 01:30:46 +0900
Subject: [PATCH 1/9] Feature: First trial of introducing new style to props
 window

---
 .../Views/Properties/MainPropertiesPage.xaml  | 165 ++++++------------
 1 file changed, 54 insertions(+), 111 deletions(-)

diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
index e9d59d9f51a3..0bdce48928c0 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
@@ -17,7 +17,7 @@
 		<ResourceDictionary>
 			<ResourceDictionary.MergedDictionaries>
 				<ResourceDictionary Source="ms-appx:///ResourceDictionaries/PropertiesStyles.xaml" />
-				<ResourceDictionary Source="ms-appx:///ResourceDictionaries/NavigationViewStoreStyle.xaml" />
+				<ResourceDictionary Source="ms-appx:///ResourceDictionaries/NavigationViewItemButtonStyle.xaml" />
 			</ResourceDictionary.MergedDictionaries>
 
 			<toolkitconvers:BoolNegationConverter x:Key="BoolNegationConverter" />
@@ -33,49 +33,31 @@
 
 	<Grid>
 		<Grid.RowDefinitions>
-			<RowDefinition Height="36" />
+			<RowDefinition Height="44" />
 			<RowDefinition Height="*" />
 		</Grid.RowDefinitions>
-		<Grid.ColumnDefinitions>
-			<ColumnDefinition Width="Auto" />
-			<ColumnDefinition Width="*" />
-		</Grid.ColumnDefinitions>
 
 		<!--  Titlebar  -->
-		<Border
-			x:Name="TitlebarArea"
-			Grid.ColumnSpan="2"
-			Height="36"
-			Background="Transparent">
-			<StackPanel
-				Padding="12,0"
-				Orientation="Horizontal"
-				Spacing="8">
-
-				<Image
-					Width="20"
-					Height="20"
-					Source="ms-appx:///Assets/AppTiles/Dev/Square44x44Logo.png" />
+		<Border x:Name="TitlebarArea" Height="36">
 
-				<TextBlock
-					VerticalAlignment="Center"
-					Style="{StaticResource CaptionTextBlockStyle}"
-					Text="{helpers:ResourceString Name=Properties}" />
+			<TextBlock
+				Padding="12,0"
+				VerticalAlignment="Center"
+				Style="{StaticResource BodyStrongTextBlockStyle}"
+				Text="{helpers:ResourceString Name=Properties}" />
 
-			</StackPanel>
 		</Border>
 
 		<!--  Vertical NavigationView whose each items are squared  -->
 		<NavigationView
 			x:Name="MainPropertiesWindowNavigationView"
 			Grid.Row="1"
-			Width="80"
 			IsBackButtonVisible="Collapsed"
 			IsPaneToggleButtonVisible="False"
 			IsSettingsVisible="False"
 			IsTitleBarAutoPaddingEnabled="False"
 			MenuItemsSource="{x:Bind NavViewItems, Mode=TwoWay}"
-			OpenPaneLength="88"
+			OpenPaneLength="200"
 			PaneDisplayMode="Left"
 			SelectionChanged="MainPropertiesWindowNavigationView_SelectionChanged">
 
@@ -85,97 +67,58 @@
 						Height="64"
 						IsSelected="{x:Bind IsSelected, Mode=TwoWay}"
 						Tag="{x:Bind ItemType}">
+						<NavigationViewItem.Icon>
+							<PathIcon Data="{x:Bind OutlinePathIcon}" />
+						</NavigationViewItem.Icon>
 						<NavigationViewItem.Content>
-							<StackPanel Spacing="4">
-
-								<Grid x:Name="ItemPathIconGrid">
-									<!--  Outline Path Icon  -->
-									<Viewbox
-										Width="24"
-										Height="24"
-										Margin="0,0,4,0"
-										Visibility="{x:Bind IsSelected, Converter={StaticResource BoolToVisibilityInverseConverter}, Mode=OneWay}">
-										<PathIcon
-											x:Name="NavigationViewItemOutlinePathIcon"
-											HorizontalAlignment="Center"
-											Data="{x:Bind OutlinePathIcon}" />
-									</Viewbox>
-									<!--  Filled Path Icon  -->
-									<Viewbox
-										Width="24"
-										Height="24"
-										Margin="0,0,4,0"
-										Visibility="{x:Bind IsSelected, Converter={StaticResource BoolToVisibilityConverter}, Mode=OneWay}">
-										<PathIcon
-											x:Name="NavigationViewItemFilledPathIcon"
-											HorizontalAlignment="Center"
-											Data="{x:Bind FilledPathIcon}"
-											Foreground="{ThemeResource AccentFillColorDefaultBrush}" />
-									</Viewbox>
-								</Grid>
-
-								<!--  Label  -->
-								<TextBlock
-									x:Name="ItemNameLabelTextBlock"
-									Grid.Row="1"
-									HorizontalAlignment="Center"
-									x:Load="{x:Bind IsSelected, Converter={StaticResource BoolNegationConverter}, Mode=OneWay}"
-									FontSize="10"
-									Style="{StaticResource CaptionTextBlockStyle}"
-									Text="{x:Bind Name}" />
-
-							</StackPanel>
+							<TextBlock Text="{x:Bind Name}" />
 						</NavigationViewItem.Content>
 					</NavigationViewItem>
 				</DataTemplate>
 			</NavigationView.MenuItemTemplate>
 
-		</NavigationView>
+			<!--  NavigationView Content, Save/Cancel buttons  -->
+			<NavigationView.Content>
+				<Grid>
+					<Grid.RowDefinitions>
+						<RowDefinition Height="*" />
+						<RowDefinition Height="Auto" />
+					</Grid.RowDefinitions>
+
+					<Frame x:Name="contentFrame" IsNavigationStackEnabled="False" />
+
+					<Grid
+						Grid.Row="2"
+						Height="58"
+						Background="{ThemeResource CardBackgroundFillColorSecondary}"
+						BorderBrush="{ThemeResource CardStrokeColorDefaultBrush}"
+						BorderThickness="0,1,0,0">
+						<StackPanel
+							Margin="12,0"
+							HorizontalAlignment="Right"
+							Orientation="Horizontal"
+							Spacing="12">
+
+							<Button
+								x:Name="SaveChangesButton"
+								Width="96"
+								Click="SaveChangesButton_Click"
+								Content="{helpers:ResourceString Name=Save}"
+								Style="{StaticResource AccentButtonStyle}" />
+
+							<Button
+								x:Name="CancelChangesButton"
+								Width="96"
+								Click="CancelChangesButton_Click"
+								Content="{helpers:ResourceString Name=Cancel}" />
+
+						</StackPanel>
+					</Grid>
+
+				</Grid>
+			</NavigationView.Content>
 
-		<!--  NavigationView Content, Save/Cancel buttons  -->
-		<Grid
-			Grid.Row="1"
-			Grid.Column="1"
-			Background="{ThemeResource LayerFillColorDefaultBrush}"
-			BorderBrush="{ThemeResource CardStrokeColorDefaultBrush}"
-			BorderThickness="1,1,0,0"
-			CornerRadius="8,0,0,0">
-			<Grid.RowDefinitions>
-				<RowDefinition Height="*" />
-				<RowDefinition Height="Auto" />
-			</Grid.RowDefinitions>
-
-			<Frame x:Name="contentFrame" IsNavigationStackEnabled="False" />
-
-			<Grid
-				Grid.Row="2"
-				Height="58"
-				Background="{ThemeResource CardBackgroundFillColorSecondary}"
-				BorderBrush="{ThemeResource CardStrokeColorDefaultBrush}"
-				BorderThickness="0,1,0,0">
-				<StackPanel
-					Margin="12,0"
-					HorizontalAlignment="Right"
-					Orientation="Horizontal"
-					Spacing="12">
-
-					<Button
-						x:Name="SaveChangesButton"
-						Width="96"
-						Click="SaveChangesButton_Click"
-						Content="{helpers:ResourceString Name=Save}"
-						Style="{StaticResource AccentButtonStyle}" />
-
-					<Button
-						x:Name="CancelChangesButton"
-						Width="96"
-						Click="CancelChangesButton_Click"
-						Content="{helpers:ResourceString Name=Cancel}" />
-
-				</StackPanel>
-			</Grid>
-
-		</Grid>
+		</NavigationView>
 
 	</Grid>
 </Page>

From fb5f9cd7f534cd4efcbe69b750902b775b9f4a86 Mon Sep 17 00:00:00 2001
From: U+5BFA <onein528@outlook.com>
Date: Sun, 12 Mar 2023 01:55:25 +0900
Subject: [PATCH 2/9] Add two different icons

---
 .../Views/Properties/MainPropertiesPage.xaml  | 46 +++++++++++++++++--
 1 file changed, 42 insertions(+), 4 deletions(-)

diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
index 0bdce48928c0..5bbf9c7f6f49 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
@@ -67,16 +67,54 @@
 						Height="64"
 						IsSelected="{x:Bind IsSelected, Mode=TwoWay}"
 						Tag="{x:Bind ItemType}">
-						<NavigationViewItem.Icon>
-							<PathIcon Data="{x:Bind OutlinePathIcon}" />
-						</NavigationViewItem.Icon>
 						<NavigationViewItem.Content>
-							<TextBlock Text="{x:Bind Name}" />
+							<Grid ColumnSpacing="8">
+								<Grid.ColumnDefinitions>
+									<ColumnDefinition Width="Auto" />
+									<ColumnDefinition Width="*" />
+								</Grid.ColumnDefinitions>
+
+								<!--  Icon  -->
+								<Grid x:Name="ItemPathIconGrid">
+									<!--  Outline Path Icon  -->
+									<Viewbox
+										Width="14"
+										Height="14"
+										Visibility="{x:Bind IsSelected, Converter={StaticResource BoolToVisibilityInverseConverter}, Mode=OneWay}">
+										<PathIcon
+											x:Name="NavigationViewItemOutlinePathIcon"
+											HorizontalAlignment="Center"
+											Data="{x:Bind OutlinePathIcon}" />
+									</Viewbox>
+									<!--  Filled Path Icon  -->
+									<Viewbox
+										Width="14"
+										Height="14"
+										Visibility="{x:Bind IsSelected, Converter={StaticResource BoolToVisibilityConverter}, Mode=OneWay}">
+										<PathIcon
+											x:Name="NavigationViewItemFilledPathIcon"
+											HorizontalAlignment="Center"
+											Data="{x:Bind FilledPathIcon}"
+											Foreground="{ThemeResource AccentFillColorDefaultBrush}" />
+									</Viewbox>
+								</Grid>
+
+								<!--  Label  -->
+								<TextBlock
+									x:Name="ItemNameLabelTextBlock"
+									Grid.Column="1"
+									HorizontalAlignment="Center"
+									Style="{StaticResource BodyTextBlockStyle}"
+									Text="{x:Bind Name}" />
+
+							</Grid>
 						</NavigationViewItem.Content>
 					</NavigationViewItem>
 				</DataTemplate>
 			</NavigationView.MenuItemTemplate>
 
+
+
 			<!--  NavigationView Content, Save/Cancel buttons  -->
 			<NavigationView.Content>
 				<Grid>

From dc12548804235e1857ec2038eadf64e368b76b65 Mon Sep 17 00:00:00 2001
From: U+5BFA <onein528@outlook.com>
Date: Sun, 26 Mar 2023 16:22:44 +0900
Subject: [PATCH 3/9] Update styles

---
 .../Helpers/FilePropertiesHelpers.cs          |  9 ++--
 .../NavigationViewItemButtonStyle.xaml        |  3 +-
 .../Views/Properties/MainPropertiesPage.xaml  | 35 ++++++++-------
 .../Properties/MainPropertiesPage.xaml.cs     | 43 ++++++++++++++-----
 4 files changed, 56 insertions(+), 34 deletions(-)

diff --git a/src/Files.App/Helpers/FilePropertiesHelpers.cs b/src/Files.App/Helpers/FilePropertiesHelpers.cs
index a901baae5aea..293b8d30e691 100644
--- a/src/Files.App/Helpers/FilePropertiesHelpers.cs
+++ b/src/Files.App/Helpers/FilePropertiesHelpers.cs
@@ -58,10 +58,7 @@ public static async Task OpenPropertiesWindowAsync(object item, IShellPage assoc
 
 			if (isUniversal)
 			{
-				var frame = new Frame
-				{
-					RequestedTheme = ThemeHelper.RootTheme
-				};
+				var frame = new Frame { RequestedTheme = ThemeHelper.RootTheme };
 				Navigate(frame);
 
 				var propertiesWindow = new WinUIEx.WindowEx
@@ -70,7 +67,7 @@ public static async Task OpenPropertiesWindowAsync(object item, IShellPage assoc
 					IsMaximizable = false,
 					MinWidth = 460,
 					MinHeight = 550,
-					Width = 600,
+					Width = 800,
 					Height = 550,
 					Content = frame,
 					Backdrop = new WinUIEx.MicaSystemBackdrop(),
@@ -103,6 +100,7 @@ public static async Task OpenPropertiesWindowAsync(object item, IShellPage assoc
 						Y = displayArea.WorkArea.Y
 							+ Math.Max(0, Math.Min(displayArea.WorkArea.Height - appWindow.Size.Height, pointerPosition.Y - displayArea.WorkArea.Y)),
 					};
+
 					appWindow.Move(appWindowPos);
 				}
 			}
@@ -111,6 +109,7 @@ public static async Task OpenPropertiesWindowAsync(object item, IShellPage assoc
 				var dialog = new PropertiesDialog();
 				dialog.propertiesFrame.Tag = dialog;
 				Navigate(dialog.propertiesFrame);
+
 				await dialog.ShowAsync(ContentDialogPlacement.Popup);
 			}
 
diff --git a/src/Files.App/ResourceDictionaries/NavigationViewItemButtonStyle.xaml b/src/Files.App/ResourceDictionaries/NavigationViewItemButtonStyle.xaml
index ee3478425227..ab241370b9e8 100644
--- a/src/Files.App/ResourceDictionaries/NavigationViewItemButtonStyle.xaml
+++ b/src/Files.App/ResourceDictionaries/NavigationViewItemButtonStyle.xaml
@@ -57,6 +57,8 @@
 
 	<Thickness x:Key="NavigationViewItemBorderThickness">1,1,1,1</Thickness>
 	<x:Double x:Key="NavigationViewItemOnLeftMinHeight">40</x:Double>
+	<Thickness x:Key="NavigationViewCompactItemContentPresenterMargin">2,0,0,0</Thickness>
+	<Thickness x:Key="NavigationViewItemContentPresenterMargin">2,0,0,2</Thickness>
 
 	<Style x:Key="MUX_NavigationViewItemPresenterStyleWhenOnLeftPane" TargetType="primitives:NavigationViewItemPresenter">
 		<Setter Property="Foreground" Value="{ThemeResource NavigationViewItemForeground}" />
@@ -118,7 +120,6 @@
 							<Grid
 								x:Name="ContentGrid"
 								MinHeight="{ThemeResource NavigationViewItemOnLeftMinHeight}"
-								Margin="0,0,14,0"
 								HorizontalAlignment="Stretch">
 								<Grid.ColumnDefinitions>
 									<ColumnDefinition Width="Auto" />
diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
index 6a4552dff3cd..90edf59ac292 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
@@ -12,6 +12,7 @@
 	Background="{ThemeResource App.Theme.BackgroundBrush}"
 	KeyDown="Page_KeyDown"
 	Loaded="Page_Loaded"
+	SizeChanged="MainPropertiesPage_SizeChanged"
 	mc:Ignorable="d">
 
 	<Page.Resources>
@@ -34,22 +35,22 @@
 
 	<Grid>
 		<Grid.RowDefinitions>
-			<RowDefinition Height="44" />
+			<RowDefinition Height="36" />
 			<RowDefinition Height="*" />
 		</Grid.RowDefinitions>
 
 		<!--  Titlebar  -->
-		<Border x:Name="TitlebarArea" Height="36">
+		<Border x:Name="TitlebarArea" Height="40">
 
 			<TextBlock
-				Padding="12,0"
+				Padding="16,0"
 				VerticalAlignment="Center"
 				Style="{StaticResource BodyStrongTextBlockStyle}"
 				Text="{helpers:ResourceString Name=Properties}" />
 
 		</Border>
 
-		<!--  Vertical NavigationView whose each items are squared  -->
+		<!--  Main NavigationView  -->
 		<NavigationView
 			x:Name="MainPropertiesWindowNavigationView"
 			Grid.Row="1"
@@ -58,18 +59,15 @@
 			IsSettingsVisible="False"
 			IsTitleBarAutoPaddingEnabled="False"
 			MenuItemsSource="{x:Bind NavViewItems, Mode=TwoWay}"
-			OpenPaneLength="200"
+			OpenPaneLength="180"
 			PaneDisplayMode="Left"
 			SelectionChanged="MainPropertiesWindowNavigationView_SelectionChanged">
 
 			<NavigationView.MenuItemTemplate>
-				<DataTemplate x:DataType="local:SquareNavViewItem">
-					<NavigationViewItem
-						Height="64"
-						IsSelected="{x:Bind IsSelected, Mode=TwoWay}"
-						Tag="{x:Bind ItemType}">
+				<DataTemplate x:DataType="local:NavigationViewItemButtonStyleItem">
+					<NavigationViewItem IsSelected="{x:Bind IsSelected, Mode=TwoWay}" Tag="{x:Bind ItemType}">
 						<NavigationViewItem.Content>
-							<Grid ColumnSpacing="8">
+							<Grid>
 								<Grid.ColumnDefinitions>
 									<ColumnDefinition Width="Auto" />
 									<ColumnDefinition Width="*" />
@@ -77,20 +75,21 @@
 
 								<!--  Icon  -->
 								<Viewbox
-									Width="24"
-									Height="24"
+									Width="16"
+									Height="16"
 									VerticalAlignment="Center">
-									<usercontrols:OpacityIcon IsSelected="{x:Bind IsSelected, Mode=OneWay}" Style="{x:Bind OpacityIconStyle, Mode=OneWay}" />
+									<usercontrols:OpacityIcon IsSelected="{x:Bind IsSelected, Mode=OneWay}" Style="{x:Bind OpacityIconStyle}" />
 								</Viewbox>
 
 								<!--  Label  -->
 								<TextBlock
 									x:Name="ItemNameLabelTextBlock"
 									Grid.Column="1"
-									HorizontalAlignment="Center"
-									FontSize="10"
-									Style="{StaticResource CaptionTextBlockStyle}"
-									Text="{x:Bind Name}" />
+									Margin="8,0,0,0"
+									VerticalAlignment="Center"
+									Style="{StaticResource BodyTextBlockStyle}"
+									Text="{x:Bind Name}"
+									Visibility="{x:Bind IsCompacted, Converter={StaticResource BoolToVisibilityInverseConverter}, Mode=OneWay}" />
 
 							</Grid>
 						</NavigationViewItem.Content>
diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs b/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
index a498156af316..7886d5657324 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
@@ -43,9 +43,10 @@ public SettingsViewModel AppSettings
 			=> App.AppSettings;
 
 		public Window Window;
+
 		public AppWindow AppWindow;
 
-		public ObservableCollection<SquareNavViewItem> NavViewItems { get; set; }
+		public ObservableCollection<NavigationViewItemButtonStyleItem> NavViewItems { get; set; }
 
 		public MainPropertiesPage()
 		{
@@ -98,6 +99,20 @@ private async void Page_Loaded(object sender, RoutedEventArgs e)
 			}
 		}
 
+		private void MainPropertiesPage_SizeChanged(object sender, SizeChangedEventArgs e)
+			=> UpdateDialogLayout();
+
+		private void UpdateDialogLayout()
+		{
+			MainPropertiesWindowNavigationView.PaneDisplayMode =
+				ActualWidth <= 600 ? NavigationViewPaneDisplayMode.LeftCompact : NavigationViewPaneDisplayMode.Left;
+
+			if (ActualWidth <= 600)
+				foreach (var item in NavViewItems) item.IsCompacted = true;
+			else
+				foreach (var item in NavViewItems) item.IsCompacted = false;
+		}
+
 		private async void AppSettings_ThemeModeChanged(object? sender, EventArgs e)
 		{
 			await DispatcherQueue.EnqueueAsync(() =>
@@ -167,49 +182,49 @@ private void MainPropertiesWindowNavigationView_SelectionChanged(NavigationView
 
 		private void AddNavigationViewItemsToControl(object item)
 		{
-			var generalItem = new SquareNavViewItem()
+			var generalItem = new NavigationViewItemButtonStyleItem()
 			{
 				Name = "General".GetLocalizedResource(),
 				ItemType = PropertyNavigationViewItemEnums.ItemGeneral,
 				OpacityIconStyle = (Style)Application.Current.Resources["ColorIconGeneralProperties"],
 			};
-			var securityItem = new SquareNavViewItem()
+			var securityItem = new NavigationViewItemButtonStyleItem()
 			{
 				Name = "Security".GetLocalizedResource(),
 				ItemType = PropertyNavigationViewItemEnums.ItemSecurity,
 				OpacityIconStyle = (Style)Application.Current.Resources["ColorIconSecurityProperties"],
 			};
-			var hashItem = new SquareNavViewItem()
+			var hashItem = new NavigationViewItemButtonStyleItem()
 			{
 				Name = "Hashes".GetLocalizedResource(),
 				ItemType = PropertyNavigationViewItemEnums.ItemHash,
 				OpacityIconStyle = (Style)Application.Current.Resources["ColorIconHashesProperties"],
 			};
-			var shortcutItem = new SquareNavViewItem()
+			var shortcutItem = new NavigationViewItemButtonStyleItem()
 			{
 				Name = "Shortcut".GetLocalizedResource(),
 				ItemType = PropertyNavigationViewItemEnums.ItemShortcut,
 				OpacityIconStyle = (Style)Application.Current.Resources["ColorIconShortcutProperties"],
 			};
-			var libraryItem = new SquareNavViewItem()
+			var libraryItem = new NavigationViewItemButtonStyleItem()
 			{
 				Name = "Library".GetLocalizedResource(),
 				ItemType = PropertyNavigationViewItemEnums.ItemLibrary,
 				OpacityIconStyle = (Style)Application.Current.Resources["ColorIconLibraryProperties"],
 			};
-			var detailsItem = new SquareNavViewItem()
+			var detailsItem = new NavigationViewItemButtonStyleItem()
 			{
 				Name = "Details".GetLocalizedResource(),
 				ItemType = PropertyNavigationViewItemEnums.ItemDetails,
 				OpacityIconStyle = (Style)Application.Current.Resources["ColorIconDetailsProperties"],
 			};
-			var customizationItem = new SquareNavViewItem()
+			var customizationItem = new NavigationViewItemButtonStyleItem()
 			{
 				Name = "Customization".GetLocalizedResource(),
 				ItemType = PropertyNavigationViewItemEnums.ItemCustomization,
 				OpacityIconStyle = (Style)Application.Current.Resources["ColorIconCustomizationProperties"],
 			};
-			var compatibilityItem = new SquareNavViewItem()
+			var compatibilityItem = new NavigationViewItemButtonStyleItem()
 			{
 				Name = "Compatibility".GetLocalizedResource(),
 				ItemType = PropertyNavigationViewItemEnums.ItemCompatibility,
@@ -369,7 +384,8 @@ public class PropertyNavParam
 		}
 	}
 
-	public class SquareNavViewItem : ObservableObject
+	// TODO: Should move to a general place to use in the Settings Dialog as well
+	public class NavigationViewItemButtonStyleItem : ObservableObject
 	{
 		public string Name;
 
@@ -388,6 +404,13 @@ public bool IsSelected
 			get => _isSelected;
 			set => SetProperty(ref _isSelected, value);
 		}
+
+		private bool _isCompacted;
+		public bool IsCompacted
+		{
+			get => _isCompacted;
+			set => SetProperty(ref _isCompacted, value);
+		}
 	}
 
 	public enum PropertyNavigationViewItemEnums

From a05062bf607ce8f5b71b0aefbb9a12af13aafab8 Mon Sep 17 00:00:00 2001
From: U+5BFA <onein528@outlook.com>
Date: Sun, 26 Mar 2023 16:31:18 +0900
Subject: [PATCH 4/9] Update

---
 src/Files.App/Views/Properties/MainPropertiesPage.xaml | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
index 90edf59ac292..a675f13b625a 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
@@ -8,7 +8,7 @@
 	xmlns:local="using:Files.App.Views.Properties"
 	xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
 	xmlns:toolkitconvers="using:CommunityToolkit.WinUI.UI.Converters"
-	xmlns:usercontrols="using:Files.App.UserControls"
+	xmlns:uc="using:Files.App.UserControls"
 	Background="{ThemeResource App.Theme.BackgroundBrush}"
 	KeyDown="Page_KeyDown"
 	Loaded="Page_Loaded"
@@ -78,7 +78,7 @@
 									Width="16"
 									Height="16"
 									VerticalAlignment="Center">
-									<usercontrols:OpacityIcon IsSelected="{x:Bind IsSelected, Mode=OneWay}" Style="{x:Bind OpacityIconStyle}" />
+									<uc:OpacityIcon IsSelected="{x:Bind IsSelected, Mode=OneWay}" Style="{x:Bind OpacityIconStyle}" />
 								</Viewbox>
 
 								<!--  Label  -->
@@ -97,8 +97,6 @@
 				</DataTemplate>
 			</NavigationView.MenuItemTemplate>
 
-
-
 			<!--  NavigationView Content, Save/Cancel buttons  -->
 			<NavigationView.Content>
 				<Grid>
@@ -110,8 +108,7 @@
 					<Frame x:Name="contentFrame" IsNavigationStackEnabled="False" />
 
 					<Grid
-						Grid.Row="2"
-						Height="58"
+						Grid.Row="1"
 						Background="{ThemeResource CardBackgroundFillColorSecondary}"
 						BorderBrush="{ThemeResource CardStrokeColorDefaultBrush}"
 						BorderThickness="0,1,0,0">

From 7f6361df512abb4dcce220ba964e8cd746421e16 Mon Sep 17 00:00:00 2001
From: U+5BFA <onein528@outlook.com>
Date: Sun, 26 Mar 2023 16:35:11 +0900
Subject: [PATCH 5/9] Update 2

---
 .../Views/Properties/MainPropertiesPage.xaml         | 12 +++++-------
 .../Views/Properties/MainPropertiesPage.xaml.cs      |  1 -
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
index a675f13b625a..881557a65733 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
@@ -7,8 +7,8 @@
 	xmlns:helpers="using:Files.App.Helpers"
 	xmlns:local="using:Files.App.Views.Properties"
 	xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
-	xmlns:toolkitconvers="using:CommunityToolkit.WinUI.UI.Converters"
 	xmlns:uc="using:Files.App.UserControls"
+	xmlns:wctconverters="using:CommunityToolkit.WinUI.UI.Converters"
 	Background="{ThemeResource App.Theme.BackgroundBrush}"
 	KeyDown="Page_KeyDown"
 	Loaded="Page_Loaded"
@@ -22,14 +22,14 @@
 				<ResourceDictionary Source="ms-appx:///ResourceDictionaries/NavigationViewItemButtonStyle.xaml" />
 			</ResourceDictionary.MergedDictionaries>
 
-			<toolkitconvers:BoolNegationConverter x:Key="BoolNegationConverter" />
+			<wctconverters:BoolNegationConverter x:Key="BoolNegationConverter" />
 
-			<toolkitconvers:BoolToVisibilityConverter x:Key="BoolToVisibilityConverter" />
-
-			<toolkitconvers:BoolToVisibilityConverter
+			<wctconverters:BoolToVisibilityConverter x:Key="BoolToVisibilityConverter" />
+			<wctconverters:BoolToVisibilityConverter
 				x:Key="BoolToVisibilityInverseConverter"
 				FalseValue="Visible"
 				TrueValue="Collapsed" />
+
 		</ResourceDictionary>
 	</Page.Resources>
 
@@ -41,13 +41,11 @@
 
 		<!--  Titlebar  -->
 		<Border x:Name="TitlebarArea" Height="40">
-
 			<TextBlock
 				Padding="16,0"
 				VerticalAlignment="Center"
 				Style="{StaticResource BodyStrongTextBlockStyle}"
 				Text="{helpers:ResourceString Name=Properties}" />
-
 		</Border>
 
 		<!--  Main NavigationView  -->
diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs b/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
index 7886d5657324..5e54c190437d 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
@@ -21,7 +21,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Windows.Foundation.Metadata;
-using Windows.Graphics;
 using Windows.System;
 using Windows.UI;
 

From 6fde4940e0ecf975268a7d51f0f4ca7681cd9062 Mon Sep 17 00:00:00 2001
From: U+5BFA <62196528+onein528@users.noreply.github.com>
Date: Sun, 26 Mar 2023 23:51:55 +0900
Subject: [PATCH 6/9] Update
 src/Files.App/Views/Properties/MainPropertiesPage.xaml

Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
---
 src/Files.App/Views/Properties/MainPropertiesPage.xaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
index 881557a65733..be35ed47fa9d 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
@@ -76,7 +76,7 @@
 									Width="16"
 									Height="16"
 									VerticalAlignment="Center">
-									<uc:OpacityIcon IsSelected="{x:Bind IsSelected, Mode=OneWay}" Style="{x:Bind OpacityIconStyle}" />
+									<uc:OpacityIcon IsSelected="{x:Bind IsSelected, Mode=OneWay}" Style="{x:Bind OpacityIconStyle, Mode=OneWay}" />
 								</Viewbox>
 
 								<!--  Label  -->

From 9545e1e69709df3b93b2385c609debadc8b30ead Mon Sep 17 00:00:00 2001
From: Yair <39923744+yaira2@users.noreply.github.com>
Date: Sun, 26 Mar 2023 14:24:04 -0400
Subject: [PATCH 7/9] Update MainPropertiesPage.xaml

---
 src/Files.App/Views/Properties/MainPropertiesPage.xaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
index be35ed47fa9d..da9e2fb6f36b 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
@@ -100,7 +100,7 @@
 				<Grid>
 					<Grid.RowDefinitions>
 						<RowDefinition Height="*" />
-						<RowDefinition Height="Auto" />
+						<RowDefinition Height="52" />
 					</Grid.RowDefinitions>
 
 					<Frame x:Name="contentFrame" IsNavigationStackEnabled="False" />

From 492c377caff6ca49e7a4ca2390bbd2bec7e2218f Mon Sep 17 00:00:00 2001
From: Yair <39923744+yaira2@users.noreply.github.com>
Date: Mon, 27 Mar 2023 15:58:30 -0400
Subject: [PATCH 8/9] Suggested changes

---
 .../Views/Properties/MainPropertiesPage.xaml   |  2 +-
 .../Properties/MainPropertiesPage.xaml.cs      | 18 ++++++++++--------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
index da9e2fb6f36b..5a11fba9b4c4 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml
@@ -87,7 +87,7 @@
 									VerticalAlignment="Center"
 									Style="{StaticResource BodyTextBlockStyle}"
 									Text="{x:Bind Name}"
-									Visibility="{x:Bind IsCompacted, Converter={StaticResource BoolToVisibilityInverseConverter}, Mode=OneWay}" />
+									Visibility="{x:Bind IsCompact, Converter={StaticResource BoolToVisibilityInverseConverter}, Mode=OneWay}" />
 
 							</Grid>
 						</NavigationViewItem.Content>
diff --git a/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs b/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
index a9b5b137c9d1..809f8e69e942 100644
--- a/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
+++ b/src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
@@ -99,7 +99,9 @@ private async void Page_Loaded(object sender, RoutedEventArgs e)
 		}
 
 		private void MainPropertiesPage_SizeChanged(object sender, SizeChangedEventArgs e)
-			=> UpdateDialogLayout();
+		{
+			UpdateDialogLayout();
+		}
 
 		private void UpdateDialogLayout()
 		{
@@ -107,9 +109,9 @@ private void UpdateDialogLayout()
 				ActualWidth <= 600 ? NavigationViewPaneDisplayMode.LeftCompact : NavigationViewPaneDisplayMode.Left;
 
 			if (ActualWidth <= 600)
-				foreach (var item in NavViewItems) item.IsCompacted = true;
+				foreach (var item in NavViewItems) item.IsCompact = true;
 			else
-				foreach (var item in NavViewItems) item.IsCompacted = false;
+				foreach (var item in NavViewItems) item.IsCompact = false;
 		}
 
 		private async void AppSettings_ThemeModeChanged(object? sender, EventArgs e)
@@ -255,7 +257,7 @@ private void AddNavigationViewItemsToControl(object item)
 				NavViewItems.Remove(securityItem);
 				NavViewItems.Remove(customizationItem);
 				NavViewItems.Remove(hashItem);
-			} 
+			}
 			else if (item is ListedItem listedItem)
 			{
 				var isShortcut = listedItem.IsShortcut;
@@ -404,11 +406,11 @@ public bool IsSelected
 			set => SetProperty(ref _isSelected, value);
 		}
 
-		private bool _isCompacted;
-		public bool IsCompacted
+		private bool _isCompact;
+		public bool IsCompact
 		{
-			get => _isCompacted;
-			set => SetProperty(ref _isCompacted, value);
+			get => _isCompact;
+			set => SetProperty(ref _isCompact, value);
 		}
 	}
 

From 4d6daa0af5b81349d0da25b282c1e49d608a6611 Mon Sep 17 00:00:00 2001
From: Yair <39923744+yaira2@users.noreply.github.com>
Date: Mon, 27 Mar 2023 20:40:05 -0400
Subject: [PATCH 9/9] Update FilePropertiesHelpers.cs

---
 src/Files.App/Helpers/FilePropertiesHelpers.cs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/Files.App/Helpers/FilePropertiesHelpers.cs b/src/Files.App/Helpers/FilePropertiesHelpers.cs
index 293b8d30e691..5460a45d9591 100644
--- a/src/Files.App/Helpers/FilePropertiesHelpers.cs
+++ b/src/Files.App/Helpers/FilePropertiesHelpers.cs
@@ -58,7 +58,10 @@ public static async Task OpenPropertiesWindowAsync(object item, IShellPage assoc
 
 			if (isUniversal)
 			{
-				var frame = new Frame { RequestedTheme = ThemeHelper.RootTheme };
+				var frame = new Frame
+				{
+					RequestedTheme = ThemeHelper.RootTheme
+				};
 				Navigate(frame);
 
 				var propertiesWindow = new WinUIEx.WindowEx