Summary: Change Order Now/Register Button in TicketsFragment (#2245)

Details:
- Check totalAmount in order to set "Order Now", "Register" for button
- Get tickets detail saved from ViewModel instead of fetching from the database

Fixes: #2238

Author: anhanh11001

app/src/main/java/org/fossasia/openevent/general/ticket/TicketsFragment.kt

@@ -55,7 +55,6 @@ class TicketsFragment : Fragment() {
     private lateinit var rootView: View
     private lateinit var linearLayoutManager: LinearLayoutManager
     private var ticketIdAndQty = ArrayList<Triple<Int, Int, Float>>()
-    private var totalAmount: Float = 0.0f
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
@@ -122,19 +121,12 @@ class TicketsFragment : Fragment() {
 
         rootView.register.setOnClickListener {
             if (!ticketsViewModel.totalTicketsEmpty(ticketIdAndQty)) {
-                ticketsViewModel.getAmount(ticketIdAndQty)
+                checkForAuthentication()
             } else {
                 showErrorMessage(resources.getString(R.string.no_tickets_message))
             }
         }
 
-        ticketsViewModel.amount
-            .nonNull()
-            .observe(viewLifecycleOwner, Observer {
-                totalAmount = it
-                checkForAuthentication()
-            })
-
         rootView.retry.setOnClickListener {
             loadTickets()
             loadTaxDetails()
@@ -195,6 +187,19 @@ class TicketsFragment : Fragment() {
             override fun onSelected(ticketId: Int, quantity: Int, donation: Float) {
                 handleTicketSelect(ticketId, quantity, donation)
                 ticketsViewModel.ticketIdAndQty.value = ticketIdAndQty
+                ticketsViewModel.totalAmount = ticketsViewModel.getAmount(ticketIdAndQty)
+                when {
+                    ticketsViewModel.totalAmount == -1F -> {
+                        ticketsViewModel.tickets.value?.let {
+                            if (it.any { ticket -> ticket.price > 0 })
+                                rootView.register.text = getString(R.string.order_now)
+                            else
+                                rootView.register.text = getString(R.string.register)
+                        }
+                    }
+                    ticketsViewModel.totalAmount > 0 -> rootView.register.text = getString(R.string.order_now)
+                    else -> rootView.register.text = getString(R.string.register)
+                }
             }
         }
         ticketsRecyclerAdapter.setSelectListener(ticketSelectedListener)
@@ -218,12 +223,11 @@ class TicketsFragment : Fragment() {
 
     private fun redirectToAttendee() {
         val wrappedTicketAndQty = TicketIdAndQtyWrapper(ticketIdAndQty)
-        ticketsViewModel.mutableAmount.value = null
         findNavController(rootView).navigate(TicketsFragmentDirections.actionTicketsToAttendee(
             eventId = safeArgs.eventId,
             ticketIdAndQty = wrappedTicketAndQty,
             currency = safeArgs.currency,
-            amount = totalAmount,
+            amount = ticketsViewModel.totalAmount,
             taxAmount = ticketsViewModel.totalTaxAmount
         ))
     }

app/src/main/java/org/fossasia/openevent/general/ticket/TicketsViewModel.kt

@@ -45,12 +45,11 @@ class TicketsViewModel(
     val taxInfo: LiveData<Tax> = mutableTaxInfo
     var appliedDiscountCode: DiscountCode? = null
     var totalTaxAmount = 0f
-    val mutableAmount = MutableLiveData<Float>()
-    val amount: LiveData<Float> = mutableAmount
     private val mutableTicketTableVisibility = MutableLiveData<Boolean>()
     val ticketTableVisibility: LiveData<Boolean> = mutableTicketTableVisibility
     val ticketIdAndQty = MutableLiveData<List<Triple<Int, Int, Float>>>()
     var discountCodeCurrentLayout = APPLY_DISCOUNT_CODE
+    var totalAmount: Float = 0.0f
 
     fun isLoggedIn() = authHolder.isLoggedIn()
 
@@ -106,7 +105,7 @@ class TicketsViewModel(
             })
     }
 
-    fun getAmount(ticketIdAndQty: List<Triple<Int, Int, Float>>) {
+    fun getAmount(ticketIdAndQty: List<Triple<Int, Int, Float>>): Float {
         val ticketIds = ArrayList<Int>()
         val qty = ArrayList<Int>()
         val tax = taxInfo.value
@@ -121,34 +120,27 @@ class TicketsViewModel(
             }
         }
         val donation = ticketIdAndQty.map { it.third*it.second }.sum()
-        compositeDisposable += ticketService.getTicketsWithIds(ticketIds)
-            .withDefaultSchedulers()
-            .doOnSubscribe {
-                mutableProgress.value = true
-            }.doFinally {
-                mutableProgress.value = false
-            }.subscribe({ tickets ->
-                var prices = 0F
-                var index = 0
-                val code = appliedDiscountCode
-                tickets.forEach { ticket ->
-                    var price = ticket.price
-                    totalTaxAmount += (ticket.price * taxRate / 100) * qty[index]
-                    if (code?.value != null) {
-                        appliedDiscountCode?.tickets?.forEach { ticketId ->
-                            if (ticket.id == ticketId.id.toInt()) {
-                                price -= if (code.type == AMOUNT) code.value else price*(code.value / 100)
-                            }
+        tickets.value?.filter { ticketIds.contains(it.id) }?.let { tickets ->
+            var prices = 0F
+            var index = 0
+            val code = appliedDiscountCode
+            tickets.forEach { ticket ->
+                var price = ticket.price
+                totalTaxAmount += (ticket.price * taxRate / 100) * qty[index]
+                if (code?.value != null) {
+                    appliedDiscountCode?.tickets?.forEach { ticketId ->
+                        if (ticket.id == ticketId.id.toInt()) {
+                            price -= if (code.type == AMOUNT) code.value else price*(code.value / 100)
                         }
                     }
-                    price.let { prices += price * qty[index] }
-                    index++
                 }
-                prices += totalTaxAmount
-                mutableAmount.value = prices + donation
-            }, {
-                Timber.e(it, "Error Loading tickets!")
-            })
+                price.let { prices += price * qty[index] }
+                index++
+            }
+            prices += totalTaxAmount
+            return prices + donation
+        }
+        return -1F
     }
 
     fun getTaxDetails(eventId: Long) {

app/src/main/res/values/strings.xml

@@ -518,5 +518,6 @@
     <string name="by_organizer_name">by %1$s</string>
     <string name="credit_debit_card">Debit/Credit Card</string>
     <string name="select_payment_option_message">Please select a payment option for this order</string>
+    <string name="order_now">Order Now</string>
 
 </resources>