Skip to content

Commit 6b92633

Browse files
committed
fix: Feedback button (#2175)
1 parent 6a20b94 commit 6b92633

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import kotlinx.android.synthetic.main.content_event.view.eventOrganiserDescripti
3434
import kotlinx.android.synthetic.main.content_event.view.eventTimingLinearLayout
3535
import kotlinx.android.synthetic.main.content_event.view.imageMap
3636
import kotlinx.android.synthetic.main.content_event.view.eventImage
37-
import kotlinx.android.synthetic.main.content_event.view.feedbackBtn
37+
import kotlinx.android.synthetic.main.content_event.view.feedbackTv
3838
import kotlinx.android.synthetic.main.content_event.view.feedbackRv
3939
import kotlinx.android.synthetic.main.content_event.view.feedbackProgress
4040
import kotlinx.android.synthetic.main.content_event.view.nestedContentEventScroll
@@ -267,7 +267,7 @@ class EventDetailsFragment : Fragment() {
267267
.nonNull()
268268
.observe(viewLifecycleOwner, Observer {
269269
rootView.feedbackProgress.isVisible = it
270-
rootView.feedbackBtn.isEnabled = !it
270+
rootView.feedbackTv.isVisible = !it
271271
})
272272

273273
eventViewModel.eventFeedback.observe(viewLifecycleOwner, Observer {
@@ -291,7 +291,7 @@ class EventDetailsFragment : Fragment() {
291291
rootView.noFeedBackTv.isVisible = false
292292
})
293293

294-
rootView.feedbackBtn.setOnClickListener {
294+
rootView.feedbackTv.setOnClickListener {
295295
checkForAuthentication()
296296
}
297297
}

app/src/main/res/layout/content_event.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -555,14 +555,14 @@
555555
android:visibility="gone"
556556
tools:visibility="visible"/>
557557

558-
<Button
559-
android:id="@+id/feedbackBtn"
558+
<TextView
559+
android:id="@+id/feedbackTv"
560+
android:textStyle="bold"
561+
android:textAlignment="center"
560562
android:layout_width="match_parent"
561563
android:layout_height="wrap_content"
562-
android:layout_marginTop="@dimen/layout_margin_small"
563-
android:layout_marginStart="@dimen/layout_margin_large"
564-
android:layout_marginEnd="@dimen/layout_margin_large"
565-
android:layout_marginBottom="@dimen/layout_margin_large"
564+
android:layout_margin="@dimen/layout_margin_large"
565+
android:textColor="@color/colorAccent"
566566
android:text="@string/write_feedback" />
567567
</LinearLayout>
568568

app/src/main/res/layout/fragment_event.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
layout="@layout/content_event"
4141
android:layout_width="match_parent"
4242
android:layout_height="match_parent"
43-
android:layout_marginBottom="@dimen/event_details_divider_margin"
43+
android:layout_marginBottom="@dimen/layout_margin_extreme_large"
4444
bind:event="@{event}" />
4545

4646
<View

app/src/main/res/values/strings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -356,11 +356,11 @@
356356
<string name="and_i_m_up_for">And I\'m up for</string>
357357
<string name="what_type">What Sounds good?</string>
358358
<string name="feedback">Feedback</string>
359-
<string name="write_feedback">Write Feedback</string>
359+
<string name="write_feedback">WRITE A FEEDBACK</string>
360360
<string name="submit">Submit</string>
361361
<string name="submit_feedback">Submit Feedback</string>
362362
<string name="feedback_submitted">Feedback submitted Successfully</string>
363-
<string name="be_the_first_to_write_a_review">Be the first to write a review</string>
363+
<string name="be_the_first_to_write_a_review">Be the first to write a feedback</string>
364364
<string name="frequently_asked_questions">Frequently Asked Questions</string>
365365
<string name="no_faq_message">There are no frequenly asked questions for this event.</string>
366366

0 commit comments

Comments
 (0)