fix: Feedback - button and crashes (#2175) (#2184)

Author: liveHarshit

app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt

@@ -267,7 +267,7 @@ class EventDetailsFragment : Fragment() {
             .nonNull()
             .observe(viewLifecycleOwner, Observer {
                 rootView.feedbackProgress.isVisible = it
-                rootView.feedbackBtn.isEnabled = !it
+                rootView.feedbackBtn.isVisible = !it
             })
 
         eventViewModel.eventFeedback.observe(viewLifecycleOwner, Observer {
@@ -286,7 +286,10 @@ class EventDetailsFragment : Fragment() {
         eventViewModel.submittedFeedback
             .nonNull()
             .observe(viewLifecycleOwner, Observer {
-                feedbackAdapter.add(it)
+                if (feedbackAdapter.itemCount < LIMITED_FEEDBACK_NUMBER)
+                    feedbackAdapter.add(it)
+                else
+                    rootView.seeFeedbackTextView.isVisible = true
                 rootView.feedbackRv.isVisible = true
                 rootView.noFeedBackTv.isVisible = false
             })

app/src/main/java/org/fossasia/openevent/general/search/type/SearchTypeFragment.kt

@@ -28,7 +28,7 @@ class SearchTypeFragment : Fragment() {
     private val searchTypeViewModel by viewModel<SearchTypeViewModel>()
     private val safeArgs: SearchTypeFragmentArgs by navArgs()
     private lateinit var rootView: View
-    private val eventTypesList =  ArrayList<String>()
+    private val eventTypesList = ArrayList<String>()
 
     override fun onCreateView(
         inflater: LayoutInflater,

app/src/main/res/layout/content_event.xml

@@ -557,12 +557,13 @@
 
                 <Button
                     android:id="@+id/feedbackBtn"
+                    style="@style/ThreeDS2TextButtonStyle"
+                    android:textAllCaps="true"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
-                    android:layout_marginTop="@dimen/layout_margin_small"
-                    android:layout_marginStart="@dimen/layout_margin_large"
-                    android:layout_marginEnd="@dimen/layout_margin_large"
+                    android:layout_marginTop="@dimen/layout_margin_medium"
                     android:layout_marginBottom="@dimen/layout_margin_large"
+                    android:textColor="@color/colorAccent"
                     android:text="@string/write_feedback" />
             </LinearLayout>
 

app/src/main/res/layout/fragment_event.xml

@@ -40,7 +40,7 @@
                 layout="@layout/content_event"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
-                android:layout_marginBottom="@dimen/event_details_divider_margin"
+                android:layout_marginBottom="@dimen/layout_margin_extreme_large"
                 bind:event="@{event}" />
 
             <View

app/src/main/res/values/strings.xml

@@ -356,11 +356,11 @@
     <string name="and_i_m_up_for">And I\'m up for</string>
     <string name="what_type">What Sounds good?</string>
     <string name="feedback">Feedback</string>
-    <string name="write_feedback">Write Feedback</string>
+    <string name="write_feedback">Write a feedback</string>
     <string name="submit">Submit</string>
     <string name="submit_feedback">Submit Feedback</string>
     <string name="feedback_submitted">Feedback submitted Successfully</string>
-    <string name="be_the_first_to_write_a_review">Be the first to write a review</string>
+    <string name="be_the_first_to_write_a_review">Be the first to write a feedback</string>
     <string name="frequently_asked_questions">Frequently Asked Questions</string>
     <string name="no_faq_message">There are no frequenly asked questions for this event.</string>