fix: appcrash on signup due to smart auth by removing it

Fixes: #1531

Changes:

- Removes the Smart Auth features to fix app crash. These will be reimplemented later

SmartAuthViewModels files have not been deleted

Author: addiegupta

app/src/main/java/org/fossasia/openevent/general/MainActivity.kt

@@ -1,6 +1,5 @@
 package org.fossasia.openevent.general
 
-import android.content.Intent
 import android.os.Bundle
 import androidx.appcompat.app.AppCompatActivity
 import androidx.navigation.NavController
@@ -11,9 +10,6 @@ import kotlinx.android.synthetic.main.activity_main.navigation
 import kotlinx.android.synthetic.main.activity_main.navigationAuth
 import kotlinx.android.synthetic.main.activity_main.mainFragmentCoordinatorLayout
 import org.fossasia.openevent.general.auth.EditProfileFragment
-import org.fossasia.openevent.general.search.RC_CREDENTIALS_READ
-import org.fossasia.openevent.general.search.RC_CREDENTIALS_SAVE
-import org.fossasia.openevent.general.search.SmartAuthViewModel
 import org.fossasia.openevent.general.utils.Utils.navAnimGone
 import org.fossasia.openevent.general.utils.Utils.navAnimVisible
 
@@ -93,13 +89,6 @@ class MainActivity : AppCompatActivity() {
     fun onSuperBackPressed() {
         super.onBackPressed()
     }
-
-    override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
-        if (requestCode == RC_CREDENTIALS_READ || requestCode == RC_CREDENTIALS_SAVE)
-            SmartAuthViewModel().onActivityResult(requestCode, resultCode, data, this)
-        else
-            super.onActivityResult(requestCode, resultCode, data)
-    }
 }
 
 interface ScrollToTop {

app/src/main/java/org/fossasia/openevent/general/auth/LoginFragment.kt

@@ -2,7 +2,6 @@ package org.fossasia.openevent.general.auth
 
 import android.os.Bundle
 import android.text.Editable
-import android.text.SpannableStringBuilder
 import android.text.TextWatcher
 import android.view.LayoutInflater
 import android.view.MenuItem
@@ -27,7 +26,6 @@ import kotlinx.android.synthetic.main.fragment_login.view.loginLayout
 import kotlinx.android.synthetic.main.fragment_login.view.sentEmailLayout
 import kotlinx.android.synthetic.main.fragment_login.view.tick
 import org.fossasia.openevent.general.R
-import org.fossasia.openevent.general.search.SmartAuthViewModel
 import org.fossasia.openevent.general.utils.Utils
 import org.fossasia.openevent.general.utils.Utils.show
 import org.fossasia.openevent.general.utils.Utils.hideSoftKeyboard
@@ -38,7 +36,6 @@ import org.koin.androidx.viewmodel.ext.android.viewModel
 class LoginFragment : Fragment() {
 
     private val loginViewModel by viewModel<LoginViewModel>()
-    private val smartAuthViewModel by viewModel<SmartAuthViewModel>()
     private lateinit var rootView: View
     private val safeArgs: LoginFragmentArgs by navArgs()
 
@@ -54,8 +51,6 @@ class LoginFragment : Fragment() {
         setHasOptionsMenu(true)
         showSnackbar()
 
-        smartAuthViewModel.buildCredential(activity, null)
-
         if (loginViewModel.isLoggedIn())
             popBackStack()
 
@@ -64,30 +59,12 @@ class LoginFragment : Fragment() {
             hideSoftKeyboard(context, rootView)
         }
 
-        smartAuthViewModel.id
-            .nonNull()
-            .observe(viewLifecycleOwner, Observer {
-                email.text = SpannableStringBuilder(it)
-            })
-
-        smartAuthViewModel.password
-            .nonNull()
-            .observe(viewLifecycleOwner, Observer {
-                password.text = SpannableStringBuilder(it)
-            })
-
         loginViewModel.progress
             .nonNull()
             .observe(viewLifecycleOwner, Observer {
                 progressDialog.show(it)
             })
 
-        smartAuthViewModel.progress
-            .nonNull()
-            .observe(viewLifecycleOwner, Observer {
-                progressDialog.show(it)
-            })
-
         loginViewModel.showNoInternetDialog
             .nonNull()
             .observe(viewLifecycleOwner, Observer {
@@ -167,18 +144,12 @@ class LoginFragment : Fragment() {
         loginViewModel.user
             .nonNull()
             .observe(viewLifecycleOwner, Observer {
-                smartAuthViewModel.saveCredential(activity, email.text.toString(), password.text.toString())
                 popBackStack()
             })
 
         return rootView
     }
 
-    override fun onStart() {
-        super.onStart()
-        smartAuthViewModel.requestCredentials(activity)
-    }
-
     private fun popBackStack() {
         findNavController(rootView).popBackStack()
         Snackbar.make(rootView, R.string.welcome_back, Snackbar.LENGTH_SHORT).show()

app/src/main/java/org/fossasia/openevent/general/auth/SignUpFragment.kt

@@ -31,7 +31,6 @@ import kotlinx.android.synthetic.main.fragment_signup.view.signupNestedScrollVie
 import kotlinx.android.synthetic.main.fragment_signup.view.signUpText
 import kotlinx.android.synthetic.main.fragment_signup.view.signUpCheckbox
 import org.fossasia.openevent.general.R
-import org.fossasia.openevent.general.search.SmartAuthViewModel
 import org.fossasia.openevent.general.utils.Utils
 import org.fossasia.openevent.general.utils.Utils.show
 import org.fossasia.openevent.general.utils.extensions.nonNull
@@ -45,7 +44,6 @@ import android.text.style.ClickableSpan
 class SignUpFragment : Fragment() {
 
     private val signUpViewModel by viewModel<SignUpViewModel>()
-    private val smartAuthViewModel by viewModel<SmartAuthViewModel>()
     private lateinit var rootView: View
 
     override fun onCreateView(
@@ -161,9 +159,6 @@ class SignUpFragment : Fragment() {
         signUpViewModel.loggedIn
             .nonNull()
             .observe(viewLifecycleOwner, Observer {
-                smartAuthViewModel.saveCredential(
-                    activity, usernameSignUp.text.toString(),
-                    passwordSignUp.text.toString())
                 redirectToMain()
             })
 

app/src/main/java/org/fossasia/openevent/general/di/Modules.kt

@@ -58,7 +58,6 @@ import org.fossasia.openevent.general.paypal.PaypalApi
 import org.fossasia.openevent.general.search.GeoLocationViewModel
 import org.fossasia.openevent.general.search.SearchLocationViewModel
 import org.fossasia.openevent.general.search.SearchViewModel
-import org.fossasia.openevent.general.search.SmartAuthViewModel
 import org.fossasia.openevent.general.search.LocationService
 import org.fossasia.openevent.general.search.LocationServiceImpl
 import org.fossasia.openevent.general.settings.SettingsViewModel
@@ -151,7 +150,6 @@ val viewModelModule = module {
     viewModel { OrderDetailsViewModel(get(), get(), get()) }
     viewModel { EditProfileViewModel(get(), get(), get()) }
     viewModel { GeoLocationViewModel(get()) }
-    viewModel { SmartAuthViewModel() }
 }
 
 val networkModule = module {