review

ldez · alexandear · ldez · commit d724a610c6ed · 2024-03-28T20:37:29.000+01:00
Co-authored-by: Oleksandr Redko &lt;oleksandr.red+github@gmail.com&gt;
diff --git a/pkg/lint/lintersdb/validator.go b/pkg/lint/lintersdb/validator.go
@@ -91,8 +91,7 @@ func (v Validator) alternativeNamesDeprecation(cfg *config.Linters) error {
 		}
 	}
 
-	var names []string
-	names = append(names, cfg.Enable...)
+	names := append([]string{}, cfg.Enable...)
 	names = append(names, cfg.Disable...)
 
 	for _, name := range names {
diff --git a/pkg/logutils/mock.go b/pkg/logutils/mock.go
@@ -47,8 +47,7 @@ func (m *MockLog) SetLevel(level LogLevel) {
 }
 
 func (m *MockLog) OnFatalf(format string, args ...any) *MockLog {
-	arguments := []any{format}
-	arguments = append(arguments, args...)
+	arguments := append([]any{format}, args...)
 
 	m.On("Fatalf", arguments...)
 

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,7 @@ func (v Validator) alternativeNamesDeprecation(cfg *config.Linters) error {`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`
`94`		`- var names []string`
`95`		`- names = append(names, cfg.Enable...)`
	`94`	`+ names := append([]string{}, cfg.Enable...)`
`96`	`95`	`names = append(names, cfg.Disable...)`
`97`	`96`
`98`	`97`	`for _, name := range names {`
Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,7 @@ func (m *MockLog) SetLevel(level LogLevel) {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`func (m MockLog) OnFatalf(format string, args ...any) MockLog {`
`50`		`- arguments := []any{format}`
`51`		`- arguments = append(arguments, args...)`
	`50`	`+ arguments := append([]any{format}, args...)`
`52`	`51`
`53`	`52`	`m.On("Fatalf", arguments...)`
`54`	`53`