From 61e577bf803300bf0862bb5e7f9c5b4eb72a5555 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 9 Feb 2024 01:24:10 +0100 Subject: [PATCH 1/3] docs: Clarify `govet` description --- pkg/golinters/govet.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/golinters/govet.go b/pkg/golinters/govet.go index a0d33835dfad..4aebba56e603 100644 --- a/pkg/golinters/govet.go +++ b/pkg/golinters/govet.go @@ -145,7 +145,8 @@ func NewGovet(settings *config.GovetSettings) *goanalysis.Linter { return goanalysis.NewLinter( "govet", "Vet examines Go source code and reports suspicious constructs, "+ - "such as Printf calls whose arguments do not align with the format string", + "such as Printf calls whose arguments do not align with the format string. "+ + "This is the same analysis as the 'go vet' tool", analyzersFromConfig(settings), conf, ).WithLoadMode(goanalysis.LoadModeTypesInfo) From 05cb87ee3bcb4c3c2a9a5f5753b25641748ba7c8 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 9 Feb 2024 10:22:08 +0100 Subject: [PATCH 2/3] New wording --- pkg/golinters/govet.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/golinters/govet.go b/pkg/golinters/govet.go index 4aebba56e603..d3fc01b9cb33 100644 --- a/pkg/golinters/govet.go +++ b/pkg/golinters/govet.go @@ -146,7 +146,7 @@ func NewGovet(settings *config.GovetSettings) *goanalysis.Linter { "govet", "Vet examines Go source code and reports suspicious constructs, "+ "such as Printf calls whose arguments do not align with the format string. "+ - "This is the same analysis as the 'go vet' tool", + "It is roughly the same as 'go vet' and uses its passes.", analyzersFromConfig(settings), conf, ).WithLoadMode(goanalysis.LoadModeTypesInfo) From 4567c929ebd454dae17e83c85d50b9eabc67c8bf Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Thu, 15 Feb 2024 20:30:50 +0100 Subject: [PATCH 3/3] review --- pkg/golinters/govet.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/golinters/govet.go b/pkg/golinters/govet.go index d3fc01b9cb33..e2c7d2df50d9 100644 --- a/pkg/golinters/govet.go +++ b/pkg/golinters/govet.go @@ -144,8 +144,7 @@ func NewGovet(settings *config.GovetSettings) *goanalysis.Linter { return goanalysis.NewLinter( "govet", - "Vet examines Go source code and reports suspicious constructs, "+ - "such as Printf calls whose arguments do not align with the format string. "+ + "Vet examines Go source code and reports suspicious constructs. "+ "It is roughly the same as 'go vet' and uses its passes.", analyzersFromConfig(settings), conf,