Skip to content

Commit 7ae6968

Browse files
Merge pull request #41 from iamcharankumar/fb_screensize
Removed maximized start.
2 parents 2cefc56 + e334ccb commit 7ae6968

File tree

4 files changed

+4
-19
lines changed

4 files changed

+4
-19
lines changed

src/main/java/io/swaglabs/portal/qa/browsermanager/ChromeBrowser.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,12 @@
66
import com.microsoft.playwright.Playwright;
77
import io.swaglabs.portal.qa.constants.WebPortalConstants;
88

9-
import java.util.Collections;
10-
119
public class ChromeBrowser implements IBrowser {
1210

1311
@Override
1412
public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
1513
return playwright.chromium().launch(new BrowserType.LaunchOptions()
16-
.setHeadless(isHeadless)
17-
.setArgs(Collections.singletonList(WebPortalConstants.MAXIMIZE_WINDOW)))
14+
.setHeadless(isHeadless))
1815
.newContext(new Browser.NewContextOptions()
1916
.setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT));
2017
}

src/main/java/io/swaglabs/portal/qa/browsermanager/FirefoxBrowser.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,11 @@
66
import com.microsoft.playwright.Playwright;
77
import io.swaglabs.portal.qa.constants.WebPortalConstants;
88

9-
import java.util.Collections;
10-
119
public class FirefoxBrowser implements IBrowser {
1210
@Override
1311
public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
1412
return playwright.firefox().launch(new BrowserType.LaunchOptions()
15-
.setHeadless(isHeadless)
16-
.setArgs(Collections.singletonList(WebPortalConstants.MAXIMIZE_WINDOW)))
13+
.setHeadless(isHeadless))
1714
.newContext(new Browser.NewContextOptions()
1815
.setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT));
1916
}

src/main/java/io/swaglabs/portal/qa/browsermanager/MsEdgeBrowser.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,11 @@
66
import com.microsoft.playwright.Playwright;
77
import io.swaglabs.portal.qa.constants.WebPortalConstants;
88

9-
import java.util.List;
10-
119
public class MsEdgeBrowser implements IBrowser {
1210
@Override
1311
public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
1412
return playwright.chromium().launch(new BrowserType.LaunchOptions()
15-
.setHeadless(isHeadless)
16-
.setArgs(isHeadless
17-
? List.of("--headless=new", WebPortalConstants.MAXIMIZE_WINDOW)
18-
: List.of(WebPortalConstants.MAXIMIZE_WINDOW))
19-
.setChannel(BrowserName.MS_EDGE.getBrowserType()))
13+
.setHeadless(isHeadless).setChannel(BrowserName.MS_EDGE.getBrowserType()))
2014
.newContext(new Browser.NewContextOptions()
2115
.setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT));
2216
}

src/main/java/io/swaglabs/portal/qa/browsermanager/WebkitBrowser.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,11 @@
66
import com.microsoft.playwright.Playwright;
77
import io.swaglabs.portal.qa.constants.WebPortalConstants;
88

9-
import java.util.Collections;
10-
119
public class WebkitBrowser implements IBrowser {
1210
@Override
1311
public BrowserContext createSession(Playwright playwright, boolean isHeadless) {
1412
return playwright.webkit().launch(new BrowserType.LaunchOptions()
15-
.setHeadless(isHeadless)
16-
.setArgs(Collections.singletonList(WebPortalConstants.MAXIMIZE_WINDOW)))
13+
.setHeadless(isHeadless))
1714
.newContext(new Browser.NewContextOptions()
1815
.setViewportSize(WebPortalConstants.SCREEN_WIDTH, WebPortalConstants.SCREEN_HEIGHT));
1916
}

0 commit comments

Comments
 (0)