Skip to content

Commit ba76e28

Browse files
authored
Merge pull request #1096 from mathbunnyru/asalikhov/ubuntu_focal
Start using Ubuntu 20.04 (focal)
2 parents dd2087c + 3923ac6 commit ba76e28

File tree

4 files changed

+20
-28
lines changed

4 files changed

+20
-28
lines changed

base-notebook/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Copyright (c) Jupyter Development Team.
22
# Distributed under the terms of the Modified BSD License.
33

4-
# Ubuntu 18.04 (bionic)
5-
# https://hub.docker.com/_/ubuntu/?tab=tags&name=bionic
4+
# Ubuntu 20.04 (focal)
5+
# https://hub.docker.com/_/ubuntu/?tab=tags&name=focal
66
# OS/ARCH: linux/amd64
7-
ARG ROOT_CONTAINER=ubuntu:bionic-20200403@sha256:b58746c8a89938b8c9f5b77de3b8cf1fe78210c696ab03a1442e235eea65d84f
7+
ARG ROOT_CONTAINER=ubuntu:focal-20200423@sha256:238e696992ba9913d24cfc3727034985abd136e08ee3067982401acdc30cbf3f
88
ARG BASE_CONTAINER=$ROOT_CONTAINER
99
FROM $BASE_CONTAINER
1010

docs/using/recipes.md

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -259,38 +259,30 @@ RUN rm /etc/dpkg/dpkg.cfg.d/excludes \
259259
&& apt-get clean \
260260
&& rm -rf /var/lib/apt/lists/*
261261

262-
# Workaround for a mandb bug, should be fixed in mandb > 2.8.5
263-
# https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=8197d7824f814c5d4b992b4c8730b5b0f7ec589a
264-
RUN echo "MANPATH_MAP ${CONDA_DIR}/bin ${CONDA_DIR}/man" >> /etc/manpath.config \
265-
&& echo "MANPATH_MAP ${CONDA_DIR}/bin ${CONDA_DIR}/share/man" >> /etc/manpath.config \
266-
&& mandb
267-
268262
USER $NB_UID
269263
```
270264

271265
Adding the documentation on top of an existing singleuser image wastes a lot of space and requires
272266
reinstalling every system package, which can take additional time and bandwidth; the
273267
`datascience-notebook` image has been shown to grow by almost 3GB when adding manapages in this way.
274-
Enabling manpages in the base Ubuntu layer prevents this container bloat:
268+
Enabling manpages in the base Ubuntu layer prevents this container bloat.
269+
Just use previous `Dockerfile` with original ubuntu image as your base container:
275270

276-
```Dockerfile
277-
# Ubuntu 18.04 (bionic) from 2018-05-26
278-
# https://github.com/docker-library/official-images/commit/aac6a45b9eb2bffb8102353c350d341a410fb169
279-
ARG BASE_CONTAINER=ubuntu:bionic-20180526@sha256:c8c275751219dadad8fa56b3ac41ca6cb22219ff117ca98fe82b42f24e1ba64e
280-
FROM $BASE_CONTAINER
281-
282-
ENV DEBIAN_FRONTEND noninteractive
283-
# Remove the manpage blacklist, install man, install docs
284-
RUN rm /etc/dpkg/dpkg.cfg.d/excludes \
285-
&& apt-get update \
286-
&& dpkg -l | grep ^ii | cut -d' ' -f3 | xargs apt-get install -yq --no-install-recommends --reinstall man \
287-
&& apt-get clean \
288-
&& rm -rf /var/lib/apt/lists/*
271+
```dockerfile
272+
# Ubuntu 20.04 (focal) from 2020-04-23
273+
# https://github.com/docker-library/official-images/commit/4475094895093bcc29055409494cce1e11b52f94
274+
ARG BASE_CONTAINER=ubuntu:focal-20200423@sha256:238e696992ba9913d24cfc3727034985abd136e08ee3067982401acdc30cbf3f
275+
```
289276

290-
# Workaround for a mandb bug, should be fixed in mandb > 2.8.5
277+
For Ubuntu 18.04 (bionic) and earlier, you may also require to workaround for a mandb bug, which was fixed in mandb >= 2.8.6.1:
278+
```dockerfile
291279
# https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=8197d7824f814c5d4b992b4c8730b5b0f7ec589a
292-
RUN echo "MANPATH_MAP /opt/conda/bin /opt/conda/man" >> /etc/manpath.config \
293-
&& echo "MANPATH_MAP /opt/conda/bin /opt/conda/share/man" >> /etc/manpath.config
280+
# http://launchpadlibrarian.net/435841763/man-db_2.8.5-2_2.8.6-1.diff.gz
281+
282+
RUN echo "MANPATH_MAP ${CONDA_DIR}/bin ${CONDA_DIR}/man" >> /etc/manpath.config \
283+
&& echo "MANPATH_MAP ${CONDA_DIR}/bin ${CONDA_DIR}/share/man" >> /etc/manpath.config \
284+
&& mandb
285+
294286
```
295287

296288
Be sure to check the current base image in `base-notebook` before building.

examples/docker-compose/bin/letsencrypt.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,6 @@ docker run --rm -it \
4343
# directory so that the FQDN doesn't have to be known later.
4444
docker run --rm -it \
4545
-v $SECRETS_VOLUME:/etc/letsencrypt \
46-
ubuntu:18.04 \
46+
ubuntu:20.04 \
4747
bash -c "ln -s /etc/letsencrypt/live/$FQDN/* /etc/letsencrypt/ && \
4848
find /etc/letsencrypt -type d -exec chmod 755 {} +"

minimal-notebook/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ RUN apt-get update && apt-get install -yq --no-install-recommends \
2424
# ---- nbconvert dependencies ----
2525
texlive-xetex \
2626
texlive-fonts-recommended \
27-
texlive-generic-recommended \
27+
texlive-plain-generic \
2828
# Optional dependency
2929
texlive-fonts-extra \
3030
# ----

0 commit comments

Comments
 (0)