Skip to content

Commit 5a5696f

Browse files
kkm000danpovey
authored andcommitted
[build] Some fixes to Makefiles (#3088)
clang is unhappy with '-rdynamic' in compile-only step, and the switch is really unnecessary. Also, the default location for MKL 64-bit libraries is intel64/. The em64t/ was explained already obsolete by an Intel rep in 2010: https://software.intel.com/en-us/forums/intel-math-kernel-library/topic/285973
1 parent 1209c07 commit 5a5696f

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/makefiles/cuda_64bit.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ ifndef CUDATKDIR
55
$(error CUDATKDIR not defined.)
66
endif
77

8-
CXXFLAGS += -DHAVE_CUDA -I$(CUDATKDIR)/include -fPIC -pthread -isystem $(OPENFSTINC) -rdynamic
8+
CXXFLAGS += -DHAVE_CUDA -I$(CUDATKDIR)/include -fPIC -pthread -isystem $(OPENFSTINC)
99

1010
CUDA_INCLUDE= -I$(CUDATKDIR)/include -I$(CUBROOT)
1111
CUDA_FLAGS = --machine 64 -DHAVE_CUDA \
@@ -14,4 +14,4 @@ CUDA_FLAGS = --machine 64 -DHAVE_CUDA \
1414
--verbose -Xcompiler "$(CXXFLAGS)"
1515

1616
CUDA_LDFLAGS += -L$(CUDATKDIR)/lib64 -Wl,-rpath,$(CUDATKDIR)/lib64
17-
CUDA_LDLIBS += -lcublas -lcusparse -lcudart -lcurand -lnvToolsExt #LDLIBS : The libs are loaded later than static libs in implicit rule
17+
CUDA_LDLIBS += -lcublas -lcusparse -lcudart -lcurand -lnvToolsExt #LDLIBS : The .so libs are loaded later than static libs in implicit rule

src/makefiles/default_rules.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ valgrind: .valgrind
125125
#buid up dependency commands
126126
CC_SRCS=$(wildcard *.cc)
127127
#check if files exist to run dependency commands on
128-
ifneq ($(CC_SRCS),)
128+
ifneq ($(CC_SRCS),)
129129
CC_DEP_COMMAND=$(CXX) -M $(CXXFLAGS) $(CC_SRCS)
130130
endif
131131

src/makefiles/linux_x86_64_mkl.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ ifndef MKLROOT
2222
$(error MKLROOT not defined.)
2323
endif
2424

25-
MKLLIB ?= $(MKLROOT)/lib/em64t
25+
MKLLIB ?= $(MKLROOT)/lib/intel64
2626

2727
CXXFLAGS = -std=c++11 -I.. -isystem $(OPENFSTINC) -O1 $(EXTRA_CXXFLAGS) \
2828
-Wall -Wno-sign-compare -Wno-unused-local-typedefs \

0 commit comments

Comments
 (0)