Skip to content

Commit 0f960a6

Browse files
lskramarovlskramarov
committed
fix: after review
1 parent e0c08c1 commit 0f960a6

File tree

9 files changed

+19
-46
lines changed

9 files changed

+19
-46
lines changed

‎packages/components/core/pop-up/pop-up-trigger.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ import { PopUpPlacements, PopUpTriggers } from './constants';
3636

3737
@Directive()
3838
export abstract class KbqPopUpTrigger<T> implements OnInit, OnDestroy {
39-
protected overlay: Overlay = inject(Overlay);
40-
protected elementRef: ElementRef = inject(ElementRef);
41-
protected ngZone: NgZone = inject(NgZone);
42-
protected scrollDispatcher: ScrollDispatcher = inject(ScrollDispatcher);
43-
protected hostView: ViewContainerRef = inject(ViewContainerRef);
44-
protected direction = inject(Directionality, { optional: true });
39+
protected readonly overlay: Overlay = inject(Overlay);
40+
protected readonly elementRef: ElementRef = inject(ElementRef);
41+
protected readonly ngZone: NgZone = inject(NgZone);
42+
protected readonly scrollDispatcher: ScrollDispatcher = inject(ScrollDispatcher);
43+
protected readonly hostView: ViewContainerRef = inject(ViewContainerRef);
44+
protected readonly direction = inject(Directionality, { optional: true });
4545

4646
protected abstract scrollStrategy: () => ScrollStrategy;
4747

‎packages/components/core/pop-up/pop-up.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import { PopUpVisibility } from './constants';
55

66
@Directive()
77
export abstract class KbqPopUp implements OnDestroy {
8-
protected renderer: Renderer2 = inject(Renderer2);
9-
protected changeDetectorRef: ChangeDetectorRef = inject(ChangeDetectorRef);
8+
protected readonly renderer: Renderer2 = inject(Renderer2);
9+
protected readonly changeDetectorRef: ChangeDetectorRef = inject(ChangeDetectorRef);
1010

1111
header: string | TemplateRef<any>;
1212
content: string | TemplateRef<any>;

‎packages/components/ellipsis-center/ellipsis-center.directive.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { AfterViewInit, Directive, Input, NgModule, OnDestroy, OnInit, Renderer2 } from '@angular/core';
1+
import { AfterViewInit, Directive, inject, Input, NgModule, OnDestroy, OnInit, Renderer2 } from '@angular/core';
22
import { KbqTooltipTrigger } from '@koobiq/components/tooltip';
33
import { Subject, Subscription } from 'rxjs';
44
import { debounceTime } from 'rxjs/operators';
@@ -13,6 +13,8 @@ const MIN_VISIBLE_LENGTH = 50;
1313
}
1414
})
1515
export class KbqEllipsisCenterDirective extends KbqTooltipTrigger implements OnInit, AfterViewInit, OnDestroy {
16+
private renderer: Renderer2 = inject(Renderer2);
17+
1618
@Input() set kbqEllipsisCenter(value: string) {
1719
this._kbqEllipsisCenter = value;
1820
this.refresh();
@@ -28,10 +30,6 @@ export class KbqEllipsisCenterDirective extends KbqTooltipTrigger implements OnI
2830

2931
private readonly debounceInterval: number = 50;
3032

31-
constructor(private renderer: Renderer2) {
32-
super();
33-
}
34-
3533
override ngOnInit(): void {
3634
super.ngOnInit();
3735
this.content = this._kbqEllipsisCenter;

‎packages/components/popover/popover-confirm.component.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ export class KbqPopoverConfirmComponent extends KbqPopoverComponent {
3232
confirmButtonText: string;
3333

3434
confirmText: string;
35-
36-
constructor() {
37-
super();
38-
}
3935
}
4036

4137
@Directive({

‎packages/components/popover/popover.component.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,6 @@ export class KbqPopoverComponent extends KbqPopUp implements AfterViewInit {
6666
isContentTopOverflow: boolean = false;
6767
isContentBottomOverflow: boolean = false;
6868

69-
constructor() {
70-
super();
71-
}
72-
7369
ngAfterViewInit() {
7470
if (!this.popoverContent) return;
7571

@@ -318,10 +314,6 @@ export class KbqPopoverTrigger extends KbqPopUpTrigger<KbqPopoverComponent> impl
318314
};
319315
}
320316

321-
constructor() {
322-
super();
323-
}
324-
325317
ngAfterContentInit(): void {
326318
if (this.closeOnScroll === null) {
327319
this.scrollDispatcher.scrolled().subscribe((scrollable: CdkScrollable | void) => {

‎packages/components/tooltip/tooltip.component.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -328,10 +328,6 @@ export class KbqWarningTooltipTrigger extends KbqTooltipTrigger {
328328
}
329329

330330
protected modifier: TooltipModifier = TooltipModifier.Warning;
331-
332-
constructor() {
333-
super();
334-
}
335331
}
336332

337333
@Directive({
@@ -371,10 +367,6 @@ export class KbqExtendedTooltipTrigger extends KbqTooltipTrigger {
371367

372368
protected modifier: TooltipModifier = TooltipModifier.Extended;
373369

374-
constructor() {
375-
super();
376-
}
377-
378370
updateData() {
379371
if (!this.instance) {
380372
return;

‎tools/public_api_guard/components/core.api.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1353,7 +1353,7 @@ export abstract class KbqPopUp implements OnDestroy {
13531353
// (undocumented)
13541354
arrow: boolean;
13551355
// (undocumented)
1356-
protected changeDetectorRef: ChangeDetectorRef;
1356+
protected readonly changeDetectorRef: ChangeDetectorRef;
13571357
// (undocumented)
13581358
classMap: {};
13591359
// (undocumented)
@@ -1385,7 +1385,7 @@ export abstract class KbqPopUp implements OnDestroy {
13851385
// (undocumented)
13861386
protected prefix: string;
13871387
// (undocumented)
1388-
protected renderer: Renderer2;
1388+
protected readonly renderer: Renderer2;
13891389
// (undocumented)
13901390
show(delay: number): void;
13911391
// (undocumented)
@@ -1428,13 +1428,13 @@ export abstract class KbqPopUpTrigger<T> implements OnInit, OnDestroy {
14281428
// (undocumented)
14291429
detach: () => void;
14301430
// (undocumented)
1431-
protected direction: Directionality | null;
1431+
protected readonly direction: Directionality | null;
14321432
// (undocumented)
14331433
abstract disabled: boolean;
14341434
// (undocumented)
14351435
protected _disabled: boolean;
14361436
// (undocumented)
1437-
protected elementRef: ElementRef;
1437+
protected readonly elementRef: ElementRef;
14381438
// (undocumented)
14391439
enterDelay: number;
14401440
// (undocumented)
@@ -1450,7 +1450,7 @@ export abstract class KbqPopUpTrigger<T> implements OnInit, OnDestroy {
14501450
// (undocumented)
14511451
hide(delay?: number): void;
14521452
// (undocumented)
1453-
protected hostView: ViewContainerRef;
1453+
protected readonly hostView: ViewContainerRef;
14541454
// (undocumented)
14551455
initListeners(): void;
14561456
// (undocumented)
@@ -1466,13 +1466,13 @@ export abstract class KbqPopUpTrigger<T> implements OnInit, OnDestroy {
14661466
// (undocumented)
14671467
ngOnInit(): void;
14681468
// (undocumented)
1469-
protected ngZone: NgZone;
1469+
protected readonly ngZone: NgZone;
14701470
// (undocumented)
14711471
onPositionChange: ($event: ConnectedOverlayPositionChange) => void;
14721472
// (undocumented)
14731473
protected abstract originSelector: string;
14741474
// (undocumented)
1475-
protected overlay: Overlay;
1475+
protected readonly overlay: Overlay;
14761476
// (undocumented)
14771477
protected abstract overlayConfig: OverlayConfig;
14781478
// (undocumented)
@@ -1486,7 +1486,7 @@ export abstract class KbqPopUpTrigger<T> implements OnInit, OnDestroy {
14861486
// (undocumented)
14871487
protected portal: ComponentPortal<T>;
14881488
// (undocumented)
1489-
protected scrollDispatcher: ScrollDispatcher;
1489+
protected readonly scrollDispatcher: ScrollDispatcher;
14901490
// (undocumented)
14911491
protected abstract scrollStrategy: () => ScrollStrategy;
14921492
// (undocumented)

‎tools/public_api_guard/components/popover.api.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ export const kbqPopoverAnimations: {
5757

5858
// @public (undocumented)
5959
export class KbqPopoverComponent extends KbqPopUp implements AfterViewInit {
60-
constructor();
6160
// (undocumented)
6261
checkContentOverflow(contentElement: HTMLElement): void;
6362
// (undocumented)
@@ -94,7 +93,6 @@ export class KbqPopoverComponent extends KbqPopUp implements AfterViewInit {
9493

9594
// @public (undocumented)
9695
export class KbqPopoverConfirmComponent extends KbqPopoverComponent {
97-
constructor();
9896
// (undocumented)
9997
confirmButtonText: string;
10098
// (undocumented)
@@ -148,7 +146,6 @@ export function kbqPopoverScrollStrategyFactory(overlay: Overlay): () => ScrollS
148146

149147
// @public (undocumented)
150148
export class KbqPopoverTrigger extends KbqPopUpTrigger<KbqPopoverComponent> implements AfterContentInit {
151-
constructor();
152149
// (undocumented)
153150
backdropClass: string;
154151
get closeOnScroll(): boolean | null;

‎tools/public_api_guard/components/tooltip.api.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ export const KBQ_TOOLTIP_SCROLL_STRATEGY_FACTORY_PROVIDER: {
4646

4747
// @public (undocumented)
4848
export class KbqExtendedTooltipTrigger extends KbqTooltipTrigger {
49-
constructor();
5049
// (undocumented)
5150
get content(): string | TemplateRef<any>;
5251
set content(content: string | TemplateRef<any>);
@@ -175,7 +174,6 @@ export class KbqTooltipTrigger extends KbqPopUpTrigger<KbqTooltipComponent> impl
175174

176175
// @public (undocumented)
177176
export class KbqWarningTooltipTrigger extends KbqTooltipTrigger {
178-
constructor();
179177
// (undocumented)
180178
get content(): string | TemplateRef<any>;
181179
set content(content: string | TemplateRef<any>);

0 commit comments

Comments
 (0)