fix: after review

Author: lskramarov

packages/components/filter-bar/pipes/base-pipe.ts

@@ -2,6 +2,7 @@ import {
     afterNextRender,
     AfterViewInit,
     ChangeDetectorRef,
+    DestroyRef,
     Directive,
     ElementRef,
     inject,
@@ -45,6 +46,8 @@ export abstract class KbqBasePipe<V> implements AfterViewInit {
     protected readonly filterBar = inject(KbqFilterBar, { optional: true });
     /** @docs-private */
     protected readonly changeDetectorRef = inject(ChangeDetectorRef);
+    /** @docs-private */
+    protected readonly destroyRef = inject(DestroyRef);
 
     /** values to select from the pipe template */
     protected values;

packages/components/filter-bar/pipes/pipe-multi-select.ts

@@ -9,6 +9,7 @@ import {
     ViewChildren,
     ViewEncapsulation
 } from '@angular/core';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { FormsModule, ReactiveFormsModule, UntypedFormControl } from '@angular/forms';
 import { KbqBadgeModule } from '@koobiq/components/badge';
 import { KbqButtonModule } from '@koobiq/components/button';
@@ -115,7 +116,9 @@ export class KbqPipeMultiSelectComponent extends KbqBasePipe<KbqSelectValue[]> i
     override ngAfterViewInit() {
         super.ngAfterViewInit();
 
-        this.select.closedStream.subscribe(() => this.filterBar?.onClosePipe.next(this.data));
+        this.select.closedStream
+            .pipe(takeUntilDestroyed(this.destroyRef))
+            .subscribe(() => this.filterBar?.onClosePipe.next(this.data));
     }
 
     /** @docs-private */

packages/components/filter-bar/pipes/pipe-select.ts

@@ -1,5 +1,6 @@
 import { AsyncPipe, NgClass, NgTemplateOutlet } from '@angular/common';
 import { AfterViewInit, ChangeDetectionStrategy, Component, OnInit, ViewChild, ViewEncapsulation } from '@angular/core';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { ReactiveFormsModule, UntypedFormControl } from '@angular/forms';
 import { KbqButtonModule } from '@koobiq/components/button';
 import { KbqDividerModule } from '@koobiq/components/divider';
@@ -78,7 +79,9 @@ export class KbqPipeSelectComponent extends KbqBasePipe<KbqSelectValue> implemen
     override ngAfterViewInit() {
         super.ngAfterViewInit();
 
-        this.select.closedStream.subscribe(() => this.filterBar?.onClosePipe.next(this.data));
+        this.select.closedStream
+            .pipe(takeUntilDestroyed(this.destroyRef))
+            .subscribe(() => this.filterBar?.onClosePipe.next(this.data));
     }
 
     onSelect(item: KbqSelectValue) {

tools/public_api_guard/components/filter-bar.api.md

@@ -8,6 +8,7 @@ import { AfterContentInit } from '@angular/core';
 import { AfterViewInit } from '@angular/core';
 import { BehaviorSubject } from 'rxjs';
 import { ChangeDetectorRef } from '@angular/core';
+import { DestroyRef } from '@angular/core';
 import { ElementRef } from '@angular/core';
 import { EventEmitter } from '@angular/core';
 import { FormControl } from '@angular/forms';
@@ -102,6 +103,7 @@ export abstract class KbqBasePipe<V> implements AfterViewInit {
     constructor();
     protected readonly changeDetectorRef: ChangeDetectorRef;
     readonly data: KbqPipeData<V>;
+    protected readonly destroyRef: DestroyRef;
     protected readonly filterBar: KbqFilterBar | null;
     get isEmpty(): boolean;
     isMac: boolean;