feat(tabs): new bordered tabs (#DS-2904) #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit b3b9a89): https://koobiq-next--prs-328-1v9tcqp1.web.app (expires Sun, 06 Oct 2024 11:56:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
…nto feat/DS-2904 * 'feat/DS-2904' of github.com:koobiq/angular-components: (31 commits) feat(docs): removed core-js polyfills (#325) fix: updated stackblitz files (#323) feat: updated angular dependencies to 18.2.6, updated stackblitz configs (#322) chore: updated components tokens chore(docs): fixed stackblitz examples chore(ci): updated firebase config chore: fixed deploy for docs stable 18.x chore: bump version to 18.0.0 w/ changelog chore: build tokens for docs and upd chalk to 4.x (#319) feat(visual,docs): moved from sass vars to css-vars (#296) fix(navbar): kbq-vertical-navbar does not apply design-tokens (#DS-2911) (#318) chore: fixed docs examples (#315) feat(scrollbar): updated docs and migrated to standalone (#DS-2899) (#307) feat: updated CI dependencies (#313) fix(list): multiple selection by keyboard on macos (#DS-2908) (#309) chore: fixed ci after angular 18 migration (#312) chore: fixed firebase target for docs dist chore: inc budget for docs chore: build component and docs tokens chore: fixed schematic build and updated schematics to 18.2 ...
* main: fix: sandbox polyfills and tsconfigs (#330)
|
также в рамках этой задачи пофиксил стили для dev-примеров и stackblitz (#DS-2925) |
lskramarov
reviewed
Oct 1, 2024
| @@ -71,13 +71,17 @@ export class KbqTabLabelWrapper extends KbqTabLabelWrapperMixinBase implements C | |||
| const COMMENT_NODE = 8; | |||
|
|
|||
| if (firstIconElement.nextSibling && firstIconElement.nextSibling.nodeType !== COMMENT_NODE) { | |||
| this.elementRef.nativeElement.classList.add('kbq-tab-label_with-icon-left'); | |||
There was a problem hiding this comment.
Ниже класс добавляется через renderer, почему здесь не сделал так же ?
packages/components-dev/main.scss
Outdated
| @@ -3,6 +3,9 @@ | |||
| @use '../components/core/styles/theming/prebuilt/light-theme'; | |||
| //@use '../components/core/styles/theming/prebuilt/dark-theme'; | |||
|
|
|||
| @use 'apps/docs/src/styles/koobiq/default-theme/css-tokens-light.css'; | |||
There was a problem hiding this comment.
Строки выше:
@use '../components/core/styles/theming/prebuilt/light-theme'; //@use '../components/core/styles/theming/prebuilt/dark-theme';
еще нужны ?
There was a problem hiding this comment.
а что будет если подключить light-theme и css-tokens-dark.css ?
There was a problem hiding this comment.
не будет доступа к переменным, которые используются в light-theme и стили не применятся
artembelik
reviewed
Oct 1, 2024
| @@ -215,11 +222,13 @@ export class KbqTabGroup | |||
| elementRef: ElementRef, | |||
| private readonly changeDetectorRef: ChangeDetectorRef, | |||
| @Attribute('vertical') vertical: string, | |||
| @Attribute('underlined') underlined: string, | |||
There was a problem hiding this comment.
а почему используются атрибуты а не @Input({ transform: booleanAttribute }) ?
lskramarov
approved these changes
Oct 1, 2024
artembelik
approved these changes
Oct 1, 2024
sk8knut
added a commit
that referenced
this pull request
Oct 1, 2024
* main: fix(docs): menu tab icon fixed (#DS-2926) (#331) feat(tabs): new bordered tabs (#DS-2904) (#328) feat(tooltip): migrated to standalone (#334) feat(icon): migrated to standalone (#333) fix(tree): mouse click selection generates extra event (#DS-2900) (#332) feat(tooltip): added parameter kbqRelativeToPointer (#DS-2864) (#326) fix: sandbox polyfills and tsconfigs (#330) # Conflicts: # packages/components/tabs/tabs.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.