-
Notifications
You must be signed in to change notification settings - Fork 3
fix(tree): mouse click selection generates extra event (#DS-2900) #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 42d2654): https://koobiq-next--prs-332-ovav4cqh.web.app (expires Sun, 06 Oct 2024 06:13:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
artembelik
reviewed
Sep 30, 2024
@@ -296,6 +296,21 @@ export class KbqTreeSelect | |||
); | |||
}) as Observable<KbqTreeSelectChange>; | |||
|
|||
/** Combined stream of all of the child options' userInteraction events. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/** Combined stream of all of the child options' userInteraction events. */ | |
/** Combined stream of all of the child options userInteraction events. */ |
artembelik
approved these changes
Sep 30, 2024
pimenovoleg
approved these changes
Sep 30, 2024
sk8knut
approved these changes
Sep 30, 2024
lskramarov
added a commit
that referenced
this pull request
Oct 1, 2024
lskramarov
added a commit
that referenced
this pull request
Oct 1, 2024
sk8knut
added a commit
that referenced
this pull request
Oct 1, 2024
* main: fix(docs): menu tab icon fixed (#DS-2926) (#331) feat(tabs): new bordered tabs (#DS-2904) (#328) feat(tooltip): migrated to standalone (#334) feat(icon): migrated to standalone (#333) fix(tree): mouse click selection generates extra event (#DS-2900) (#332) feat(tooltip): added parameter kbqRelativeToPointer (#DS-2864) (#326) fix: sandbox polyfills and tsconfigs (#330) # Conflicts: # packages/components/tabs/tabs.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.