Skip to content

feat(icons): new icons pack (#DS-2567) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Sep 25, 2024
Merged

feat(icons): new icons pack (#DS-2567) #86

merged 29 commits into from
Sep 25, 2024

Conversation

NikGurev
Copy link
Contributor

@NikGurev NikGurev commented Jun 13, 2024 •
edited
Loading

Summary

Implemented new icons pack

List of notable changes:

  • added: migration script
  • updated: icons prefixes to show new icons pack

BREAKING CHANGES: Some icons changed names, changed sizes

@NikGurev NikGurev added the enhancement New feature or request label Jun 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit cbf6fc7):

https://koobiq-next--prs-86-bu6wzojn.web.app

(expires Sat, 28 Sep 2024 11:05:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@NikGurev NikGurev marked this pull request as ready for review June 19, 2024 14:42
@NikGurev NikGurev requested a review from lskramarov as a code owner June 19, 2024 14:42
@NikGurev NikGurev requested review from pimenovoleg and rmnturov June 19, 2024 14:42
@NikGurev NikGurev self-assigned this Jun 19, 2024
@rmnturov
Copy link
Contributor

Эта версия работает как демонстрация текущего состояния нового набора иконок. Видно, что иконки надо дорисовывать. Я бы не хотел, чтобы мы разрешали использовать Кубиком с таким недоработанным паком. Дизайнеры дорисовывают иконки, а работа Никиты помогла выявить баги и места для улучшений.

@NikGurev NikGurev marked this pull request as draft June 25, 2024 08:14
@NikGurev NikGurev force-pushed the feat/new-icons branch 2 times, most recently from 6c9793d to 743dc9d Compare July 31, 2024 10:12
@NikGurev NikGurev marked this pull request as ready for review September 16, 2024 16:54
@NikGurev
Copy link
Contributor Author

Связанная задача: koobiq/design-tokens#47

@vitalyozza
Copy link
Contributor

vitalyozza commented Sep 17, 2024 •
edited
Loading

@NikGurev на странице с Checkbox-ом нужно использовать иконки меньше, чем текущие в ветке.

<img width="2055" alt="image" src="https://github.com/user-attachments/assets/0501f132-bcf6-476e-a974-76e42ae1b874”>

Верные иконки отображены тут

@vitalyozza
Copy link
Contributor

Еще нашел пару артефактов на странице File Upload в конце:

Screenshot 2024-09-17 at 14 14 44

@vitalyozza
Copy link
Contributor

Также, есть момент с появлением иконки на странице с Overlay
image

@vitalyozza
Copy link
Contributor

vitalyozza commented Sep 17, 2024 •
edited
Loading

Еще нашел на странице Sidepanel иконки, которых не было в доках ранее:
image

Такая же иконка и на странице Tooltip появляется у секции “Вариации” в самом начале.

@NikGurev NikGurev changed the title feat(icons): new icons pack test feat(icons): new icons pack (#DS-2567) Sep 17, 2024
@NikGurev NikGurev force-pushed the feat/new-icons branch 2 times, most recently from 4f3bb7a to 364c03e Compare September 18, 2024 09:14
NikGurev and others added 25 commits September 23, 2024 12:02
@NikGurev
feat(chore): updated icons pack script without icons migration, updat…
7b39ec2 
…ed icons version
@NikGurev
feat(chore): updated icons replacement config
3bb4786
@NikGurev
feat(chore): updated icons replacement config
017d415
@NikGurev
feat(chore): updated koobiq/icons version
6788c1f
@NikGurev
feat(core): icons migration
4f61f4d 
BREAKING CHANGES: changed icons in components
@NikGurev
feat(chore): skip test for UX review
b2c7fbf
@NikGurev
feat(chore): updated icons pack prefixes
cdac60f
@rmnturov @NikGurev
fix(empty-state): changed button label
febbf3c
@NikGurev
feat(docs): updated docs
58ce1f1
@rmnturov @NikGurev
fix(empty-state): change icon (plus-s → plus)
d6a0fdd
@rmnturov @NikGurev
fix(navbar): changed icons in docs article
7d64e85
@rmnturov @NikGurev
feat(button): changed icon in docs (info-circle → plus)
8ff5239 
Плюсик — самая частая иконка, поэтому лучше её и показать в примере
@NikGurev
feat(docs): updated tokens values
f6fa914
@NikGurev
feat(docs): changed missing icon text
e55c909
@NikGurev
feat(alert): revert unnecessary changes
e997ac9
@NikGurev
feat(chore): updated tokens version
c57d4ab
@rmnturov @NikGurev
fix(docs): delete mc alerts from tooltip article
3b22fcf
@rmnturov @NikGurev
fix(docs): removed alert blocks from articles
0441904 
also add words to cspell config
@rmnturov @NikGurev
feat(docs): format tooltip.md
1a0a9b0
@NikGurev
feat(docs): ux fixes applied
9ba1a74
@NikGurev
feat(docs): updated icon colors
c443a35
@NikGurev
fix(checkbox,form-field): fixed checkmark icon
1f84858
@NikGurev
fix(cli): replacement script re improved
d27fb1c
@NikGurev
fix(docs,icon): updated text
b895993
@NikGurev
fix(docs,icon): updated link
e1bb849
@pimenovoleg pimenovoleg merged commit b392539 into main Sep 25, 2024
3 checks passed
@pimenovoleg pimenovoleg deleted the feat/new-icons branch September 25, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimenovoleg pimenovoleg pimenovoleg approved these changes

@lskramarov lskramarov lskramarov approved these changes

@rmnturov rmnturov rmnturov approved these changes

Assignees

@NikGurev NikGurev

Labels
breaking changes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NikGurev @rmnturov @vitalyozza @pimenovoleg @lskramarov