fix: Fix handle_sse method to match Starlette route endpoint expectations #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix handle_sse method to match Starlette route endpoint expectations
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handle_sse method to return an ASGI application function, aligning it with Starlette’s route endpoint requirements.
- Changed
handle_sseto wrap SSE logic in a nested ASGI app callable - Adjusted parameters passed to
sse.connect_sseto use the ASGIscope,receive, andsend - Removed the return type annotation and now return the nested
appfunction
Comments suppressed due to low confidence (1)
src/mcpm/router/router.py:618
- [nitpick] The nested function name
appis quite generic; renaming it to something more descriptive (e.g.,sse_asgi_app) could improve readability.
async def app(scope: Scope, receive: Receive, send: Send) -> None:
JoJoJoJoJoJoJo
approved these changes
May 28, 2025
There was a problem hiding this comment.
Thank you ❤️ ! But I would prefer to follow the official example which returns an empty response
https://github.com/modelcontextprotocol/python-sdk/blob/main/src/mcp/server/sse.py#L26
JoJoJoJoJoJoJo
changed the title
mcpm-semantic-release bot
pushed a commit
that referenced
this pull request
May 29, 2025
## [1.13.1](v1.13.0...v1.13.1) (2025-05-29) ### Bug Fixes * Fix handle_sse method to match Starlette route endpoint expectations ([#156](#156)) ([7d13fc1](7d13fc1))
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
handle_ssemethod in the router.py file to match the format expected by Starlette for route endpoints.Problem
The current implementation of
handle_ssehas a signature that does not match what Starlette expects. Starlette route endpoints should either be async functions that take a Request object and return a Response, or be callables that take scope, receive, and send parameters.Solution
Updated the
handle_ssemethod to return an ASGI application function that takes scope, receive, and send parameters, making it compatible with Starlettes routing system.Testing
All tests are passing, confirming that the changes are working correctly.