fix: remove stdout stream handling for share #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJoJoJoJoJo
force-pushed
the
jonathan/fix-select-read-stderr-error
branch
from
cc18d8d to
5c4e6ce
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes POSIX-specific non-blocking stream handling (fcntl/select) to improve Windows compatibility in the share command.
- Deleted
make_non_blockingand related tests. - Simplified loops to read only
stderrand removedselectcalls. - Adjusted error message dispatch in the router to send raw errors.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_share.py | Removed make_non_blocking test and its import |
| src/mcpm/router/transport.py | Changed await writer.send(SessionMessage(message=err)) to raw send |
| src/mcpm/commands/share.py | Dropped fcntl/select usage, removed non-blocking setup, and simplified I/O loops |
Comments suppressed due to low confidence (1)
src/mcpm/router/transport.py:223
- The router protocol likely expects a
SessionMessageobject. Sending the rawerrmay break the consumer; restore or replace the wrapper so the message format matches the API contract.
await writer.send(err)
niechen
reviewed
Jun 5, 2025
niechen
approved these changes
Jun 5, 2025
mcpm-semantic-release bot
pushed a commit
that referenced
this pull request
Jun 5, 2025
## [1.13.3](v1.13.2...v1.13.3) (2025-06-05) ### Bug Fixes * remove stdout stream handling for share ([#167](#167)) ([11fddcc](11fddcc))
|
🎉 This PR is included in version 1.13.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove
fcntland select for windows compatible