fix: npx path in windows is npx.cmd #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Windows compatibility issue by ensuring that the correct NPX command ("npx.cmd") is used when running commands.
- Introduces the NPX_CMD constant in platform.py to differentiate between Windows and other platforms.
- Updates inspector.py and client.py to use NPX_CMD instead of the hard-coded "npx".
- Updates cli.py to include "inspector" in the valid command list.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mcpm/utils/platform.py | Defines NPX_CMD for Windows compatibility. |
| src/mcpm/commands/inspector.py | Refactors command strings to use NPX_CMD for uniformity. |
| src/mcpm/commands/client.py | Updates command configuration to use NPX_CMD. |
| src/mcpm/cli.py | Adds "inspector" to the recognized commands list. |
niechen
approved these changes
Jun 7, 2025
mcpm-semantic-release bot
pushed a commit
that referenced
this pull request
Jun 7, 2025
## [1.13.4](v1.13.3...v1.13.4) (2025-06-07) ### Bug Fixes * npx path in windows is npx.cmd ([#169](#169)) ([9dc8746](9dc8746))
|
🎉 This PR is included in version 1.13.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #153