fix: add type constraint for advancedSort

Author: mkczarkowski

src/advanced-filtering/src/services/logProcessing.ts

@@ -1,20 +1,20 @@
-import {LogEntry, SimpleLogFilterCriteria, SortCriteria} from "../types";
+import { LogEntry, SimpleLogFilterCriteria, SortCriteria } from '../types';
 
-export function advancedSort<ItemType>(
+export function advancedSort<ItemType extends object>(
   arr: ItemType[],
   criteria: SortCriteria<ItemType>
 ): ItemType[] {
   return [...arr].sort((a, b) => {
     for (const key in criteria) {
-      const {direction, customCompare} = criteria[key] || {};
+      const { direction, customCompare } = criteria[key] || {};
       if (a[key] !== b[key]) {
         let comparison: number;
         if (customCompare) {
           comparison = customCompare(a[key], b[key]);
         } else {
           comparison = a[key] < b[key] ? -1 : 1;
         }
-        return direction === "desc" ? -comparison : comparison;
+        return direction === 'desc' ? -comparison : comparison;
       }
     }
     return 0;
@@ -35,7 +35,7 @@ export function simpleLogFilter(
         return true;
       }
       const value = log[key];
-      if (typeof condition === "function") {
+      if (typeof condition === 'function') {
         return (condition as (value: any) => boolean)(value);
       }
       return value === condition;

src/advanced-filtering/src/types/index.ts

@@ -1,10 +1,10 @@
-export type LogLevel = "INFO" | "WARNING" | "ERROR";
+export type LogLevel = 'INFO' | 'WARNING' | 'ERROR';
 export type LogSource =
-  | "user-service"
-  | "auth-service"
-  | "payment-service"
-  | "notification-service"
-  | "api-gateway";
+  | 'user-service'
+  | 'auth-service'
+  | 'payment-service'
+  | 'notification-service'
+  | 'api-gateway';
 
 export interface LogEntry {
   timestamp: Date;
@@ -19,9 +19,9 @@ export type CompareFunction<ItemTypeValue> = (
   b: ItemTypeValue
 ) => number;
 
-export type SortCriteria<ItemType> = {
+export type SortCriteria<ItemType extends object> = {
   [Key in keyof ItemType]?: {
-    direction: "asc" | "desc";
+    direction: 'asc' | 'desc';
     customCompare?: CompareFunction<ItemType[Key]>;
   };
 };
@@ -31,11 +31,11 @@ export type SimpleLogFilterCriteria = {
   source?: LogSource | ((value: LogSource) => boolean);
 };
 
-export type SimpleLogFilterKey = "level" | "source";
+export type SimpleLogFilterKey = 'level' | 'source';
 
 export type SimpleFilterableLogValue = LogLevel | LogSource;
 
 export type UpdateLogFilterFunction = (
   key: SimpleLogFilterKey,
-  value: SimpleFilterableLogValue | ""
+  value: SimpleFilterableLogValue | ''
 ) => void;