fine tune and add the contributor @guilhermecaldas for #16

Author: jumperchen

CHANGELOG.md

@@ -1,2 +1,5 @@
-## 0.9.0+3
-- Apply Pedantic recommendations
+## 0.9.1
+
+**New Feature:**
+
+* [#16](https://github.com/rikulo/socket.io-dart/pull/16) Apply Pedantic recommendations

README.md

@@ -88,4 +88,5 @@ If you are new to Git or GitHub, please read [this guide](https://help.github.co
 
 ## Contributors
 * Thanks [@felangel](https://github.com/felangel) for https://github.com/rikulo/socket.io-dart/issues/7
-* Thanks [@ThinkDigitalSoftware](https://github.com/ThinkDigitalSoftware) for https://github.com/rikulo/socket.io-dart/pull/15
+* Thanks [@ThinkDigitalSoftware](https://github.com/ThinkDigitalSoftware) for https://github.com/rikulo/socket.io-dart/pull/15
+* Thanks [@guilhermecaldas](https://github.com/guilhermecaldas) for https://github.com/rikulo/socket.io-dart/pull/16

example/README.md

@@ -0,0 +1,70 @@
+# socket.io-dart
+
+Port of awesome JavaScript Node.js library - [Socket.io v2.0.1](https://github.com/socketio/socket.io) - in Dart
+
+## Usage
+
+```dart
+import 'package:socket_io/socket_io.dart';
+
+main() {
+    var io = new Server();
+    var nsp = io.of('/some');
+    nsp.on('connection', (client) {
+      print('connection /some');
+      client.on('msg', (data) {
+        print('data from /some => $data');
+        client.emit('fromServer', "ok 2");
+      });
+    });
+      io.on('connection', (client) {
+        print('connection default namespace');
+        client.on('msg', (data) {
+          print('data from default => $data');
+          client.emit('fromServer', "ok");
+        });
+      });
+      io.listen(3000);
+}
+```
+
+```js
+// JS client
+var socket = io('http://localhost:3000');
+socket.on('connect', function(){console.log('connect')});
+socket.on('event', function(data){console.log(data)});
+socket.on('disconnect', function(){console.log('disconnect')});
+socket.on('fromServer', function(e){console.log(e)});
+```
+
+```dart
+// Dart client
+import 'package:socket_io_client/socket_io_client.dart' as IO;
+
+IO.Socket socket = IO.io('http://localhost:3000');
+socket.on('connect', (_) {
+  print('connect');
+  socket.emit('msg', 'test');
+});
+socket.on('event', (data) => print(data));
+socket.on('disconnect', (_) => print('disconnect'));
+socket.on('fromServer', (_) => print(_));
+```
+
+## Multiplexing support
+
+Same as Socket.IO, this project allows you to create several Namespaces, which will act as separate communication channels but will share the same underlying connection.
+
+## Room support
+
+Within each Namespace, you can define arbitrary channels, called Rooms, that sockets can join and leave. You can then broadcast to any given room, reaching every socket that has joined it.
+
+## Transports support
+ Refers to [engine.io](https://github.com/socketio/engine.io)
+
+- `polling`: XHR / JSONP polling transport.
+- `websocket`: WebSocket transport.
+
+## Adapters support
+
+*  Default socket.io in-memory adapter class. Refers to [socket.io-adapter](https://github.com/socketio/socket.io-adapter)

lib/src/engine/server.dart

@@ -287,7 +287,7 @@ class Server extends Engine {
     }
     var socket = Socket(id, this, transport, connect);
 
-    if (false != cookie) {
+    if (cookie?.isNotEmpty == true) {
       transport.on('headers', (headers) {
         headers['Set-Cookie'] = '${cookie}=${Uri.encodeComponent(id)}' +
             (cookiePath?.isNotEmpty == true ? '; Path=${cookiePath}' : '') +
@@ -373,6 +373,7 @@ class Server extends Engine {
         var req = connect.request;
         var transport = Transports.newInstance(
             req.uri.queryParameters['transport'], connect);
+        // ignore: unrelated_type_equality_checks
         if (req.uri.queryParameters['b64'] == true) {
           transport.supportsBinary = false;
         } else {

lib/src/engine/transport/polling_transport.dart

@@ -189,6 +189,7 @@ class PollingTransport extends Transport {
         }
 
         self.onPacket(packet);
+        return true;
       };
 
       PacketParser.decodePayload(data, callback: callback);

lib/src/namespace.dart

@@ -79,7 +79,7 @@ class Namespace extends EventEmitter {
   }
 
   //TODO: Figure out return type for this method
-  static run0(int index, List<Function> fns, Socket socket, Function fn) {
+  static Object run0(int index, List<Function> fns, Socket socket, Function fn) {
     return fns[index](socket, (err) {
       // upon error, short-circuit
       if (err) return fn(err);
@@ -88,7 +88,7 @@ class Namespace extends EventEmitter {
       if (fns.length <= index + 1) return fn(null);
 
       // go on to next
-      run0(index + 1, fns, socket, fn);
+      return run0(index + 1, fns, socket, fn);
     });
   }
 
@@ -169,7 +169,7 @@ class Namespace extends EventEmitter {
       // @todo check how to handle it with Dart
       // if (hasBin(args)) { parserType = ParserType.binaryEvent; } // binary
 
-      var data = arg == null ? [ev] : [ev, arg];
+      // ignore: omit_local_variable_types
       List data = argument == null ? [event] : [event, argument];
 
       final packet = {'type': EVENT, 'data': data};
@@ -201,6 +201,7 @@ class Namespace extends EventEmitter {
   ///
   /// TODO: Fix this description or code. Add type parameters to [fn([_])]
   ///
+  // ignore: use_function_type_syntax_for_parameters
   Namespace clients(fn([_])) {
     adapter.clients(rooms, fn);
     rooms = [];

pubspec.yaml

@@ -2,8 +2,8 @@ name: socket_io
 description: >
   Port of JS/Node library Socket.io. It enables real-time, bidirectional and 
   event-based communication cross-platform.
-version: 0.9.1+1
-# author: jumperchen <jumperchen@potix.com>
+version: 0.9.1
+author: jumperchen <jumperchen@potix.com>
 homepage: https://www.zkoss.org
 repository: https://github.com/rikulo/socket.io-dart
 issue_tracker: https://github.com/rikulo/socket.io-dart/issues