Skip to content

Commit 68cae38

Browse files
committed
[CI] Disable PyMVA so we can support the newest TensorFlow versions
Right now we don't support the newest TensorFlow releases after the 2.15 series, initially released in November 2023 [1]. Support for TensorFlow>=2.16 is worked on [2], but it's difficult to make progress if we don't have TensorFlow>=2.16 in our CI images. And we veto it from our CI image via the `requirements.txt` mechanism. To continue, we need to temporarily disable PyMVA in the CI, such that we can include the newest TensorFlow version in our images, and then re-enable it in the PR that fixes support for the newest TensorFlow. This is what is done in this commit. Supporting the newest TensorFlow became a bit more important now that we also have another feature besides PyMVA that uses TensorFlow: the RBatchGenerator. It would not good to hold off testing the actively-developed RBatchGenerator on newer TensorFlow versions, just because PyMVA prevents us from installing these on our CI. [1] https://github.com/tensorflow/tensorflow/releases [2] #15790
1 parent 99975b2 commit 68cae38

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/root-ci-config/buildconfig/global.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ testing=ON
9191
tmva-cpu=ON
9292
tmva-gpu=OFF
9393
tmva-cudnn=OFF
94-
tmva-pymva=ON
94+
tmva-pymva=OFF
9595
tmva-rmva=OFF
9696
tmva-sofie=OFF
9797
tmva=ON

.github/workflows/root-ci-config/buildconfig/ubuntu2404-cuda.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ tmva=ON
66
tmva-cpu=ON
77
tmva-gpu=ON
88
tmva-cudnn=ON
9-
tmva-pymva=ON
9+
tmva-pymva=OFF
1010
fortran=OFF
1111
gdml=OFF
1212
spectrum=OFF

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ onnx
1111

1212
# TMVA: PyMVA interfaces
1313
scikit-learn
14-
tensorflow<2.16 ; python_version < "3.12"
14+
tensorflow ; python_version < "3.13" # TensorFlow doesn't support Python 3.13 yet
1515
torch
1616
xgboost
1717

0 commit comments

Comments
 (0)