Skip to content

Commit 2bb98e2

Browse files
committed
Generate symbols.o for proc-macros too
To ensure used statics are functioning correctly for proc-macros too.
1 parent ae2fc97 commit 2bb98e2

File tree

4 files changed

+32
-2
lines changed

4 files changed

+32
-2
lines changed

compiler/rustc_codegen_ssa/src/back/linker.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1817,8 +1817,13 @@ pub(crate) fn linked_symbols(
18171817
crate_type: CrateType,
18181818
) -> Vec<(String, SymbolExportKind)> {
18191819
match crate_type {
1820-
CrateType::Executable | CrateType::Cdylib | CrateType::Dylib | CrateType::Sdylib => (),
1821-
CrateType::Staticlib | CrateType::ProcMacro | CrateType::Rlib => {
1820+
CrateType::Executable
1821+
| CrateType::ProcMacro
1822+
| CrateType::Cdylib
1823+
| CrateType::Dylib
1824+
| CrateType::Sdylib => (),
1825+
CrateType::Staticlib | CrateType::Rlib => {
1826+
// These are not linked, so no need to generate symbols.o for them.
18221827
return Vec::new();
18231828
}
18241829
}

tests/run-make/used-proc-macro/dep.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#![crate_type = "lib"]
2+
3+
#[used]
4+
static VERY_IMPORTANT_SYMBOL: u32 = 12345;
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
#![crate_type = "proc-macro"]
2+
3+
extern crate dep as _;
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
// Test that #[used] statics are included in the final dylib for proc-macros too.
2+
3+
//@ ignore-cross-compile
4+
//@ ignore-windows llvm-readobj --all doesn't show local symbols on Windows
5+
//@ needs-crate-type: proc-macro
6+
//@ ignore-musl (FIXME: can't find `-lunwind`)
7+
8+
use run_make_support::{dynamic_lib_name, llvm_readobj, rustc};
9+
10+
fn main() {
11+
rustc().input("dep.rs").run();
12+
rustc().input("proc_macro.rs").run();
13+
llvm_readobj()
14+
.input(dynamic_lib_name("proc_macro"))
15+
.arg("--all")
16+
.run()
17+
.assert_stdout_contains("VERY_IMPORTANT_SYMBOL");
18+
}

0 commit comments

Comments
 (0)