Skip to content

Commit f1c71ff

Browse files
committed
Clean some config stuff up
1 parent 1881087 commit f1c71ff

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

build_system/src/config.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -352,15 +352,6 @@ impl ConfigInfo {
352352
None => return Err("no host found".to_string()),
353353
};
354354

355-
if self.target_triple.is_empty() {
356-
// TODO: set target triple.
357-
// TODO: why do we even need to set target_triple?
358-
// It seems to only be needed for the linker (we could add an environment variable to
359-
// remove this need) and the sysroot (perhaps we could find another way to find it).
360-
// TODO TODO: seems like we would still need OVERWRITE_TARGET_TRIPLE when using a
361-
// json spec file.
362-
// ====> maybe not since we specify both --target and --target-triple.
363-
}
364355
if self.target_triple.is_empty() {
365356
self.target_triple = self.host_triple.clone();
366357
}
@@ -374,7 +365,6 @@ impl ConfigInfo {
374365
if self.target_triple.is_empty() {
375366
return Err("Unknown non-native platform".to_string());
376367
}
377-
// TODO: check if this is still needed.
378368
linker = Some(format!("-Clinker={}-gcc", self.target_triple));
379369
self.run_in_vm = true;
380370
}

0 commit comments

Comments
 (0)