Merge pull request #382 from sommmen/fix/381_SqlTableCreatorFormatException

fix(logging): Fixed string formats in Selflog.WriteLine calls.

Author: ckadluba

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/ColumnOptions/FinalizeConfigurationForSinkConstructor.cs

@@ -68,7 +68,7 @@ internal void FinalizeConfigurationForSinkConstructor()
             // PK must always be NON-NULL
             if (PrimaryKey != null && PrimaryKey.AllowNull == true)
             {
-                SelfLog.WriteLine($"Warning: Primary key must be NON-NULL, changing AllowNull property for {PrimaryKey.ColumnName} column.");
+                SelfLog.WriteLine("Warning: Primary key must be NON-NULL, changing AllowNull property for {0} column.", PrimaryKey.ColumnName);
                 PrimaryKey.AllowNull = false;
             }
 
@@ -81,7 +81,7 @@ private static void ColumnstoreCompatibilityCheck(SqlColumn column)
                 throw new ArgumentException($"Columnstore indexes do not support data type \"{column.DataType}\" declared for column \"{column.ColumnName}\".");
 
             if (column.DataLength == -1 && SqlDataTypes.DataLengthRequired.Contains(column.DataType))
-                SelfLog.WriteLine($"Warning: SQL2017 or newer required to use columnstore index with MAX length column \"{column.ColumnName}\".");
+                SelfLog.WriteLine("Warning: SQL2017 or newer required to use columnstore index with MAX length column \"{0}\".", column.ColumnName);
         }
     }
 }

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Platform/SqlLogEventWriter.cs

@@ -69,7 +69,7 @@ public void WriteEvent(LogEvent logEvent)
             }
             catch (Exception ex)
             {
-                SelfLog.WriteLine("Unable to write log event to the database due to following error: {1}", ex.Message);
+                SelfLog.WriteLine("Unable to write log event to the database due to following error: {0}", ex.Message);
                 throw;
             }
         }

src/Serilog.Sinks.MSSqlServer/Sinks/MSSqlServer/Platform/SqlTableCreator.cs

@@ -42,7 +42,7 @@ public void CreateTable(DataTable dataTable)
             }
             catch (Exception ex)
             {
-                SelfLog.WriteLine($"Exception creating table {_tableName}:\n{ex}");
+                SelfLog.WriteLine("Exception creating table {0}:\n{1}", _tableName, ex.ToString());
             }
         }
     }