Skip to content

Commit 9a02dce

Browse files
wilkinsonaphilwebb
authored andcommitted
Make additional health web paths back off without web endpoint infra
1 parent d8e34d7 commit 9a02dce

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

spring-boot-project/spring-boot-webflux/src/test/java/org/springframework/boot/webflux/autoconfigure/actuate/endpoint/web/WebFluxHealthEndpointExtensionAutoConfigurationTests.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,16 @@ void additionalReactiveHealthEndpointsPathsTolerateHealthEndpointThatIsNotWebExp
6969
});
7070
}
7171

72+
@Test
73+
@WithTestEndpointOutcomeExposureContributor
74+
void backsOffWithoutWebEndpointInfrastructure() {
75+
this.contextRunner.withConfiguration(AutoConfigurations.of(EndpointAutoConfiguration.class))
76+
.withPropertyValues("management.endpoints.web.exposure.exclude=*",
77+
"management.endpoints.test.exposure.include=*")
78+
.run((context) -> assertThat(context)
79+
.doesNotHaveBean(AdditionalHealthEndpointPathsWebFluxHandlerMapping.class));
80+
}
81+
7282
@Configuration(proxyBeanMethods = false)
7383
static class HealthIndicatorsConfiguration {
7484

spring-boot-project/spring-boot-webmvc/src/main/java/org/springframework/boot/webmvc/autoconfigure/actuate/endpoint/web/WebMvcHealthEndpointExtensionAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
@AutoConfiguration
4545
@ConditionalOnWebApplication(type = Type.SERVLET)
4646
@ConditionalOnClass(HealthEndpoint.class)
47-
@ConditionalOnBean(HealthEndpoint.class)
47+
@ConditionalOnBean({ HealthEndpoint.class, WebEndpointsSupplier.class, HealthEndpointGroups.class })
4848
@ConditionalOnAvailableEndpoint(endpoint = HealthEndpoint.class, exposure = EndpointExposure.WEB)
4949
public class WebMvcHealthEndpointExtensionAutoConfiguration {
5050

spring-boot-project/spring-boot-webmvc/src/test/java/org/springframework/boot/webmvc/actuate/autoconfigure/health/WebMvcHealthEndpointExtensionAutoConfigurationTests.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,17 @@ void additionalHealthEndpointsPathsTolerateHealthEndpointThatIsNotWebExposed() {
6969
});
7070
}
7171

72+
@Test
73+
@WithTestEndpointOutcomeExposureContributor
74+
void backsOffWithoutWebEndpointInfrastructure() {
75+
this.contextRunner.withConfiguration(AutoConfigurations.of(EndpointAutoConfiguration.class))
76+
.withBean(DispatcherServlet.class)
77+
.withPropertyValues("management.endpoints.web.exposure.exclude=*",
78+
"management.endpoints.test.exposure.include=*")
79+
.run((context) -> assertThat(context)
80+
.doesNotHaveBean(AdditionalHealthEndpointPathsWebMvcHandlerMapping.class));
81+
}
82+
7283
@Configuration(proxyBeanMethods = false)
7384
static class HealthIndicatorsConfiguration {
7485

0 commit comments

Comments
 (0)