Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Commit e783820

Browse files
committed
fix unit test
1 parent 7cef43f commit e783820

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

src/codegate/api/v1.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,7 @@ async def stream_sse():
728728
@v1.get("/version", tags=["Dashboard"], generate_unique_id_function=uniq_name)
729729
async def version_check():
730730
try:
731-
latest_version = __get_latest_version()
731+
latest_version = _get_latest_version()
732732
# normalize the versions as github will return them with a 'v' prefix
733733
current_version = __version__.lstrip("v")
734734
latest_version_stripped = latest_version.lstrip("v")
@@ -885,6 +885,6 @@ async def delete_persona(persona_name: str):
885885

886886

887887
@cachetools.func.ttl_cache(maxsize=128, ttl=20 * 60)
888-
def __get_latest_version():
888+
def _get_latest_version():
889889
update_client = get_update_client_singleton()
890890
return update_client.get_latest_version(Origin.FrontEnd)

tests/test_server.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
from codegate.pipeline.factory import PipelineFactory
1717
from codegate.providers.registry import ProviderRegistry
1818
from codegate.server import init_app
19+
from codegate.updates.client import Origin
1920
from src.codegate.cli import UvicornServer, cli
2021
from src.codegate.codegate_logging import LogFormat, LogLevel
2122

@@ -75,18 +76,20 @@ def test_health_check(test_client: TestClient) -> None:
7576
assert response.json() == {"status": "healthy"}
7677

7778

78-
@patch("codegate.api.v1_processing.fetch_latest_version", return_value="foo")
79-
def test_version_endpoint(mock_fetch_latest_version, test_client: TestClient) -> None:
79+
@patch("codegate.api.v1._get_latest_version")
80+
def test_version_endpoint(mock_get_latest_version, test_client: TestClient) -> None:
8081
"""Test the version endpoint."""
82+
# Mock the __get_latest_version function to return a specific version
83+
mock_get_latest_version.return_value = "v1.2.3"
84+
8185
response = test_client.get("/api/v1/version")
8286
assert response.status_code == 200
8387

8488
response_data = response.json()
85-
86-
assert response_data["current_version"] == __version__.lstrip("v")
87-
assert response_data["latest_version"] == "foo"
88-
assert isinstance(response_data["is_latest"], bool)
89+
assert response_data["current_version"] == "0.1.7"
90+
assert response_data["latest_version"] == "1.2.3"
8991
assert response_data["is_latest"] is False
92+
assert response_data["error"] is None
9093

9194

9295
@patch("codegate.pipeline.sensitive_data.manager.SensitiveDataManager")

0 commit comments

Comments
 (0)