-
-
Notifications
You must be signed in to change notification settings - Fork 838
feat: add implementation for math/base/special/exp10f #7387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: missing_dependencies - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
|
@Deepak91168 Did you follow any reference implementation for this? It looks like a direct port of |
For the current implementation, I suggest exploring other libraries such as FreeBSD, Cephes, Julia, and Boost to see if they offer a specific single-precision |
Thank you for reviewing! Yes, you're right — this was originally a direct port of the double-precision
I’ve found Sorry for the earlier oversight — I appreciate your guidance. I’ll now rework the implementation accordingly by refering |
@Deepak91168 No worries at all. It's totally fine, and honestly, it's great that you caught this early on. Realising it now saves a lot of effort later, and it's all part of the learning process. Referring to As a quick sanity check, it might also be helpful to look at another reference implementation and compare it with Cephes. If not, Cephes is definitely a good reference. |
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Hello! @anandkaranubc I'm submitting the implementation for There are a few things I'd like to highlight and would appreciate your guidance on: 1. Failing Test Case Due to Float Precision
not ok 6 within tolerance. x: -37.944557189941406. Value: 1.1361685909791687e-38. Expected: 1.1361687311090151e-38. Delta: 1.401298464324817e-45. Tolerance: 1.3544186724531831e-45.
---
operator: ok
expected: true
actual: false
at: Test.test (/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/test/test.js:68:5)
... Since the delta is just slightly above the threshold, I’ve temporarily increased the tolerance using: tol = 2 * EPS * abs( expected[i] ); This allows all tests to pass. Please let me know if this is an acceptable solution or if you'd prefer a stricter alternative. 2. CI Failure: Cephes Download Timeout
curl: (28) Failed to connect to www.moshier.net port 80 after 30002 ms: Timeout was reached
make: *** [...cephes_moshier.mk:175: .../moshier_cephes/double.zip] Error 28 However, everything runs fine locally. 3. Local Benchmark Success➜ make benchmark-c-files FILES="$(pwd)/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/benchmark.c" Running benchmark: /home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/benchmark.c
make[1]: Entering directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c'
make[1]: Leaving directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c'
Resolving package path...
Package path: /home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f
Resolving package manifest...
Successfully resolved package manifest.
Resolving include directories...
Resolving source files...
Resolving libraries...
Resolving library paths...
Compiling benchmark...
make[1]: Entering directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c'
benchmark.c: In function ‘benchmark’:
benchmark.c:108:21: warning: implicit declaration of function ‘exp10f’; did you mean ‘exp2f’? [-Wimplicit-function-declaration]
108 | y = exp10f( x[ i%100 ] );
| ^~~~~~
| exp2f
make[1]: Leaving directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c'
Successfully compiled benchmark.
Success!
make[1]: Entering directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c'
TAP version 13
# c::exp10f
---
iterations: 1000000
elapsed: 0.006929159
rate: 144317654.750025809
...
ok 1 benchmark finished
# c::exp10f
---
iterations: 1000000
elapsed: 0.007263899
rate: 137667115.239439398
...
ok 2 benchmark finished
# c::exp10f
---
iterations: 1000000
elapsed: 0.013909817
rate: 71891673.237119064
...
ok 3 benchmark finished
#
1..3
# total 3
# pass 3
#
# ok
make[1]: Leaving directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c' ➜ make benchmark-c-files FILES="$(pwd)/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/cephes/benchmark.c" Running benchmark: /home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/cephes/benchmark.c
make[1]: Entering directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/cephes'
make[1]: Leaving directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/cephes'
Resolving package path...
Package path: /home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f
Resolving package manifest...
Successfully resolved package manifest.
Resolving include directories...
Resolving source files...
Resolving libraries...
Resolving library paths...
Compiling benchmark...
make[1]: Entering directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/cephes'
/home/deepak/Desktop/forks/stdlib/deps/build/moshier_cephes/cephes/double/hyperg.c: In function ‘hyperg’:
/home/deepak/Desktop/forks/stdlib/deps/build/moshier_cephes/cephes/double/hyperg.c:99:3: warning: ‘pcanc’ may be used uninitialized [-Wmaybe-uninitialized]
99 | if( pcanc < 1.0e-15 )
| ^
/home/deepak/Desktop/forks/stdlib/deps/build/moshier_cephes/cephes/double/hyperg.c:90:27: note: ‘pcanc’ was declared here
90 | double asum, psum, acanc, pcanc, temp;
| ^~~~~
/home/deepak/Desktop/forks/stdlib/deps/build/moshier_cephes/cephes/double/jv.c: In function ‘jv’:
/home/deepak/Desktop/forks/stdlib/deps/build/moshier_cephes/cephes/double/jv.c:165:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
165 | if( an > 2.0 * y )
| ^~
/home/deepak/Desktop/forks/stdlib/deps/build/moshier_cephes/cephes/double/jv.c:168:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
168 | if( (n >= 0.0) && (n < 20.0)
| ^~
/home/deepak/Desktop/forks/stdlib/deps/build/moshier_cephes/cephes/double/stdtr.c: In function ‘stdtr’:
/home/deepak/Desktop/forks/stdlib/deps/build/moshier_cephes/cephes/double/stdtr.c:180:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
180 | if( t < 0 )
| ^~
/home/deepak/Desktop/forks/stdlib/deps/build/moshier_cephes/cephes/double/stdtr.c:183:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
183 | p = 0.5 + 0.5 * p;
| ^
make[1]: Leaving directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/cephes'
Successfully compiled benchmark.
Success!
make[1]: Entering directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/cephes'
TAP version 13
# c::cephes::exp10f
---
iterations: 1000000
elapsed: 0.016671896
rate: 59981180.373818412
...
ok 1 benchmark finished
# c::cephes::exp10f
---
iterations: 1000000
elapsed: 0.006736040
rate: 148455172.901992708
...
ok 2 benchmark finished
# c::cephes::exp10f
---
iterations: 1000000
elapsed: 0.008225918
rate: 121566981.624253660
...
ok 3 benchmark finished
#
1..3
# total 3
# pass 3
#
# ok
make[1]: Leaving directory '/home/deepak/Desktop/forks/stdlib/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/cephes' Minor warnings (in Cephes sources), but no runtime issues Kindly review this PR and let me know if any changes are required. |
Resolves #6711
Description
This pull request:
exp10f
package to the@stdlib/math/base/special
namespace.Related Issues
No
This pull request:
math/base/special/exp10f
#6711Questions
No.
Other
Output of:
➜ make test TESTS_FILTER=".*/@stdlib/math/base/special/exp10f/.*"
exp10f.test.log
➜ make benchmark-c-files FILES="$(pwd)/lib/node_modules/@stdlib/math/base/special/exp10f/benchmark/c/native/benchmark.c"
exp10f.c_examples.log
➜ make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/exp10f/.*"
exp10f.benchmark.log
Checklist
@stdlib-js/reviewers