Skip to content

Commit 839407d

Browse files
authored
Clean up some XCTSkips (#6808)
- enable a test that is passing again - remove some outdated skipping code in another test
1 parent c9ba550 commit 839407d

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

Tests/CommandsTests/BuildToolTests.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ final class BuildToolTests: CommandsTestCase {
7777
}
7878

7979
func testImportOfMissedDepWarning() throws {
80-
try XCTSkipIf(true, "tested functionality doesn't work due to 'libSwiftScan dependency scan query failed' (rdar://108512158)")
81-
8280
// Verify the warning flow
8381
try fixture(name: "Miscellaneous/ImportOfMissingDependency") { path in
8482
let fullPath = try resolveSymlinks(path)

Tests/SourceControlTests/RepositoryManagerTests.swift

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -126,14 +126,6 @@ class RepositoryManagerTests: XCTestCase {
126126
}
127127

128128
func testCache() throws {
129-
if #available(macOS 11, *) {
130-
// No need to skip the test.
131-
}
132-
else {
133-
// Avoid a crasher that seems to happen only on macOS 10.15, but leave an environment variable for testing.
134-
try XCTSkipUnless(ProcessEnv.vars["SWIFTPM_ENABLE_FLAKY_REPOSITORYMANAGERTESTS"] == "1", "skipping test that sometimes crashes in CI (rdar://70540298)")
135-
}
136-
137129
let fs = localFileSystem
138130
let observability = ObservabilitySystem.makeForTesting()
139131

0 commit comments

Comments
 (0)