Improve diagnostics if testPackageContextName fails (#7025)

neonichu · web-flow · commit aad39fbdb686 · 2023-10-20T17:49:24.000-07:00
rdar://116490917
diff --git a/Tests/PackageLoadingTests/PD_5_6_LoadingTests.swift b/Tests/PackageLoadingTests/PD_5_6_LoadingTests.swift
@@ -208,7 +208,9 @@ class PackageDescription5_6LoadingTests: PackageDescriptionLoadingTests {
         XCTAssertNoDiagnostics(observability.diagnostics)
         XCTAssertNoDiagnostics(validationDiagnostics)
 
-        let name = parsedManifest.parentDirectory?.pathString ?? ""
+        XCTAssertNotNil(parsedManifest)
+        XCTAssertNotNil(parsedManifest.parentDirectory)
+        let name = try XCTUnwrap(parsedManifest.parentDirectory).pathString
         XCTAssertEqual(manifest.displayName, name)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,9 @@ class PackageDescription5_6LoadingTests: PackageDescriptionLoadingTests {`
`208`	`208`	`XCTAssertNoDiagnostics(observability.diagnostics)`
`209`	`209`	`XCTAssertNoDiagnostics(validationDiagnostics)`
`210`	`210`
`211`		`- let name = parsedManifest.parentDirectory?.pathString ?? ""`
	`211`	`+ XCTAssertNotNil(parsedManifest)`
	`212`	`+ XCTAssertNotNil(parsedManifest.parentDirectory)`
	`213`	`+ let name = try XCTUnwrap(parsedManifest.parentDirectory).pathString`
`212`	`214`	`XCTAssertEqual(manifest.displayName, name)`
`213`	`215`	`}`
`214`	`216`