Skip to content

Commit a55bbfb

Browse files
yasarsidYasar Siddiqui
andauthored
Recognize tslint-react as an extended ruleset (#656)
* Recognize tslint-react as an extended ruleset * add 'react/recommended' to retriveExtendsValue Co-authored-by: Yasar Siddiqui <mosiddiq@microsoft.com>
1 parent 809f46b commit a55bbfb

File tree

3 files changed

+15
-0
lines changed

3 files changed

+15
-0
lines changed

src/creation/summarization/collectTSLintRulesets.test.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,19 @@ describe("collectTSLintRulesets", () => {
3333
]);
3434
});
3535

36+
it("includes mapped ESLint extension for a raw TSLint-React extension when it exists", () => {
37+
const tslint = {
38+
full: {},
39+
raw: {
40+
extends: ["tslint-react"],
41+
},
42+
};
43+
44+
const extensions = collectTSLintRulesets(tslint);
45+
46+
expect(extensions).toEqual(["plugin:react/recommended"]);
47+
});
48+
3649
it("ignores a TSLint extension when it has no mapped ESLint extensions", () => {
3750
const tslint = {
3851
full: {

src/creation/summarization/collectTSLintRulesets.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ const nativeExtensions = new Map([
1111
"plugin:@typescript-eslint/recommended-requiring-type-checking",
1212
],
1313
],
14+
["tslint-react", ["plugin:react/recommended"]],
1415
]);
1516

1617
export const collectTSLintRulesets = (

src/creation/summarization/retrieveExtendsValues.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ const pluginExtensions = new Map([
3636
"plugin:@typescript-eslint/recommended-requiring-type-checking",
3737
"node_modules/@typescript-eslint/eslint-plugin/dist/configs/recommended-requiring-type-checking.json",
3838
],
39+
["plugin:react/recommended", "node_modules/eslint-plugin-react/index.js"],
3940
]);
4041

4142
/**

0 commit comments

Comments
 (0)