From d34c7087179d83f8c1947f0f607bdcdedd329e9b Mon Sep 17 00:00:00 2001 From: Yash Kulshrestha Date: Sun, 6 Oct 2019 11:00:22 -0700 Subject: [PATCH 1/2] added a converter fro use-default-type-parameter --- src/rules/converters.ts | 2 ++ .../tests/use-default-type-parameter.test.ts | 17 +++++++++++++++++ .../converters/use-default-type-parameter.ts | 13 +++++++++++++ 3 files changed, 32 insertions(+) create mode 100644 src/rules/converters/tests/use-default-type-parameter.test.ts create mode 100644 src/rules/converters/use-default-type-parameter.ts diff --git a/src/rules/converters.ts b/src/rules/converters.ts index 78b2b9e94..44bf2e62e 100644 --- a/src/rules/converters.ts +++ b/src/rules/converters.ts @@ -107,6 +107,7 @@ import { convertTypeofCompare } from "./converters/typeof-compare"; import { convertUnifiedSignatures } from "./converters/unified-signatures"; import { convertUnnecessaryBind } from "./converters/unnecessary-bind"; import { convertUnnecessaryConstructor } from "./converters/unnecessary-constructor"; +import { convertUseDefaultTypeParameter } from "./converters/use-default-type-parameter"; import { convertUseIsnan } from "./converters/use-isnan"; import { convertQuotemark } from "./converters/quotemark"; import { convertTripleEquals } from "./converters/triple-equals"; @@ -226,6 +227,7 @@ export const converters = new Map([ ["unified-signatures", convertUnifiedSignatures], ["unnecessary-bind", convertUnnecessaryBind], ["unnecessary-constructor", convertUnnecessaryConstructor], + ["use-default-type-parameter", convertUseDefaultTypeParameter], ["use-isnan", convertUseIsnan], // These converters are all for rules that need more complex option conversions. diff --git a/src/rules/converters/tests/use-default-type-parameter.test.ts b/src/rules/converters/tests/use-default-type-parameter.test.ts new file mode 100644 index 000000000..1aea6d8c1 --- /dev/null +++ b/src/rules/converters/tests/use-default-type-parameter.test.ts @@ -0,0 +1,17 @@ +import { convertUseDefaultTypeParameter } from "../use-default-type-parameter"; + +describe(convertUseDefaultTypeParameter, () => { + test("conversion without arguments", () => { + const result = convertUseDefaultTypeParameter({ + ruleArguments: [], + }); + + expect(result).toEqual({ + rules: [ + { + ruleName: "@typescript-eslint/no-unnecessary-type-arguments", + }, + ], + }); + }); +}); diff --git a/src/rules/converters/use-default-type-parameter.ts b/src/rules/converters/use-default-type-parameter.ts new file mode 100644 index 000000000..b70a953f9 --- /dev/null +++ b/src/rules/converters/use-default-type-parameter.ts @@ -0,0 +1,13 @@ +import { RuleConverter } from "../converter"; + +// See here for reference +// https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-type-arguments.md +export const convertUseDefaultTypeParameter: RuleConverter = () => { + return { + rules: [ + { + ruleName: "@typescript-eslint/no-unnecessary-type-arguments", + }, + ], + }; +}; From 056d18d2ec7c8ea01a8ecc7e27773e5cafefe758 Mon Sep 17 00:00:00 2001 From: Yash Kulshrestha Date: Sun, 6 Oct 2019 14:01:18 -0700 Subject: [PATCH 2/2] code review changes --- src/rules/converters/use-default-type-parameter.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/rules/converters/use-default-type-parameter.ts b/src/rules/converters/use-default-type-parameter.ts index b70a953f9..092f9725d 100644 --- a/src/rules/converters/use-default-type-parameter.ts +++ b/src/rules/converters/use-default-type-parameter.ts @@ -1,7 +1,5 @@ import { RuleConverter } from "../converter"; -// See here for reference -// https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-type-arguments.md export const convertUseDefaultTypeParameter: RuleConverter = () => { return { rules: [