From 67b0368eb18ce6c934e03bdc5f28bee9bda1b5ed Mon Sep 17 00:00:00 2001 From: Krzysztof Brilla Date: Sat, 7 Nov 2020 19:32:42 +0100 Subject: [PATCH] Adding the rule, mapping it and writing the tests --- .../lintConfigs/rules/ruleConverters.ts | 2 ++ .../no-ignored-takewhile-value.ts | 12 ++++++++++++ .../tests/no-ignored-takewhile-value.test.ts | 18 ++++++++++++++++++ 3 files changed, 32 insertions(+) create mode 100644 src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-ignored-takewhile-value.ts create mode 100644 src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-ignored-takewhile-value.test.ts diff --git a/src/converters/lintConfigs/rules/ruleConverters.ts b/src/converters/lintConfigs/rules/ruleConverters.ts index 40c1f9c32..0a3707c12 100644 --- a/src/converters/lintConfigs/rules/ruleConverters.ts +++ b/src/converters/lintConfigs/rules/ruleConverters.ts @@ -183,6 +183,7 @@ import { convertJsxWrapMultiline } from "./ruleConverters/eslint-plugin-react/js //eslint-plugin-rxjs converters import { convertNoAsyncSubscribe } from "./ruleConverters/eslint-plugin-rxjs/no-async-subscribe"; +import { convertNoIgnoredTakeWhileValue } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-takewhile-value"; /** * Keys TSLint rule names to their ESLint rule converters. @@ -368,6 +369,7 @@ export const ruleConverters = new Map([ ["use-pipe-transform-interface", convertUsePipeTransformInterface], ["variable-name", convertVariableName], ["rxjs-no-async-subscribe", convertNoAsyncSubscribe], + ["rxjs-no-ignored-takewhile-value", convertNoIgnoredTakeWhileValue], // These converters are all for rules that need more complex option conversions. // Some of them will likely need to have notices about changed lint behaviors... diff --git a/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-ignored-takewhile-value.ts b/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-ignored-takewhile-value.ts new file mode 100644 index 000000000..bd897e0ff --- /dev/null +++ b/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-ignored-takewhile-value.ts @@ -0,0 +1,12 @@ +import { RuleConverter } from "../../ruleConverter"; + +export const convertNoIgnoredTakeWhileValue: RuleConverter = () => { + return { + rules: [ + { + ruleName: "rxjs/no-ignored-takewhile-value", + }, + ], + plugins: ["eslint-plugin-rxjs"], + }; +}; diff --git a/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-ignored-takewhile-value.test.ts b/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-ignored-takewhile-value.test.ts new file mode 100644 index 000000000..85ee86321 --- /dev/null +++ b/src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-ignored-takewhile-value.test.ts @@ -0,0 +1,18 @@ +import { convertNoIgnoredTakeWhileValue } from "../no-ignored-takewhile-value"; + +describe(convertNoIgnoredTakeWhileValue, () => { + test("conversion without arguments", () => { + const result = convertNoIgnoredTakeWhileValue({ + ruleArguments: [], + }); + + expect(result).toEqual({ + rules: [ + { + ruleName: "rxjs/no-ignored-takewhile-value", + }, + ], + plugins: ["eslint-plugin-rxjs"], + }); + }); +});