From 0ab1b4e0b2692b82c0e139de6796827691a36219 Mon Sep 17 00:00:00 2001 From: inottn Date: Tue, 20 Aug 2024 12:26:57 +0800 Subject: [PATCH 1/2] fix: assetsInfo may be undefined --- src/utils/getFilenameFromUrl.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/utils/getFilenameFromUrl.js b/src/utils/getFilenameFromUrl.js index 2f034060f..cff1b5587 100644 --- a/src/utils/getFilenameFromUrl.js +++ b/src/utils/getFilenameFromUrl.js @@ -123,11 +123,13 @@ function getFilenameFromUrl(context, url, extra = {}) { if (extra.stats.isFile()) { foundFilename = filename; - const assetInfo = assetsInfo.get( - pathname.slice(publicPathObject.pathname.length), - ); + if (assetsInfo) { + const assetInfo = assetsInfo.get( + pathname.slice(publicPathObject.pathname.length), + ); - extra.immutable = assetInfo ? assetInfo.immutable : false; + extra.immutable = assetInfo ? assetInfo.immutable : false; + } break; } else if ( From 995f8fbea5d34e49f976239be870efdb0bcc2430 Mon Sep 17 00:00:00 2001 From: inottn Date: Tue, 20 Aug 2024 20:00:37 +0800 Subject: [PATCH 2/2] chore: add comment --- src/utils/getFilenameFromUrl.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/utils/getFilenameFromUrl.js b/src/utils/getFilenameFromUrl.js index cff1b5587..0fe40c232 100644 --- a/src/utils/getFilenameFromUrl.js +++ b/src/utils/getFilenameFromUrl.js @@ -123,6 +123,7 @@ function getFilenameFromUrl(context, url, extra = {}) { if (extra.stats.isFile()) { foundFilename = filename; + // Rspack does not yet support `assetsInfo`, so we need to check if `assetsInfo` exists here if (assetsInfo) { const assetInfo = assetsInfo.get( pathname.slice(publicPathObject.pathname.length),