Use XCTExpectFailure instead of skipping a couple of tests

mokagio · mokagio · commit 4f6afce55753 · 2025-06-10T16:34:59.000+10:00
diff --git a/Modules/Tests/NetworkingTests/Remote/WCPayRemoteTests.swift b/Modules/Tests/NetworkingTests/Remote/WCPayRemoteTests.swift
@@ -112,6 +112,8 @@ final class WCPayRemoteTests: XCTestCase {
 
         XCTAssertTrue(result.isSuccess)
         let account = try result.get()
+
+        XCTExpectFailure("isCardPresentEligible has been hardcoded to true. See https://github.com/woocommerce/woocommerce-ios/pull/5030")
         XCTAssertEqual(account.isCardPresentEligible, false)
     }
 
@@ -131,6 +133,8 @@ final class WCPayRemoteTests: XCTestCase {
 
         XCTAssertTrue(result.isSuccess)
         let account = try result.get()
+
+        XCTExpectFailure("isCardPresentEligible has been hardcoded to true. See https://github.com/woocommerce/woocommerce-ios/pull/5030")
         XCTAssertEqual(account.isCardPresentEligible, false)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,8 @@ final class WCPayRemoteTests: XCTestCase {`
`112`	`112`
`113`	`113`	`XCTAssertTrue(result.isSuccess)`
`114`	`114`	`let account = try result.get()`
	`115`	`+`
	`116`	`+ XCTExpectFailure("isCardPresentEligible has been hardcoded to true. See https://github.com/woocommerce/woocommerce-ios/pull/5030")`
`115`	`117`	`XCTAssertEqual(account.isCardPresentEligible, false)`
`116`	`118`	`}`
`117`	`119`
`@@ -131,6 +133,8 @@ final class WCPayRemoteTests: XCTestCase {`
`131`	`133`
`132`	`134`	`XCTAssertTrue(result.isSuccess)`
`133`	`135`	`let account = try result.get()`
	`136`	`+`
	`137`	`+ XCTExpectFailure("isCardPresentEligible has been hardcoded to true. See https://github.com/woocommerce/woocommerce-ios/pull/5030")`
`134`	`138`	`XCTAssertEqual(account.isCardPresentEligible, false)`
`135`	`139`	`}`
`136`	`140`